Fix error with issue fetching

Author: kriskbx

gtt-report.js

@@ -110,7 +110,7 @@ new Promise(resolve => {
 // get project
     .then(() => {
         Cli.list(`${Cli.look}  Resolving project "${config.get('project')}"`);
-        return report.project();
+        return report.getProject();
     })
 
     // get members
@@ -135,7 +135,7 @@ new Promise(resolve => {
         if (!config.get('query').includes('issues')) return resolve();
 
         Cli.list(`${Cli.fetch}  Fetching issues`);
-        report.issues()
+        report.getIssues()
             .then(() => Cli.mark())
             .catch(error => Cli.x(`could not fetch issues.`, error))
             .then(() => resolve());
@@ -146,7 +146,7 @@ new Promise(resolve => {
         if (!config.get('query').includes('merge_requests')) return resolve();
 
         Cli.list(`${Cli.fetch}  Fetching merge requests`);
-        report.mergeRequests()
+        report.getMergeRequests()
             .then(() => Cli.mark())
             .catch(error => Cli.x(`could not fetch merge requests.`, error))
             .then(() => resolve());
@@ -176,6 +176,8 @@ new Promise(resolve => {
 
     // make report
     .then(() => new Promise(resolve => {
+        if (report.issues.length === 0 && report.mergeRequests.length === 0) Cli.error('No issues or merge requests matched your criteria.');
+
         Cli.list(`${Cli.output}  Making report`);
 
         output = new Output[config.get('output')](config, report);

models/report.js

@@ -10,6 +10,17 @@ const Project = require('./project');
  * report model
  */
 class report extends Base {
+    /**
+     * constructor.
+     * @param config
+     */
+    constructor(config) {
+        super(config);
+
+        this.issues = [];
+        this.mergeRequests = [];
+    }
+
     /**
      * get params for querying issues and merge requests
      * @returns {string}
@@ -40,7 +51,7 @@ class report extends Base {
      * query and set the project
      * @returns {Promise}
      */
-    project() {
+    getProject() {
         let promise = this.get(`projects/${encodeURIComponent(this.config.get('project'))}`);
         promise.then(project => this.project = new Project(this.config, project.body));
 
@@ -51,9 +62,9 @@ class report extends Base {
      * query and set merge requests
      * @returns {Promise}
      */
-    mergeRequests() {
+    getMergeRequests() {
         let promise = this.all(`projects/${this.project.id}/merge_requests${this.params()}`);
-        promise.then(mergeRequests => this.mergeRequests = report.filter(mergeRequests));
+        promise.then(mergeRequests => this.mergeRequests = mergeRequests);
 
         return promise;
     }
@@ -62,9 +73,9 @@ class report extends Base {
      * query and set issues
      * @returns {Promise}
      */
-    issues() {
+    getIssues() {
         let promise = this.all(`projects/${this.project.id}/issues${this.params()}`);
-        promise.then(issues => this.issues = report.filter(issues));
+        promise.then(issues => this.issues = issues);
 
         return promise;
     }
@@ -75,7 +86,7 @@ class report extends Base {
      * @returns {Array}
      */
     static filter(issues) {
-        return issues.filter(issue => issue.times.length > 0);
+        return issues.filter(issue => issue.times && issue.times.length > 0);
     }
 
     /**
@@ -108,7 +119,7 @@ class report extends Base {
                 });
         });
 
-        promise.then(() => this[input] = collect);
+        promise.then(() => this[input] = report.filter(collect));
         return promise;
     }