Skip to content

Commit bb7b854

Browse files
committed
Moved method to set logging level from Tracker constructor to __init__.py (snowplow#76)
1 parent e15939f commit bb7b854

2 files changed

Lines changed: 4 additions & 15 deletions

File tree

snowplow_tracker/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from snowplow_tracker._version import __version__
22
from snowplow_tracker.subject import Subject
3-
from snowplow_tracker.consumer import Consumer, AsyncConsumer, CeleryConsumer, RedisConsumer
3+
from snowplow_tracker.consumer import logger, Consumer, AsyncConsumer, CeleryConsumer, RedisConsumer
44
from snowplow_tracker.tracker import Tracker
5-
from contracts import disable_all, enable_all
5+
from contracts import disable_all as disable_contracts, enable_all as enable_contracts

snowplow_tracker/tracker.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,14 @@
2121

2222
import time
2323
import random
24-
import logging
2524
from snowplow_tracker import payload, _version, subject
26-
from contracts import contract, new_contract, disable_all
27-
25+
from contracts import contract, new_contract
2826

2927

3028
"""
3129
Constants & config
3230
"""
3331

34-
logger = logging.getLogger()
35-
logger.setLevel(logging.DEBUG)
36-
3732
VERSION = "py-%s" % _version.__version__
3833
DEFAULT_ENCODE_BASE64 = True
3934
DEFAULT_VENDOR = "com.snowplowanalytics"
@@ -57,8 +52,7 @@ class Tracker:
5752

5853
@contract
5954
def __init__(self, out_queue, _subject=None,
60-
namespace=None, app_id=None, context_vendor=None, encode_base64=DEFAULT_ENCODE_BASE64,
61-
log=True):
55+
namespace=None, app_id=None, context_vendor=None, encode_base64=DEFAULT_ENCODE_BASE64):
6256
"""
6357
:param out_queue: Consumer to which events will be sent
6458
:type out_queue: consumer
@@ -72,12 +66,7 @@ def __init__(self, out_queue, _subject=None,
7266
:type context_vendor: string_or_none
7367
:param encode_base64: Whether JSONs in the payload should be base-64 encoded
7468
:type encode_base64: bool
75-
:param log: Whether to enable Python logging
76-
:type log: bool
7769
"""
78-
if not log:
79-
logger.setLevel(logging.CRITICAL)
80-
8170
if _subject is None:
8271
_subject = subject.Subject()
8372

0 commit comments

Comments
 (0)