Skip to content

[Bug] Fix server selection during manual test runs #2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexjustesen merged 16 commits into from
May 9, 2025
Merged

[Bug] Fix server selection during manual test runs #2176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2cb63e0
add templates
svenvg93 Apr 3, 2025
8495bb9
Merge branch 'main' of https://github.com/svenvg93/speedtest-tracker
svenvg93 Apr 3, 2025
782e18a
Update general.yml
svenvg93 Apr 6, 2025
1c8932f
Update q-a.yml
svenvg93 Apr 6, 2025
b2eb35f
Merge branch 'alexjustesen:main' into main
svenvg93 Apr 11, 2025
768689b
Merge branch 'alexjustesen:main' into main
svenvg93 Apr 12, 2025
dc23352
Update BUG_REPORT_FORM.yml
svenvg93 Apr 14, 2025
ce90684
Fix links
svenvg93 Apr 14, 2025
c3e5ab9
Merge branch 'main' of https://github.com/svenvg93/speedtest-tracker
svenvg93 Apr 16, 2025
ac61958
delte it
svenvg93 Apr 16, 2025
a3f4ca8
Merge branch 'main' of https://github.com/svenvg93/speedtest-tracker
svenvg93 Apr 29, 2025
1f038b5
Merge branch 'main' of https://github.com/svenvg93/speedtest-tracker
svenvg93 Apr 29, 2025
eb6d203
Skip config server when not scheduled
svenvg93 Apr 30, 2025
4c71316
Change helper text
svenvg93 Apr 30, 2025
ca5f3d0
Merge branch 'main' into 2174-fix-server-selection-manual-test
svenvg93 May 8, 2025
5ed2a56
Merge branch 'main' into 2174-fix-server-selection-manual-test
alexjustesen May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/Jobs/Ookla/SelectSpeedtestServerJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@ public function handle(): void
return;
}

// If preferred servers are set in the config, we can use that.
if (! blank(config('speedtest.servers'))) {
// If preferred servers are set in the config, we can use that,
// but only if the test is scheduled.
if ($this->result->scheduled && ! blank(config('speedtest.servers'))) {
$this->updateServerId(
result: $this->result,
serverId: $this->getConfigServer(),
Expand Down
2 changes: 1 addition & 1 deletion app/Livewire/Topbar/RunSpeedtestAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function speedtestAction(): Action
->form([
Select::make('server_id')
->label('Select Server')
->helperText('Leave empty to run the speedtest without specifying a server.')
->helperText('Leave empty to run the speedtest without specifying a server. Blocked servers will be skipped.')
->options(function (): array {
return array_filter([
'Manual servers' => Ookla::getConfigServers(),
Expand Down