Skip to content

[Chore] Update policies to use Illuminate\Auth\Access\Response #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexjustesen merged 1 commit into from
Dec 11, 2024
Merged

[Chore] Update policies to use Illuminate\Auth\Access\Response #1908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions app/Policies/ResultPolicy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,71 +4,75 @@

use App\Models\Result;
use App\Models\User;
use Illuminate\Auth\Access\Response;

class ResultPolicy
{
/**
* Determine whether the user can view any models.
*/
public function viewAny(User $user): bool
public function viewAny(User $user): Response
{
return true;
return Response::allow();
}

/**
* Determine whether the user can view the model.
*/
public function view(User $user, Result $result): bool
public function view(User $user, Result $result): Response
{
return true;
return Response::allow();
}

/**
* Determine whether the user can create models.
*/
public function create(User $user): bool
public function create(User $user): Response
{
return false;
return Response::deny();
}

/**
* Determine whether the user can update the model.
*/
public function update(User $user, Result $result): bool
public function update(User $user, Result $result): Response
{
return $user->is_admin
|| $user->is_user;
return Response::allow();
}

/**
* Determine whether the user can bulk delete any model.
*/
public function deleteAny(User $user)
public function deleteAny(User $user): Response
{
return $user->is_admin;
return $user->is_admin
? Response::allow()
: Response::deny('You do not have permission to delete results.');
}

/**
* Determine whether the user can delete the model.
*/
public function delete(User $user, Result $result): bool
public function delete(User $user, Result $result): Response
{
return $user->is_admin;
return $user->is_admin
? Response::allow()
: Response::deny('You do not have permission to delete this result.');
}

/**
* Determine whether the user can restore the model.
*/
public function restore(User $user, Result $result): bool
public function restore(User $user, Result $result): Response
{
return false; // soft deletes not used
return Response::deny(); // soft deletes not used
}

/**
* Determine whether the user can permanently delete the model.
*/
public function forceDelete(User $user, Result $result): bool
public function forceDelete(User $user, Result $result): Response
{
return false; // soft deletes not used
return Response::deny(); // soft deletes not used
}
}
50 changes: 32 additions & 18 deletions app/Policies/UserPolicy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,75 +3,89 @@
namespace App\Policies;

use App\Models\User;
use Illuminate\Auth\Access\Response;

class UserPolicy
{
/**
* Determine whether the user can view any models.
*/
public function viewAny(User $user): bool
public function viewAny(User $user): Response
{
return $user->is_admin;
return $user->is_admin
? Response::allow()
: Response::deny('You do not have permission to view users.');
}

/**
* Determine whether the user can view the model.
*/
public function view(User $user, User $model): bool
public function view(User $user, User $model): Response
{
return $user->is_admin;
return $user->is_admin
? Response::allow()
: Response::deny('You do not have permission to view this user.');
}

/**
* Determine whether the user can create models.
*/
public function create(User $user): bool
public function create(User $user): Response
{
return $user->is_admin;
return $user->is_admin
? Response::allow()
: Response::deny('You do not have permission to create a new user.');
}

/**
* Determine whether the user can update the model.
*/
public function update(User $user, User $model): bool
public function update(User $user, User $model): Response
{
if ($user->id == $model->id) {
return true;
if ($model->is($user)) {
return Response::deny('You cannot update your own account.');
}

return $user->is_admin;
return $user->is_admin
? Response::allow()
: Response::deny('You do not have permission to update this user.');
}

/**
* Determine whether the user can bulk delete any model.
*/
public function deleteAny(User $user): bool
public function deleteAny(User $user): Response
{
return false;
return Response::deny('You do not have permission to delete users.');
}

/**
* Determine whether the user can delete the model.
*/
public function delete(User $user, User $model): bool
public function delete(User $user, User $model): Response
{
if ($model->is_admin) {
return Response::deny('You cannot delete an admin user.');
}

return $user->is_admin
&& ! $model->is_admin;
? Response::allow()
: Response::deny('You do not have permission to delete this user.');
}

/**
* Determine whether the user can restore the model.
*/
public function restore(User $user, User $model): bool
public function restore(User $user, User $model): Response
{
return false; // soft deletes not used
return Response::deny(); // soft deletes not used
}

/**
* Determine whether the user can permanently delete the model.
*/
public function forceDelete(User $user, User $model): bool
public function forceDelete(User $user, User $model): Response
{
return false; // soft deletes not used
return Response::deny(); // soft deletes not used
}
}