bug: fix prometheus metrics on failed test (#2674)

Co-authored-by: Alex Justesen <[email protected]>

Author: svenvg93

app/Services/PrometheusMetricsService.php

@@ -2,6 +2,7 @@
 
 namespace App\Services;
 
+use App\Enums\ResultStatus;
 use App\Models\Result;
 use App\Settings\DataIntegrationSettings;
 use Illuminate\Support\Facades\Cache;
@@ -44,6 +45,21 @@ protected function registerMetrics(CollectorRegistry $registry, Result $result):
         $labelNames = array_keys($labels);
         $labelValues = array_values($labels);
 
+        // Info metric - always exported so users can see test status (including failures)
+        $infoGauge = $registry->getOrRegisterGauge(
+            'speedtest_tracker',
+            'result_id',
+            'Speedtest result id',
+            $labelNames
+        );
+        $infoGauge->set($result->id, $labelValues);
+
+        // Only export numeric metrics for completed tests
+        // Failed/incomplete tests won't have valid measurements
+        if ($result->status !== ResultStatus::Completed) {
+            return;
+        }
+
         // Download speed in bytes
         $downloadBytesGauge = $registry->getOrRegisterGauge(
             'speedtest_tracker',
@@ -96,7 +112,7 @@ protected function registerMetrics(CollectorRegistry $registry, Result $result):
             'Ping jitter in milliseconds',
             $labelNames
         );
-        $pingJitterGauge->set($result->ping_jitter ?? 0, $labelValues);
+        $pingJitterGauge->set($result->ping_jitter, $labelValues);
 
         // Download jitter
         $downloadJitterGauge = $registry->getOrRegisterGauge(
@@ -105,7 +121,7 @@ protected function registerMetrics(CollectorRegistry $registry, Result $result):
             'Download jitter in milliseconds',
             $labelNames
         );
-        $downloadJitterGauge->set($result->download_jitter ?? 0, $labelValues);
+        $downloadJitterGauge->set($result->download_jitter, $labelValues);
 
         // Upload jitter
         $uploadJitterGauge = $registry->getOrRegisterGauge(
@@ -114,7 +130,7 @@ protected function registerMetrics(CollectorRegistry $registry, Result $result):
             'Upload jitter in milliseconds',
             $labelNames
         );
-        $uploadJitterGauge->set($result->upload_jitter ?? 0, $labelValues);
+        $uploadJitterGauge->set($result->upload_jitter, $labelValues);
 
         // Packet loss
         $packetLossGauge = $registry->getOrRegisterGauge(
@@ -123,7 +139,7 @@ protected function registerMetrics(CollectorRegistry $registry, Result $result):
             'Packet loss percentage',
             $labelNames
         );
-        $packetLossGauge->set($result->packet_loss ?? 0, $labelValues);
+        $packetLossGauge->set($result->packet_loss, $labelValues);
 
         // Ping latency low/high
         $pingLowGauge = $registry->getOrRegisterGauge(
@@ -132,15 +148,15 @@ protected function registerMetrics(CollectorRegistry $registry, Result $result):
             'Ping low latency in milliseconds',
             $labelNames
         );
-        $pingLowGauge->set($result->ping_low ?? 0, $labelValues);
+        $pingLowGauge->set($result->ping_low, $labelValues);
 
         $pingHighGauge = $registry->getOrRegisterGauge(
             'speedtest_tracker',
             'ping_high_ms',
             'Ping high latency in milliseconds',
             $labelNames
         );
-        $pingHighGauge->set($result->ping_high ?? 0, $labelValues);
+        $pingHighGauge->set($result->ping_high, $labelValues);
 
         // Download latency metrics (IQM = Interquartile Mean - more reliable than average)
         $downloadLatencyIqmGauge = $registry->getOrRegisterGauge(
@@ -149,23 +165,23 @@ protected function registerMetrics(CollectorRegistry $registry, Result $result):
             'Download latency interquartile mean in milliseconds',
             $labelNames
         );
-        $downloadLatencyIqmGauge->set($result->downloadlatencyiqm ?? 0, $labelValues);
+        $downloadLatencyIqmGauge->set($result->downloadlatencyiqm, $labelValues);
 
         $downloadLatencyLowGauge = $registry->getOrRegisterGauge(
             'speedtest_tracker',
             'download_latency_low_ms',
             'Download latency low in milliseconds',
             $labelNames
         );
-        $downloadLatencyLowGauge->set($result->downloadlatency_low ?? 0, $labelValues);
+        $downloadLatencyLowGauge->set($result->downloadlatency_low, $labelValues);
 
         $downloadLatencyHighGauge = $registry->getOrRegisterGauge(
             'speedtest_tracker',
             'download_latency_high_ms',
             'Download latency high in milliseconds',
             $labelNames
         );
-        $downloadLatencyHighGauge->set($result->downloadlatency_high ?? 0, $labelValues);
+        $downloadLatencyHighGauge->set($result->downloadlatency_high, $labelValues);
 
         // Upload latency metrics
         $uploadLatencyIqmGauge = $registry->getOrRegisterGauge(
@@ -174,23 +190,23 @@ protected function registerMetrics(CollectorRegistry $registry, Result $result):
             'Upload latency interquartile mean in milliseconds',
             $labelNames
         );
-        $uploadLatencyIqmGauge->set($result->uploadlatencyiqm ?? 0, $labelValues);
+        $uploadLatencyIqmGauge->set($result->uploadlatencyiqm, $labelValues);
 
         $uploadLatencyLowGauge = $registry->getOrRegisterGauge(
             'speedtest_tracker',
             'upload_latency_low_ms',
             'Upload latency low in milliseconds',
             $labelNames
         );
-        $uploadLatencyLowGauge->set($result->uploadlatency_low ?? 0, $labelValues);
+        $uploadLatencyLowGauge->set($result->uploadlatency_low, $labelValues);
 
         $uploadLatencyHighGauge = $registry->getOrRegisterGauge(
             'speedtest_tracker',
             'upload_latency_high_ms',
             'Upload latency high in milliseconds',
             $labelNames
         );
-        $uploadLatencyHighGauge->set($result->uploadlatency_high ?? 0, $labelValues);
+        $uploadLatencyHighGauge->set($result->uploadlatency_high, $labelValues);
 
         // Bytes transferred during test
         $downloadedBytesGauge = $registry->getOrRegisterGauge(
@@ -199,15 +215,15 @@ protected function registerMetrics(CollectorRegistry $registry, Result $result):
             'Total bytes downloaded during test',
             $labelNames
         );
-        $downloadedBytesGauge->set($result->downloaded_bytes ?? 0, $labelValues);
+        $downloadedBytesGauge->set($result->downloaded_bytes, $labelValues);
 
         $uploadedBytesGauge = $registry->getOrRegisterGauge(
             'speedtest_tracker',
             'uploaded_bytes',
             'Total bytes uploaded during test',
             $labelNames
         );
-        $uploadedBytesGauge->set($result->uploaded_bytes ?? 0, $labelValues);
+        $uploadedBytesGauge->set($result->uploaded_bytes, $labelValues);
 
         // Test duration
         $downloadElapsedGauge = $registry->getOrRegisterGauge(
@@ -216,15 +232,15 @@ protected function registerMetrics(CollectorRegistry $registry, Result $result):
             'Download test duration in milliseconds',
             $labelNames
         );
-        $downloadElapsedGauge->set($result->download_elapsed ?? 0, $labelValues);
+        $downloadElapsedGauge->set($result->download_elapsed, $labelValues);
 
         $uploadElapsedGauge = $registry->getOrRegisterGauge(
             'speedtest_tracker',
             'upload_elapsed_ms',
             'Upload test duration in milliseconds',
             $labelNames
         );
-        $uploadElapsedGauge->set($result->upload_elapsed ?? 0, $labelValues);
+        $uploadElapsedGauge->set($result->upload_elapsed, $labelValues);
     }
 
     protected function buildLabels(Result $result): array