Fixes for new lint requirements (#1742)

svenvg93 · web-flow · commit 83f0ed018acd · 2024-10-09T09:58:09.000-04:00
Fix for new lint version
diff --git a/app/Actions/MigrateBadJsonResults.php b/app/Actions/MigrateBadJsonResults.php
@@ -21,7 +21,7 @@ class MigrateBadJsonResults
 
     public function handle(User $user)
     {
-        $dataSettings = new DataMigrationSettings();
+        $dataSettings = new DataMigrationSettings;
 
         $tableName = 'results_bad_json';
 
diff --git a/app/Actions/Notifications/SendMailTestNotification.php b/app/Actions/Notifications/SendMailTestNotification.php
@@ -24,7 +24,7 @@ public function handle(array $recipients)
 
         foreach ($recipients as $recipient) {
             Mail::to($recipient)
-                ->send(new TestMail());
+                ->send(new TestMail);
         }
 
         Notification::make()
diff --git a/app/Filament/Resources/ResultResource.php b/app/Filament/Resources/ResultResource.php
@@ -153,7 +153,7 @@ public static function form(Form $form): Form
 
     public static function table(Table $table): Table
     {
-        $dataSettings = new DataMigrationSettings();
+        $dataSettings = new DataMigrationSettings;
 
         return $table
             ->columns([
diff --git a/app/Listeners/Data/InfluxDb2Listener.php b/app/Listeners/Data/InfluxDb2Listener.php
@@ -13,7 +13,7 @@ class InfluxDb2Listener
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $influxSettings = new InfluxDbSettings();
+        $influxSettings = new InfluxDbSettings;
 
         if ($influxSettings->v2_enabled) {
             WriteCompletedSpeedtest::dispatch($event->result, $influxSettings);
diff --git a/app/Listeners/Database/SendSpeedtestCompletedNotification.php b/app/Listeners/Database/SendSpeedtestCompletedNotification.php
@@ -14,7 +14,7 @@ class SendSpeedtestCompletedNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->database_enabled) {
             return;
diff --git a/app/Listeners/Database/SendSpeedtestThresholdNotification.php b/app/Listeners/Database/SendSpeedtestThresholdNotification.php
@@ -16,7 +16,7 @@ class SendSpeedtestThresholdNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->database_enabled) {
             return;
@@ -26,7 +26,7 @@ public function handle(SpeedtestCompleted $event): void
             return;
         }
 
-        $thresholdSettings = new ThresholdSettings();
+        $thresholdSettings = new ThresholdSettings;
 
         if (! $thresholdSettings->absolute_enabled) {
             return;
diff --git a/app/Listeners/Discord/SendSpeedtestCompletedNotification.php b/app/Listeners/Discord/SendSpeedtestCompletedNotification.php
@@ -16,7 +16,7 @@ class SendSpeedtestCompletedNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->discord_enabled) {
             return;
diff --git a/app/Listeners/Discord/SendSpeedtestThresholdNotification.php b/app/Listeners/Discord/SendSpeedtestThresholdNotification.php
@@ -17,7 +17,7 @@ class SendSpeedtestThresholdNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->discord_enabled) {
             return;
@@ -33,7 +33,7 @@ public function handle(SpeedtestCompleted $event): void
             return;
         }
 
-        $thresholdSettings = new ThresholdSettings();
+        $thresholdSettings = new ThresholdSettings;
 
         if (! $thresholdSettings->absolute_enabled) {
             return;
diff --git a/app/Listeners/Gotify/SendSpeedtestCompletedNotification.php b/app/Listeners/Gotify/SendSpeedtestCompletedNotification.php
@@ -16,7 +16,7 @@ class SendSpeedtestCompletedNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->gotify_enabled) {
             return;
diff --git a/app/Listeners/Gotify/SendSpeedtestThresholdNotification.php b/app/Listeners/Gotify/SendSpeedtestThresholdNotification.php
@@ -17,7 +17,7 @@ class SendSpeedtestThresholdNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->gotify_enabled) {
             return;
@@ -33,7 +33,7 @@ public function handle(SpeedtestCompleted $event): void
             return;
         }
 
-        $thresholdSettings = new ThresholdSettings();
+        $thresholdSettings = new ThresholdSettings;
 
         if (! $thresholdSettings->absolute_enabled) {
             return;
diff --git a/app/Listeners/HealthCheck/SendSpeedtestCompletedNotification.php b/app/Listeners/HealthCheck/SendSpeedtestCompletedNotification.php
@@ -14,7 +14,7 @@ class SendSpeedtestCompletedNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->healthcheck_enabled) {
             return;
diff --git a/app/Listeners/HealthCheck/SendSpeedtestThresholdNotification.php b/app/Listeners/HealthCheck/SendSpeedtestThresholdNotification.php
@@ -16,7 +16,7 @@ class SendSpeedtestThresholdNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->healthcheck_enabled) {
             return;
@@ -32,7 +32,7 @@ public function handle(SpeedtestCompleted $event): void
             return;
         }
 
-        $thresholdSettings = new ThresholdSettings();
+        $thresholdSettings = new ThresholdSettings;
 
         if (! $thresholdSettings->absolute_enabled) {
             return;
diff --git a/app/Listeners/Mail/SendSpeedtestCompletedNotification.php b/app/Listeners/Mail/SendSpeedtestCompletedNotification.php
@@ -15,7 +15,7 @@ class SendSpeedtestCompletedNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->mail_enabled) {
             return;
diff --git a/app/Listeners/Mail/SendSpeedtestThresholdNotification.php b/app/Listeners/Mail/SendSpeedtestThresholdNotification.php
@@ -17,7 +17,7 @@ class SendSpeedtestThresholdNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->mail_enabled) {
             return;
@@ -33,7 +33,7 @@ public function handle(SpeedtestCompleted $event): void
             return;
         }
 
-        $thresholdSettings = new ThresholdSettings();
+        $thresholdSettings = new ThresholdSettings;
 
         if (! $thresholdSettings->absolute_enabled) {
             return;
diff --git a/app/Listeners/Ntfy/SendSpeedtestCompletedNotification.php b/app/Listeners/Ntfy/SendSpeedtestCompletedNotification.php
@@ -16,7 +16,7 @@ class SendSpeedtestCompletedNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->ntfy_enabled) {
             return;
diff --git a/app/Listeners/Ntfy/SendSpeedtestThresholdNotification.php b/app/Listeners/Ntfy/SendSpeedtestThresholdNotification.php
@@ -17,7 +17,7 @@ class SendSpeedtestThresholdNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->ntfy_enabled) {
             return;
@@ -33,7 +33,7 @@ public function handle(SpeedtestCompleted $event): void
             return;
         }
 
-        $thresholdSettings = new ThresholdSettings();
+        $thresholdSettings = new ThresholdSettings;
 
         if (! $thresholdSettings->absolute_enabled) {
             return;
diff --git a/app/Listeners/Pushover/SendSpeedtestCompletedNotification.php b/app/Listeners/Pushover/SendSpeedtestCompletedNotification.php
@@ -16,7 +16,7 @@ class SendSpeedtestCompletedNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->pushover_enabled) {
             return;
diff --git a/app/Listeners/Pushover/SendSpeedtestThresholdNotification.php b/app/Listeners/Pushover/SendSpeedtestThresholdNotification.php
@@ -17,7 +17,7 @@ class SendSpeedtestThresholdNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->pushover_enabled) {
             return;
@@ -33,7 +33,7 @@ public function handle(SpeedtestCompleted $event): void
             return;
         }
 
-        $thresholdSettings = new ThresholdSettings();
+        $thresholdSettings = new ThresholdSettings;
 
         if (! $thresholdSettings->absolute_enabled) {
             return;
diff --git a/app/Listeners/Slack/SendSpeedtestCompletedNotification.php b/app/Listeners/Slack/SendSpeedtestCompletedNotification.php
@@ -16,7 +16,7 @@ class SendSpeedtestCompletedNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->slack_enabled) {
             return;
diff --git a/app/Listeners/Slack/SendSpeedtestThresholdNotification.php b/app/Listeners/Slack/SendSpeedtestThresholdNotification.php
@@ -17,7 +17,7 @@ class SendSpeedtestThresholdNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->slack_enabled) {
             return;
@@ -33,7 +33,7 @@ public function handle(SpeedtestCompleted $event): void
             return;
         }
 
-        $thresholdSettings = new ThresholdSettings();
+        $thresholdSettings = new ThresholdSettings;
 
         if (! $thresholdSettings->absolute_enabled) {
             return;
diff --git a/app/Listeners/Telegram/SendSpeedtestCompletedNotification.php b/app/Listeners/Telegram/SendSpeedtestCompletedNotification.php
@@ -17,7 +17,7 @@ class SendSpeedtestCompletedNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->telegram_enabled) {
             return;
diff --git a/app/Listeners/Telegram/SendSpeedtestThresholdNotification.php b/app/Listeners/Telegram/SendSpeedtestThresholdNotification.php
@@ -18,7 +18,7 @@ class SendSpeedtestThresholdNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->telegram_enabled) {
             return;
@@ -34,7 +34,7 @@ public function handle(SpeedtestCompleted $event): void
             return;
         }
 
-        $thresholdSettings = new ThresholdSettings();
+        $thresholdSettings = new ThresholdSettings;
 
         if (! $thresholdSettings->absolute_enabled) {
             return;
diff --git a/app/Listeners/Webhook/SendSpeedtestCompletedNotification.php b/app/Listeners/Webhook/SendSpeedtestCompletedNotification.php
@@ -14,7 +14,7 @@ class SendSpeedtestCompletedNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->webhook_enabled) {
             return;
diff --git a/app/Listeners/Webhook/SendSpeedtestThresholdNotification.php b/app/Listeners/Webhook/SendSpeedtestThresholdNotification.php
@@ -16,7 +16,7 @@ class SendSpeedtestThresholdNotification
      */
     public function handle(SpeedtestCompleted $event): void
     {
-        $notificationSettings = new NotificationSettings();
+        $notificationSettings = new NotificationSettings;
 
         if (! $notificationSettings->webhook_enabled) {
             return;
@@ -32,7 +32,7 @@ public function handle(SpeedtestCompleted $event): void
             return;
         }
 
-        $thresholdSettings = new ThresholdSettings();
+        $thresholdSettings = new ThresholdSettings;
 
         if (! $thresholdSettings->absolute_enabled) {
             return;
diff --git a/app/Notifications/Telegram/TestNotification.php b/app/Notifications/Telegram/TestNotification.php
@@ -21,7 +21,7 @@ class TestNotification extends Notification implements ShouldQueue
      */
     public function __construct()
     {
-        $this->settings = new NotificationSettings();
+        $this->settings = new NotificationSettings;
     }
 
     /**
diff --git a/app/Providers/Filament/AdminPanelProvider.php b/app/Providers/Filament/AdminPanelProvider.php
@@ -49,7 +49,7 @@ public function panel(Panel $panel): Panel
                 VersionsPlugin::make()
                     ->hasDefaults(false)
                     ->items([
-                        new SpeedtestTrackerVersionProvider(),
+                        new SpeedtestTrackerVersionProvider,
                     ]),
             ])
             ->discoverWidgets(in: app_path('Filament/Widgets'), for: 'App\\Filament\\Widgets')
diff --git a/database/migrations/2024_02_18_100000_results_bad_json_table.php b/database/migrations/2024_02_18_100000_results_bad_json_table.php
@@ -48,7 +48,7 @@ public function up(): void
          * Don't disable the schedule or send a notification if there are no records.
          */
         if (! DB::table('results_bad_json')->count()) {
-            $dataSettings = new DataMigrationSettings();
+            $dataSettings = new DataMigrationSettings;
 
             $dataSettings->bad_json_migrated = true;
 
diff --git a/database/migrations/2024_02_19_134706_create_imports_table.php b/database/migrations/2024_02_19_134706_create_imports_table.php
@@ -4,7 +4,7 @@
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-return new class() extends Migration
+return new class extends Migration
 {
     /**
      * Run the migrations.
diff --git a/database/migrations/2024_02_19_134707_create_exports_table.php b/database/migrations/2024_02_19_134707_create_exports_table.php
@@ -4,7 +4,7 @@
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-return new class() extends Migration
+return new class extends Migration
 {
     /**
      * Run the migrations.
diff --git a/database/migrations/2024_02_19_134708_create_failed_import_rows_table.php b/database/migrations/2024_02_19_134708_create_failed_import_rows_table.php
@@ -4,7 +4,7 @@
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-return new class() extends Migration
+return new class extends Migration
 {
     /**
      * Run the migrations.

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class MigrateBadJsonResults`
`21`	`21`
`22`	`22`	`public function handle(User $user)`
`23`	`23`	`{`
`24`		`- $dataSettings = new DataMigrationSettings();`
	`24`	`+ $dataSettings = new DataMigrationSettings;`
`25`	`25`
`26`	`26`	`$tableName = 'results_bad_json';`
`27`	`27`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public function handle(array $recipients)`
`24`	`24`
`25`	`25`	`foreach ($recipients as $recipient) {`
`26`	`26`	`Mail::to($recipient)`
`27`		`- ->send(new TestMail());`
	`27`	`+ ->send(new TestMail);`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`Notification::make()`
Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ public static function form(Form $form): Form`
`153`	`153`
`154`	`154`	`public static function table(Table $table): Table`
`155`	`155`	`{`
`156`		`- $dataSettings = new DataMigrationSettings();`
	`156`	`+ $dataSettings = new DataMigrationSettings;`
`157`	`157`
`158`	`158`	`return $table`
`159`	`159`	`->columns([`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ class InfluxDb2Listener`
`13`	`13`	`*/`
`14`	`14`	`public function handle(SpeedtestCompleted $event): void`
`15`	`15`	`{`
`16`		`- $influxSettings = new InfluxDbSettings();`
	`16`	`+ $influxSettings = new InfluxDbSettings;`
`17`	`17`
`18`	`18`	`if ($influxSettings->v2_enabled) {`
`19`	`19`	`WriteCompletedSpeedtest::dispatch($event->result, $influxSettings);`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ class SendSpeedtestCompletedNotification`
`14`	`14`	`*/`
`15`	`15`	`public function handle(SpeedtestCompleted $event): void`
`16`	`16`	`{`
`17`		`- $notificationSettings = new NotificationSettings();`
	`17`	`+ $notificationSettings = new NotificationSettings;`
`18`	`18`
`19`	`19`	`if (! $notificationSettings->database_enabled) {`
`20`	`20`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ class SendSpeedtestThresholdNotification`
`16`	`16`	`*/`
`17`	`17`	`public function handle(SpeedtestCompleted $event): void`
`18`	`18`	`{`
`19`		`- $notificationSettings = new NotificationSettings();`
	`19`	`+ $notificationSettings = new NotificationSettings;`
`20`	`20`
`21`	`21`	`if (! $notificationSettings->database_enabled) {`
`22`	`22`	`return;`
`@@ -26,7 +26,7 @@ public function handle(SpeedtestCompleted $event): void`
`26`	`26`	`return;`
`27`	`27`	`}`
`28`	`28`
`29`		`- $thresholdSettings = new ThresholdSettings();`
	`29`	`+ $thresholdSettings = new ThresholdSettings;`
`30`	`30`
`31`	`31`	`if (! $thresholdSettings->absolute_enabled) {`
`32`	`32`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ class SendSpeedtestCompletedNotification`
`16`	`16`	`*/`
`17`	`17`	`public function handle(SpeedtestCompleted $event): void`
`18`	`18`	`{`
`19`		`- $notificationSettings = new NotificationSettings();`
	`19`	`+ $notificationSettings = new NotificationSettings;`
`20`	`20`
`21`	`21`	`if (! $notificationSettings->discord_enabled) {`
`22`	`22`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ class SendSpeedtestThresholdNotification`
`17`	`17`	`*/`
`18`	`18`	`public function handle(SpeedtestCompleted $event): void`
`19`	`19`	`{`
`20`		`- $notificationSettings = new NotificationSettings();`
	`20`	`+ $notificationSettings = new NotificationSettings;`
`21`	`21`
`22`	`22`	`if (! $notificationSettings->discord_enabled) {`
`23`	`23`	`return;`
`@@ -33,7 +33,7 @@ public function handle(SpeedtestCompleted $event): void`
`33`	`33`	`return;`
`34`	`34`	`}`
`35`	`35`
`36`		`- $thresholdSettings = new ThresholdSettings();`
	`36`	`+ $thresholdSettings = new ThresholdSettings;`
`37`	`37`
`38`	`38`	`if (! $thresholdSettings->absolute_enabled) {`
`39`	`39`	`return;`