From d0f3dd3d915fa69a5e1df39824287d879ed138da Mon Sep 17 00:00:00 2001 From: Nicolas Giard Date: Tue, 4 Aug 2026 21:00:55 -0400 Subject: [PATCH 1/2] ci: remove coverage stats from release changelog (#11373) --- .github/workflows/reusable-build.yml | 31 ++++++---------------------- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/.github/workflows/reusable-build.yml b/.github/workflows/reusable-build.yml index 361174ea25..0ced85a206 100644 --- a/.github/workflows/reusable-build.yml +++ b/.github/workflows/reusable-build.yml @@ -93,7 +93,7 @@ jobs: run: | echo "Setting production flags in settings.py..." sed -i -r -e 's/^DEBUG *= *.*$/DEBUG = False/' -e "s/^SERVER_MODE *= *.*\$/SERVER_MODE = 'production'/" ietf/settings.py - + - name: Make Tarball env: DEBIAN_FRONTEND: noninteractive @@ -158,7 +158,7 @@ jobs: ghcr.io/ietf-tools/datatracker:${{ inputs.buildVersion }} ${{ env.FEATURE_LATEST_TAG && format('ghcr.io/ietf-tools/datatracker:{0}-latest', env.FEATURE_LATEST_TAG) || null }} - - name: Update CHANGELOG + - name: Generate CHANGELOG id: changelog uses: Requarks/changelog-action@v1 if: ${{ inputs.isReleaseBuild }} @@ -170,29 +170,10 @@ jobs: - name: Download Coverage Results if: ${{ inputs.handleCoverageResults }} - uses: actions/download-artifact@v8.0.1 + uses: actions/download-artifact@v8 with: name: coverage - - name: Prepare Coverage Action - if: ${{ inputs.handleCoverageResults }} - working-directory: ./dev/coverage-action - run: npm install - - - name: Process Coverage Stats + Chart - id: covprocess - uses: ./dev/coverage-action/ - if: ${{ inputs.handleCoverageResults }} - with: - token: ${{ github.token }} - tokenCommon: ${{ secrets.GH_COMMON_TOKEN }} - repoCommon: common - version: ${{ inputs.buildVersion }} - changelog: ${{ steps.changelog.outputs.changes }} - summary: '' - coverageResultsPath: coverage.json - histCoveragePath: historical-coverage.json - - name: Create Release uses: ncipollo/release-action@v1.21.0 if: ${{ inputs.isReleaseBuild }} @@ -202,8 +183,8 @@ jobs: draft: false tag: ${{ inputs.buildVersion }} name: ${{ inputs.buildVersion }} - body: ${{ steps.covprocess.outputs.changelog }} - artifacts: "/home/runner/work/release/release.tar.gz,coverage.json,historical-coverage.json" + body: ${{ steps.changelog.outputs.changes }} + artifacts: "/home/runner/work/release/release.tar.gz,coverage.json" token: ${{ secrets.GITHUB_TOKEN }} - name: Update Baseline Coverage @@ -218,7 +199,7 @@ jobs: replacesArtifacts: true artifacts: "coverage.json" token: ${{ secrets.GITHUB_TOKEN }} - + - name: Upload Build Artifacts uses: actions/upload-artifact@v7 with: From 1751fd9dc8518251146a75a7bb257c1e2707b864 Mon Sep 17 00:00:00 2001 From: Jennifer Richards Date: Wed, 5 Aug 2026 10:13:54 -0300 Subject: [PATCH 2/2] test: fix tz-dependence in test_rfc_authors (#11376) --- ietf/api/tests.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/ietf/api/tests.py b/ietf/api/tests.py index b8b69f8345..724a0b9d1e 100644 --- a/ietf/api/tests.py +++ b/ietf/api/tests.py @@ -1096,13 +1096,11 @@ def test_rfc_authors(self): two_days_ago = now - datetime.timedelta(days=2) three_days_ago = now - datetime.timedelta(days=3) long_long_ago = now - datetime.timedelta(days=400) - + # A recently published RFC with a known author... author = PersonFactory(name="Jane Q. Author") recent_rfc = WgRfcFactory(title="A Recently Published RFC") - recent_event = DocEventFactory( - doc=recent_rfc, type="published_rfc", time=two_days_ago - ) + DocEventFactory(doc=recent_rfc, type="published_rfc", time=two_days_ago) RfcAuthorFactory(document=recent_rfc, person=author) # ...and an RFC published well outside the default window, which must be excluded. @@ -1127,7 +1125,7 @@ def test_rfc_authors(self): row["rfc_number_and_title"], f"RFC {recent_rfc.rfc_number}: {recent_rfc.title}", ) - self.assertEqual(row["published_date"], str(recent_event.time.date())) + self.assertEqual(row["published_date"], str(recent_rfc.pub_date())) # A narrow window excludes the recent RFC, too. First, using from-only r = self.client.get( @@ -1211,7 +1209,6 @@ def test_rfc_authors(self): headers={"X-Api-Key": "valid-token"}, ) self.assertEqual(r.status_code, 400, "out-of-order from/to parameters") - @override_settings( APP_API_TOKENS={"ietf.api.views.ingest_email": "valid-token", "ietf.api.views.ingest_email_test": "test-token"}