Skip to content
This repository was archived by the owner on Oct 11, 2022. It is now read-only.

Commit 231d742

Browse files
fblundunalexanderdean
authored andcommitted
Removed pagepath argument from trackSocialInteraction
1 parent 455e87e commit 231d742

2 files changed

Lines changed: 4 additions & 8 deletions

File tree

core/lib/core.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -540,19 +540,17 @@ function trackerCore(base64, callback) {
540540
* @param string action Social action performed
541541
* @param string network Social network
542542
* @param string target Object of the social action e.g. the video liked, the tweet retweeted
543-
* @param string pagepath the URL of the page where the action occurred
544543
* @param array Custom contexts relating to the event
545544
* @param number tstamp Timestamp of the event
546545
* @return object Payload
547546
*/
548-
trackSocialInteraction: function (action, network, target, pagepath, context, tstamp) {
547+
trackSocialInteraction: function (action, network, target, context, tstamp) {
549548
var eventJson = {
550549
schema: 'iglu:com.snowplowanalytics.snowplow/social_interaction/jsonschema/1-0-0',
551550
data: removeEmptyProperties({
552551
action: action,
553552
network: network,
554-
target: target,
555-
pagepath: pagepath
553+
target: target
556554
})
557555
};
558556

core/tests/core.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -296,15 +296,13 @@ define([
296296
var action = 'like';
297297
var network = 'facebook';
298298
var target = 'status-0000345345';
299-
var pagepath = 'http://www.mypage.com';
300299

301300
var inputJson = {
302301
schema: 'iglu:com.snowplowanalytics.snowplow/social_interaction/jsonschema/1-0-0',
303302
data: {
304303
action: action,
305304
network: network,
306-
target: target,
307-
pagepath: pagepath
305+
target: target
308306
}
309307
};
310308

@@ -316,7 +314,7 @@ define([
316314
})
317315
};
318316

319-
compare(tracker.trackSocialInteraction(action, network, target, pagepath), expected);
317+
compare(tracker.trackSocialInteraction(action, network, target), expected);
320318
},
321319

322320

0 commit comments

Comments
 (0)