Skip to content

Commit 47d6bbb

Browse files
committed
Renamed the SubmissionEmail event class to SubmissionEmailEvent, and added an admin class for it.
- Legacy-Id: 11942
1 parent a531b7c commit 47d6bbb

8 files changed

Lines changed: 29 additions & 26 deletions

File tree

ietf/submit/admin.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from django.contrib import admin
33

44

5-
from ietf.submit.models import Preapproval, Submission, SubmissionEvent, SubmissionCheck
5+
from ietf.submit.models import Preapproval, Submission, SubmissionEvent, SubmissionCheck, SubmissionEmailEvent
66

77
class SubmissionAdmin(admin.ModelAdmin):
88
list_display = ['id', 'rev', 'draft_link', 'status_link', 'submission_date',]
@@ -40,3 +40,6 @@ class PreapprovalAdmin(admin.ModelAdmin):
4040
pass
4141
admin.site.register(Preapproval, PreapprovalAdmin)
4242

43+
class SubmissionEmailEventAdmin(admin.ModelAdmin):
44+
list_display = ['id', 'submission', 'time', 'by', 'message', 'desc', ]
45+
admin.site.register(SubmissionEmailEvent, SubmissionEmailEventAdmin)

ietf/submit/mail.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from ietf.message.models import Message, MessageAttachment
2020
from ietf.utils.accesstoken import generate_access_token
2121
from ietf.mailtrigger.utils import gather_address_lists, get_base_submission_message_address
22-
from ietf.submit.models import SubmissionEmail, Submission
22+
from ietf.submit.models import SubmissionEmailEvent, Submission
2323

2424
def send_submission_confirmation(request, submission, chair_notice=False):
2525
subject = 'Confirm submission of I-D %s' % submission.name
@@ -190,7 +190,7 @@ def process_response_email(msg):
190190
submission.name,
191191
submission.rev)
192192

193-
submission_email_event = SubmissionEmail.objects.create(
193+
submission_email_event = SubmissionEmailEvent.objects.create(
194194
submission = submission,
195195
desc = desc,
196196
msgtype = 'msgin',
@@ -258,7 +258,7 @@ def add_submission_email(request, remote_ip, name, rev, submission_pk, message,
258258
rs = "Sent"
259259

260260
desc = "{} message - manual post - {}-{}".format(rs, name, rev)
261-
submission_email_event = SubmissionEmail.objects.create(
261+
submission_email_event = SubmissionEmailEvent.objects.create(
262262
desc = desc,
263263
submission = submission,
264264
msgtype = msgtype,

ietf/submit/migrations/0011_submissionemail.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class Migration(migrations.Migration):
1313

1414
operations = [
1515
migrations.CreateModel(
16-
name='SubmissionEmail',
16+
name='SubmissionEmailEvent',
1717
fields=[
1818
('submissionevent_ptr', models.OneToOneField(parent_link=True, auto_created=True, primary_key=True, serialize=False, to='submit.SubmissionEvent')),
1919
('msgtype', models.CharField(max_length=25)),

ietf/submit/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ class Preapproval(models.Model):
108108
def __unicode__(self):
109109
return self.name
110110

111-
class SubmissionEmail(SubmissionEvent):
111+
class SubmissionEmailEvent(SubmissionEvent):
112112
message = models.ForeignKey(Message, null=True, blank=True,related_name='manualevents')
113113
msgtype = models.CharField(max_length=25)
114114
in_reply_to = models.ForeignKey(Message, null=True, blank=True,related_name='irtomanual')

ietf/submit/resources.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from ietf import api
88

99
from ietf.submit.models import Preapproval, \
10-
SubmissionCheck, Submission, SubmissionEmail, SubmissionEvent
10+
SubmissionCheck, Submission, SubmissionEmailEvent, SubmissionEvent
1111

1212

1313
from ietf.person.resources import PersonResource
@@ -105,17 +105,17 @@ class Meta:
105105

106106
from ietf.person.resources import PersonResource
107107
from ietf.message.resources import MessageResource
108-
class SubmissionEmailResource(ModelResource):
108+
class SubmissionEmailEventResource(ModelResource):
109109
submission = ToOneField(SubmissionResource, 'submission')
110110
by = ToOneField(PersonResource, 'by', null=True)
111111
submissionevent_ptr = ToOneField(SubmissionEventResource, 'submissionevent_ptr')
112112
message = ToOneField(MessageResource, 'message', null=True)
113113
in_reply_to = ToOneField(MessageResource, 'in_reply_to', null=True)
114114
class Meta:
115-
queryset = SubmissionEmail.objects.all()
115+
queryset = SubmissionEmailEvent.objects.all()
116116
serializer = api.Serializer()
117117
cache = SimpleCache()
118-
#resource_name = 'submissionemail'
118+
#resource_name = 'submissionemailevent'
119119
filtering = {
120120
"id": ALL,
121121
"time": ALL,
@@ -127,5 +127,5 @@ class Meta:
127127
"message": ALL_WITH_RELATIONS,
128128
"in_reply_to": ALL_WITH_RELATIONS,
129129
}
130-
api.submit.register(SubmissionEmailResource())
130+
api.submit.register(SubmissionEmailEventResource())
131131

ietf/submit/utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,9 @@ def post_rev00_submission_events(draft, submission, submitter):
153153
desc = "Request for posting approval emailed %s" % (subevent.desc[pos + 19:])
154154
elif desc.startswith("Received message") or desc.startswith("Sent message"):
155155
e = AddedMessageEvent(type="added_message", doc=draft)
156-
e.message = subevent.submissionemail.message
157-
e.msgtype = subevent.submissionemail.msgtype
158-
e.in_reply_to = subevent.submissionemail.in_reply_to
156+
e.message = subevent.submissionemailevent.message
157+
e.msgtype = subevent.submissionemailevent.msgtype
158+
e.in_reply_to = subevent.submissionemailevent.in_reply_to
159159
else:
160160
continue
161161

ietf/submit/views.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
send_submission_confirmation, send_manual_post_request, \
2828
add_submission_email, get_reply_to
2929
from ietf.submit.models import Submission, SubmissionCheck, Preapproval, DraftSubmissionStateName, \
30-
SubmissionEmail
30+
SubmissionEmailEvent
3131
from ietf.submit.utils import approvable_submissions_for_user, preapprovals_for_user, recently_approved_by_user
3232
from ietf.submit.utils import validate_submission, create_submission_event
3333
from ietf.submit.utils import docevent_from_submission
@@ -657,9 +657,9 @@ def add_manualpost_email(request, submission_id=None, access_token=None):
657657

658658
if (draft != None):
659659
e = AddedMessageEvent(type="added_message", doc=draft)
660-
e.message = submission_email_event.submissionemail.message
661-
e.msgtype = submission_email_event.submissionemail.msgtype
662-
e.in_reply_to = submission_email_event.submissionemail.in_reply_to
660+
e.message = submission_email_event.submissionemailevent.message
661+
e.msgtype = submission_email_event.submissionemailevent.msgtype
662+
e.in_reply_to = submission_email_event.submissionemailevent.in_reply_to
663663
e.by = request.user.person
664664
e.desc = submission_email_event.desc
665665
e.time = submission_email_event.time
@@ -727,7 +727,7 @@ def send_submission_email(request, submission_id, message_id=None):
727727
desc = "Sent message {} - manual post - {}-{}".format(rp,
728728
submission.name,
729729
submission.rev)
730-
SubmissionEmail.objects.create(
730+
SubmissionEmailEvent.objects.create(
731731
submission = submission,
732732
desc = desc,
733733
msgtype = 'msgout',
@@ -754,7 +754,7 @@ def send_submission_email(request, submission_id, message_id=None):
754754
subject = 'Regarding {}'.format(submission.name)
755755
else:
756756
try:
757-
submitEmail = SubmissionEmail.objects.get(id=message_id)
757+
submitEmail = SubmissionEmailEvent.objects.get(id=message_id)
758758
msg = submitEmail.message
759759

760760
if msg:
@@ -792,7 +792,7 @@ def send_submission_email(request, submission_id, message_id=None):
792792
def show_submission_email_message(request, submission_id, message_id, access_token=None):
793793
submission = get_submission_or_404(submission_id, access_token)
794794

795-
submitEmail = get_object_or_404(SubmissionEmail, pk=message_id)
795+
submitEmail = get_object_or_404(SubmissionEmailEvent, pk=message_id)
796796
attachments = submitEmail.message.messageattachment_set.all()
797797

798798
return render(request, 'submit/submission_email.html',
@@ -803,7 +803,7 @@ def show_submission_email_message(request, submission_id, message_id, access_tok
803803
def show_submission_email_attachment(request, submission_id, message_id, filename, access_token=None):
804804
get_submission_or_404(submission_id, access_token)
805805

806-
message = get_object_or_404(SubmissionEmail, pk=message_id)
806+
message = get_object_or_404(SubmissionEmailEvent, pk=message_id)
807807

808808
attach = get_object_or_404(MessageAttachment,
809809
message=message.message,

ietf/templates/submit/submission_status.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -349,15 +349,15 @@ <h2>History</h2>
349349
<td class="text-nowrap">{{ e.time|date:"Y-m-d" }}</td>
350350
<td>{{ e.by|default:"" }}</td>
351351
{% if e.desc|startswith:"Received message" or e.desc|startswith:"Sent message" %}
352-
{% with m=e.submissionemail.message %}
352+
{% with m=e.submissionemailevent.message %}
353353
{% if user.is_authenticated %}
354354
<td>
355355
{% if e.desc|startswith:"Received message" and user|has_role:"Secretariat" %}
356-
<a id="reply{{ submission.pk }}" class="btn btn-default btn-xs" href="{% url "ietf.submit.views.send_submission_email" submission_id=submission.pk message_id=e.submissionemail.pk %}" title="Reply"><span class="glyphicon glyphicon-envelope" aria-hidden="true"></span> Reply</a>
356+
<a id="reply{{ submission.pk }}" class="btn btn-default btn-xs" href="{% url "ietf.submit.views.send_submission_email" submission_id=submission.pk message_id=e.submissionemailevent.pk %}" title="Reply"><span class="glyphicon glyphicon-envelope" aria-hidden="true"></span> Reply</a>
357357
{% endif %}
358-
Email: <a id="aw{{ submission.pk }}-{{ m.pk }}" href="{% url "ietf.submit.views.show_submission_email_message" submission_id=submission.pk message_id=e.submissionemail.pk access_token=submission.access_token %}">{{ e.desc }}</a></td>
358+
Email: <a id="aw{{ submission.pk }}-{{ m.pk }}" href="{% url "ietf.submit.views.show_submission_email_message" submission_id=submission.pk message_id=e.submissionemailevent.pk access_token=submission.access_token %}">{{ e.desc }}</a></td>
359359
{% else %}
360-
<td>Email: <a id="aw{{ submission.pk }}-{{ m.pk }}" href="{% url "ietf.submit.views.show_submission_email_message" submission_id=submission.pk message_id=e.submissionemail.pk %}">{{ e.desc }}</a></td>
360+
<td>Email: <a id="aw{{ submission.pk }}-{{ m.pk }}" href="{% url "ietf.submit.views.show_submission_email_message" submission_id=submission.pk message_id=e.submissionemailevent.pk %}">{{ e.desc }}</a></td>
361361
{% endif %}
362362
{% endwith %}
363363
{% else %}

0 commit comments

Comments
 (0)