Skip to content

Commit d93bed3

Browse files
author
John P. rouillard
committed
issue #83 - Translate data-popup-title
1 parent e6c2dcc commit d93bed3

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

html/classhelper.js

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,10 @@ class ClassHelper extends HTMLElement {
293293
});
294294
}
295295

296+
if (classhelper.dataset.popupTitle) {
297+
keys.add(classhelper.dataset.popupTitle)
298+
}
299+
296300
const a = classhelper.querySelector("a");
297301
if (a && a.dataset.helpurl) {
298302
let searchParams = new URLSearchParams(a.dataset.helpurl.split("?")[1]);
@@ -986,11 +990,10 @@ class ClassHelper extends HTMLElement {
986990
let titleText;
987991

988992
if (this.dataset.popupTitle) {
989-
titleText = this.dataset.popupTitle;
990-
const hasItemDesignator = titleText.includes(CLASSHELPER_ATTRIBUTE_POPUP_TITLE_ITEM_DESIGNATOR_LOOKUP);
991-
if (hasItemDesignator) {
992-
titleText = titleText.replace(CLASSHELPER_ATTRIBUTE_POPUP_TITLE_ITEM_DESIGNATOR_LOOKUP, itemDesignator);
993-
}
993+
titleText = ClassHelper.translations[this.dataset.popupTitle];
994+
titleText = titleText.replace(
995+
CLASSHELPER_ATTRIBUTE_POPUP_TITLE_ITEM_DESIGNATOR_LOOKUP,
996+
itemDesignator);
994997
} else {
995998
titleText = `${itemDesignator} - Classhelper`;
996999
if (props.formProperty) {

0 commit comments

Comments
 (0)