applied patch provided, fixed broken test case 4,5 and 1 not performing assertions Issue #58

malvpatel · malvpatel · commit 45fee92ca002 · 2024-05-17T17:16:01.000-04:00
diff --git a/html/classhelper.css b/html/classhelper.css
@@ -61,7 +61,7 @@ table tr:hover {
     width: 7em;
 }
 
-.acc-apply {
+.popup-apply {
     font-weight: bold;
 }
 
diff --git a/html/classhelper.js b/html/classhelper.js
@@ -181,7 +181,7 @@ class ClassHelper extends HTMLElement {
         const handlePopupReadyEvent = (event) => {
             // we get a document Fragment in event.detail we replace it with the root
             // replaceChild method consumes the documentFragment content, subsequent calls will be no-op.
-            if (e.detail.childElementCount === 1) {
+            if (event.detail.childElementCount === 1) {
                 this.popupRef.document.replaceChild(event.detail, this.popupRef.document.documentElement);
             }
         }
diff --git a/test_classhelper.py b/test_classhelper.py

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ class ClassHelper extends HTMLElement {`
`181`	`181`	`const handlePopupReadyEvent = (event) => {`
`182`	`182`	`// we get a document Fragment in event.detail we replace it with the root`
`183`	`183`	`// replaceChild method consumes the documentFragment content, subsequent calls will be no-op.`
`184`		`- if (e.detail.childElementCount === 1) {`
	`184`	`+ if (event.detail.childElementCount === 1) {`
`185`	`185`	`this.popupRef.document.replaceChild(event.detail, this.popupRef.document.documentElement);`
`186`	`186`	`}`
`187`	`187`	`}`