Skip to content

Commit 23ca4e9

Browse files
committed
refactor: rename ambiguous class property dropdowns to dropdownsData
1 parent d146410 commit 23ca4e9

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

html/classhelper.js

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,12 @@ class ClassHelper extends HTMLElement {
9191
* for the parameters in data-search-with attribute of this web component
9292
* where a parameter is defined as a dropdown in
9393
* @type {Object.<string, Map.<string, string>>} */
94-
dropdowns = null;
94+
dropdownsData = null;
9595

9696
/** @type {HTMLAnchorElement} */
9797
helpurl = null;
98+
99+
/** @type {string} */
98100
helpurlScript = null;
99101

100102
/** @type {HelpUrlProps} */
@@ -141,7 +143,7 @@ class ClassHelper extends HTMLElement {
141143
console.error(error);
142144
});
143145

144-
this.fetchDropdowns()
146+
this.fetchDropdownsData()
145147
.catch(error => {
146148
// Top level handling for dropdowns errors.
147149
console.error(error);
@@ -240,7 +242,7 @@ class ClassHelper extends HTMLElement {
240242
if (!oldValue || oldValue === _newValue) {
241243
return;
242244
}
243-
this.fetchDropdowns().catch(error => {
245+
this.fetchDropdownsData().catch(error => {
244246
// Top level handling for dropdowns errors.
245247
console.error(error.message);
246248
});
@@ -287,12 +289,12 @@ class ClassHelper extends HTMLElement {
287289
}
288290
}
289291

290-
async fetchDropdowns() {
292+
async fetchDropdownsData() {
291293
// Singleton implementation
292-
if (this.dropdowns != null) {
294+
if (this.dropdownsData != null) {
293295
return;
294296
}
295-
this.dropdowns = {};
297+
this.dropdownsData = {};
296298

297299
if (this.dataset.searchWith == null) {
298300
return;
@@ -348,7 +350,7 @@ class ClassHelper extends HTMLElement {
348350
}
349351

350352
}
351-
this.dropdowns[param] = list;
353+
this.dropdownsData[param] = list;
352354
}
353355
}
354356
}
@@ -501,18 +503,18 @@ class ClassHelper extends HTMLElement {
501503
label.textContent = param + ":";
502504

503505
let input;
504-
if (this.dropdowns[param]) {
506+
if (this.dropdownsData[param]) {
505507
input = document.createElement("select");
506508

507509
let nullOption = document.createElement("option");
508510
nullOption.value = "";
509511
nullOption.textContent = "---";
510512
input.appendChild(nullOption);
511513

512-
for (let key of this.dropdowns[param].keys()) {
514+
for (let key of this.dropdownsData[param].keys()) {
513515
let option = document.createElement("option");
514516
option.value = key;
515-
option.textContent = this.dropdowns[param].get(key);
517+
option.textContent = this.dropdownsData[param].get(key);
516518
if (formData) {
517519
let value = formData.get(param);
518520
if (value && value == key) {

0 commit comments

Comments
 (0)