Skip to content

Commit 1b897b1

Browse files
author
John P. rouillard
committed
issue #86 - Does _generic.translation still need hardcoded "Apply", "Cancel" ... responses?
Confirmation from Malav is that these hardcoded strings are not needed. To create valid JSON, each term supplied by the user is prepended with a ',' separator. This works fine except that it needs a first key:value pair hardcoded in the output. So I replaced the multiple unused translation strings with a single identifying key:value.
1 parent 3c827ab commit 1b897b1

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

html/_generic.translation

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,7 @@
22
><tal:x tal:replace="python:request.client.additional_headers.update(
33
{'Content-Type':'application/vnd.roundup.translation+json'}
44
)"></tal:x>{
5-
"Apply": "<tal:x tal:replace="python:i18n.gettext('Apply')" />",
6-
"Cancel": "<tal:x tal:replace="python:i18n.gettext('Cancel')" />",
7-
"Next": "<tal:x tal:replace="python:i18n.gettext('Next')" />",
8-
"Prev": "<tal:x tal:replace="python:i18n.gettext('Prev')" />",
9-
"Search": "<tal:x tal:replace="python:i18n.gettext('Search')" />",
10-
"Reset": "<tal:x tal:replace="python:i18n.gettext('Reset')" />"<tal:block
5+
"RoundupTranslations": "RoundupTranslations"<tal:block
116
tal:condition="request/form/properties/value | false"
127
><tal:loop tal:repeat="field
138
python:request.form['properties'].value.split(',')"

0 commit comments

Comments
 (0)