Skip to content

Commit edff468

Browse files
authored
Bug: fix packet loss rounding in notifications (alexjustesen#2670)
1 parent d5ebe7c commit edff468

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

app/Listeners/ProcessCompletedSpeedtest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ private function notifyAppriseChannels(Result $result): void
7272
'ping' => round($result->ping).' ms',
7373
'download' => Number::toBitRate(bits: $result->download_bits, precision: 2),
7474
'upload' => Number::toBitRate(bits: $result->upload_bits, precision: 2),
75-
'packetLoss' => $result->packet_loss,
75+
'packetLoss' => $result->packet_loss ? round($result->packet_loss, precision: 2) : '',
7676
'speedtest_url' => $result->result_url,
7777
'url' => url('/admin/results'),
7878
])->render();

app/Mail/CompletedSpeedtestMail.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function content(): Content
5151
'ping' => round($this->result->ping, 2).' ms',
5252
'download' => Number::toBitRate(bits: $this->result->download_bits, precision: 2),
5353
'upload' => Number::toBitRate(bits: $this->result->upload_bits, precision: 2),
54-
'packetLoss' => is_numeric($this->result->packet_loss) ? $this->result->packet_loss : 'n/a',
54+
'packetLoss' => $result->packet_loss ? round($result->packet_loss, precision: 2) : '',
5555
'speedtest_url' => $this->result->result_url,
5656
'url' => url('/admin/results'),
5757
],

resources/views/apprise/speedtest-completed.blade.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66
- **Ping:** {{ $ping }}
77
- **Download:** {{ $download }}
88
- **Upload:** {{ $upload }}
9+
@filled($packetLoss)
910
- **Packet Loss:** {{ $packetLoss }}%
11+
@endfilled
1012

1113
### Links
1214
- [View Ookla Results]({{ $speedtest_url }})

resources/views/mail/speedtest/completed.blade.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212
| Ping | {{ $ping }} |
1313
| Download | {{ $download }} |
1414
| Upload | {{ $upload }} |
15+
@filled($packetLoss)
1516
| Packet Loss | {{ $packetLoss }} **%** |
17+
@endfilled
1618

1719

1820
</x-mail::table>

0 commit comments

Comments
 (0)