Skip to content

Commit d595aac

Browse files
fix: Skip title validation if only XML uploaded (ietf-tools#5694)
1 parent 0a11892 commit d595aac

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

ietf/submit/utils.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1265,7 +1265,11 @@ def process_and_validate_submission(submission):
12651265
# Parse text, whether uploaded or generated from XML
12661266
text_metadata = process_submission_text(submission.name, submission.rev)
12671267

1268-
if xml_metadata and xml_metadata["title"] != text_metadata["title"]:
1268+
if (
1269+
".txt" in submission.file_types
1270+
and xml_metadata
1271+
and xml_metadata["title"] != text_metadata["title"]
1272+
):
12691273
raise SubmissionError(
12701274
f"Text Internet-Draft title ({text_metadata['title']}) "
12711275
f"disagrees with XML Internet-Draft title ({xml_metadata['title']})"
@@ -1275,13 +1279,14 @@ def process_and_validate_submission(submission):
12751279
if xml_metadata is not None:
12761280
# Items preferred / only available from XML
12771281
submission.xml_version = xml_metadata["xml_version"]
1282+
submission.title = xml_metadata["title"]
12781283
submission.authors = xml_metadata["authors"]
12791284
else:
12801285
# Items to get from text only if XML not available
1286+
submission.title = text_metadata["title"]
12811287
submission.authors = text_metadata["authors"]
12821288

12831289
# Items always to get from text, even when XML is available
1284-
submission.title = text_metadata["title"] # verified above this agrees with XML, if present
12851290
submission.abstract = text_metadata["abstract"]
12861291
submission.document_date = text_metadata["document_date"]
12871292
submission.pages = text_metadata["pages"]

0 commit comments

Comments
 (0)