Skip to content

Commit bbb5b9c

Browse files
committed
Merged in [18064] from rjsparks@nostrum.com:
Change group edit field url regexp to accept the field names (specifically role names) we use by allowing hyphens. - Legacy-Id: 18072 Note: SVN reference [18064] has been migrated to Git commit db0f902
2 parents 8c90c53 + db0f902 commit bbb5b9c

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

ietf/group/urls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
url(r'^deps/(?P<output_type>[\w-]+)/$', views.dependencies),
3030
url(r'^meetings/$', views.meetings),
3131
url(r'^edit/$', views.edit, {'action': "edit"}),
32-
url(r'^edit/(?P<field>\w+)/?$', views.edit, {'action': "edit"}),
32+
url(r'^edit/(?P<field>[-a-z0-9_]+)/?$', views.edit, {'action': "edit"}),
3333
url(r'^conclude/$', views.conclude),
3434
url(r'^milestones/$', milestone_views.edit_milestones, {'milestone_set': "current"}, name='ietf.group.milestones.edit_milestones;current'),
3535
url(r'^milestones/charter/$', milestone_views.edit_milestones, {'milestone_set': "charter"}, name='ietf.group.milestones.edit_milestones;charter'),

ietf/settings.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -626,6 +626,8 @@ def skip_unreadable_post(record):
626626
DATE_FORMAT = "Y-m-d"
627627
DATETIME_FORMAT = "Y-m-d H:i T"
628628

629+
# Add reusable URL regexps here, for consistency. No need to do so if the
630+
# regex can reasonably be expected to be a unique one-off.
629631
URL_REGEXPS = {
630632
"acronym": r"(?P<acronym>[-a-z0-9]+)",
631633
"charter": r"(?P<name>charter-[-a-z0-9]+)",

0 commit comments

Comments
 (0)