Skip to content

Commit b8febcb

Browse files
committed
test: adjusted fuzzy_find_document_rfc test
1 parent 0b9d450 commit b8febcb

1 file changed

Lines changed: 20 additions & 18 deletions

File tree

ietf/doc/tests_utils.py

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from ietf.group.factories import GroupFactory, RoleFactory
1212
from ietf.name.models import DocTagName
1313
from ietf.person.factories import PersonFactory
14-
from ietf.utils.test_utils import TestCase, name_of_file_containing
14+
from ietf.utils.test_utils import TestCase, name_of_file_containing, reload_db_objects
1515
from ietf.person.models import Person
1616
from ietf.doc.factories import DocumentFactory, WgRfcFactory, WgDraftFactory
1717
from ietf.doc.models import State, DocumentActionHolder, DocumentAuthor, Document
@@ -251,40 +251,42 @@ def test_update_documentauthors_with_nulls(self):
251251
self.assertEqual(docauth.country, '')
252252

253253
def do_fuzzy_find_documents_rfc_test(self, name):
254-
rfc = WgRfcFactory(name=name, create_revisions=(0, 1, 2))
255-
rfc = Document.objects.get(pk=rfc.pk) # clear out any cached values
254+
draft = WgDraftFactory(name=name, create_revisions=(0, 1, 2))
255+
rfc = WgRfcFactory()
256+
draft.relateddocument_set.create(relationship_id="became_rfc", target=rfc.docalias.first())
257+
draft, rfc = reload_db_objects(draft, rfc)
256258

257259
# by canonical name
258-
found = fuzzy_find_documents(rfc.canonical_name(), None)
260+
found = fuzzy_find_documents(rfc.name, None)
259261
self.assertCountEqual(found.documents, [rfc])
260262
self.assertEqual(found.matched_rev, None)
261-
self.assertEqual(found.matched_name, rfc.canonical_name())
263+
self.assertEqual(found.matched_name, rfc.name)
262264

263265
# by draft name, no rev
264-
found = fuzzy_find_documents(rfc.name, None)
265-
self.assertCountEqual(found.documents, [rfc])
266+
found = fuzzy_find_documents(draft.name, None)
267+
self.assertCountEqual(found.documents, [draft])
266268
self.assertEqual(found.matched_rev, None)
267-
self.assertEqual(found.matched_name, rfc.name)
269+
self.assertEqual(found.matched_name, draft.name)
268270

269271
# by draft name, latest rev
270-
found = fuzzy_find_documents(rfc.name, '02')
271-
self.assertCountEqual(found.documents, [rfc])
272+
found = fuzzy_find_documents(draft.name, '02')
273+
self.assertCountEqual(found.documents, [draft])
272274
self.assertEqual(found.matched_rev, '02')
273-
self.assertEqual(found.matched_name, rfc.name)
275+
self.assertEqual(found.matched_name, draft.name)
274276

275277
# by draft name, earlier rev
276-
found = fuzzy_find_documents(rfc.name, '01')
277-
self.assertCountEqual(found.documents, [rfc])
278+
found = fuzzy_find_documents(draft.name, '01')
279+
self.assertCountEqual(found.documents, [draft])
278280
self.assertEqual(found.matched_rev, '01')
279-
self.assertEqual(found.matched_name, rfc.name)
281+
self.assertEqual(found.matched_name, draft.name)
280282

281283
# wrong name or revision
282-
found = fuzzy_find_documents(rfc.name + '-incorrect')
284+
found = fuzzy_find_documents(draft.name + '-incorrect')
283285
self.assertCountEqual(found.documents, [], 'Should not find document that does not match')
284-
found = fuzzy_find_documents(rfc.name + '-incorrect', '02')
286+
found = fuzzy_find_documents(draft.name + '-incorrect', '02')
285287
self.assertCountEqual(found.documents, [], 'Still should not find document, even with a version')
286-
found = fuzzy_find_documents(rfc.name, '22')
287-
self.assertCountEqual(found.documents, [rfc],
288+
found = fuzzy_find_documents(draft.name, '22')
289+
self.assertCountEqual(found.documents, [draft],
288290
'Should find document even if rev does not exist')
289291

290292

0 commit comments

Comments
 (0)