Skip to content

Commit 495df36

Browse files
authored
chore: Make newer bibtexparser versions work with the tests (ietf-tools#4205)
* chore: Make newer bibtexparser versions work with the tests * Fix test
1 parent 57818a0 commit 495df36

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

ietf/doc/tests.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1828,7 +1828,7 @@ def test_document_nonietf_pubreq_button(self):
18281828
self.assertNotContains(r, "Request publication")
18291829

18301830
def _parse_bibtex_response(self, response) -> dict:
1831-
parser = bibtexparser.bparser.BibTexParser()
1831+
parser = bibtexparser.bparser.BibTexParser(common_strings=True)
18321832
parser.homogenise_fields = False # do not modify field names (e.g., turns "url" into "link" by default)
18331833
return bibtexparser.loads(response.content.decode(), parser=parser).get_entry_dict()
18341834

@@ -1850,7 +1850,7 @@ def test_document_bibtex(self):
18501850
self.assertEqual(entry['number'], num)
18511851
self.assertEqual(entry['doi'], '10.17487/RFC%s'%num)
18521852
self.assertEqual(entry['year'], '2010')
1853-
self.assertEqual(entry['month'], 'oct')
1853+
self.assertEqual(entry['month'].lower()[0:3], 'oct')
18541854
self.assertEqual(entry['url'], f'https://www.rfc-editor.ietf.org/info/rfc{num}')
18551855
#
18561856
self.assertNotIn('day', entry)
@@ -1872,7 +1872,7 @@ def test_document_bibtex(self):
18721872
self.assertEqual(entry['number'], num)
18731873
self.assertEqual(entry['doi'], '10.17487/RFC%s'%num)
18741874
self.assertEqual(entry['year'], '1990')
1875-
self.assertEqual(entry['month'], 'apr')
1875+
self.assertEqual(entry['month'].lower()[0:3], 'apr')
18761876
self.assertEqual(entry['day'], '1')
18771877
self.assertEqual(entry['url'], f'https://www.rfc-editor.ietf.org/info/rfc{num}')
18781878

@@ -1885,7 +1885,7 @@ def test_document_bibtex(self):
18851885
self.assertEqual(entry['note'], 'Work in Progress')
18861886
self.assertEqual(entry['number'], docname)
18871887
self.assertEqual(entry['year'], str(draft.pub_date().year))
1888-
self.assertEqual(entry['month'], draft.pub_date().strftime('%b').lower())
1888+
self.assertEqual(entry['month'].lower()[0:3], draft.pub_date().strftime('%b').lower())
18891889
self.assertEqual(entry['day'], str(draft.pub_date().day))
18901890
self.assertEqual(entry['url'], settings.IDTRACKER_BASE_URL + urlreverse("ietf.doc.views_doc.document_main", kwargs=dict(name=draft.name, rev=draft.rev)))
18911891
#

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ setuptools>=51.1.0 # Require this first, to prevent later errors
33
#
44
argon2-cffi>=21.3.0 # For the Argon2 password hasher option
55
beautifulsoup4>=4.11.1 # Only used in tests
6-
bibtexparser>=0.6.2,<1.0 # Only used in tests. Version 1.0 doesn't work under python 2.7. 1.0.1 doesn't recognize month names or abbreviations.
6+
bibtexparser>=1.2.0 # Only used in tests
77
bleach>=5.0.0
88
coverage>=4.5.4,<5.0 # Coverage 5.x moves from a json database to SQLite. Moving to 5.x will require substantial rewrites in ietf.utils.test_runner and ietf.release.views
99
decorator>=5.1.1

0 commit comments

Comments
 (0)