Skip to content

Commit 48cb06d

Browse files
committed
fix: subseries specific docevent types. get_or_create contain relationship. remove spurious "
1 parent 0390f18 commit 48cb06d

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

ietf/sync/rfceditor.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -680,9 +680,9 @@ def parse_relation_list(l):
680680
if created:
681681
if first_sync_creating_subseries:
682682
subseries_doc.docevent_set.create(type=f"{subseries_slug}_history_marker", by=system, desc=f"No history of this {subseries_slug.upper()} document is currently available in the datatracker before this point")
683-
subseries_doc.docevent_set.create(type="subseries_doc_created", by=system, desc=f"Created {subseries_doc_name} via sync to the rfc-index")
684-
if not subseries_doc.relateddocument_set.filter(relationship_id="contains", target=doc).exists():
685-
subseries_doc.relateddocument_set.create(relationship_id="contains", target=doc)
683+
subseries_doc.docevent_set.create(type=f"{subseries_slug}_doc_created", by=system, desc=f"Created {subseries_doc_name} via sync to the rfc-index")
684+
_, relationship_created = subseries_doc.relateddocument_set.get_or_create(relationship_id="contains", target=doc)
685+
if relationship_created:
686686
subseries_doc.docevent_set.create(type="sync_from_rfc_editor", by=system, desc=f"Added {doc.name} to {subseries_doc.name}")
687687
if first_sync_creating_subseries:
688688
rfc_events.append(doc.docevent_set.create(type=f"{subseries_slug}_history_marker", by=system, desc=f"No history of {subseries_doc.name.upper()} is currently available in the datatracker before this point"))

ietf/templates/doc/index_subseries.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ <h1>{{type.name}}s</h1>
1111
<div class="card-header"><a href="{% url 'ietf.doc.views_doc.document_main' name=doc.name %}">{{doc.name}}</a></div>
1212
<div class="card-body">
1313
{% for rfc in doc.contains %}
14-
<p><a href="{% url 'ietf.doc.views_doc.document_main' name=rfc.name %}"">{{rfc.name}}</a> : {{rfc.title}}</p>
14+
<p><a href="{% url 'ietf.doc.views_doc.document_main' name=rfc.name %}">{{rfc.name}}</a> : {{rfc.title}}</p>
1515
{% endfor %}
1616
</div>
1717
</div>

0 commit comments

Comments
 (0)