Skip to content

Commit 13ae073

Browse files
authored
fix: test web manifest (ietf-tools#4047)
1 parent 02942a6 commit 13ae073

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

ietf/urls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
url(r'^googlea30ad1dacffb5e5b.html', TemplateView.as_view(template_name='googlea30ad1dacffb5e5b.html')),
7777

7878
# Android webmanifest
79-
url(r'^site.webmanifest', TemplateView.as_view(template_name='site.webmanifest')),
79+
url(r'^site.webmanifest', TemplateView.as_view(template_name='site.webmanifest'), name='site.webmanifest'),
8080
]
8181

8282
# This is needed to serve files during testing

ietf/utils/tests.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44

55
import io
6+
import json
67
import os.path
78
import shutil
89
import types
@@ -36,7 +37,7 @@
3637
from ietf.utils.log import unreachable, assertion
3738
from ietf.utils.mail import send_mail_preformatted, send_mail_text, send_mail_mime, outbox, get_payload_text
3839
from ietf.utils.test_runner import get_template_paths, set_coverage_checking
39-
from ietf.utils.test_utils import TestCase
40+
from ietf.utils.test_utils import TestCase, unicontent
4041
from ietf.utils.text import parse_unicode
4142
from ietf.utils.xmldraft import XMLDraft
4243

@@ -466,4 +467,12 @@ def test_parse_unicode(self):
466467
('', ''),
467468
)
468469
for encoded_str, unicode in names:
469-
self.assertEqual(unicode, parse_unicode(encoded_str))
470+
self.assertEqual(unicode, parse_unicode(encoded_str))
471+
472+
class TestAndroidSiteManifest(TestCase):
473+
def test_manifest(self):
474+
r = self.client.get(urlreverse('site.webmanifest'))
475+
self.assertEqual(r.status_code, 200)
476+
manifest = json.loads(unicontent(r))
477+
self.assertTrue('name' in manifest)
478+
self.assertTrue('theme_color' in manifest)

0 commit comments

Comments
 (0)