Skip to content

Commit cfa0d47

Browse files
committed
Port to new class-based generic redirect and simple template views, remove utils.lazy.reverse_lazy, it's now included in Django
- Legacy-Id: 6878
1 parent 7a86afe commit cfa0d47

42 files changed

Lines changed: 145 additions & 174 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

ietf/community/urls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from django.conf.urls.defaults import patterns, url
1+
from django.conf.urls import patterns, url
22

33

44
urlpatterns = patterns('ietf.community.views',

ietf/cookies/urls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Copyright The IETF Trust 2010, All Rights Reserved
22

3-
from django.conf.urls.defaults import patterns
3+
from django.conf.urls import patterns
44
from ietf.cookies import views
55

66
urlpatterns = patterns('',

ietf/dbtemplate/urls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from django.conf.urls.defaults import patterns, url
1+
from django.conf.urls import patterns, url
22

33

44
urlpatterns = patterns('ietf.dbtemplate.views',

ietf/doc/redirect_drafts_urls.py

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,21 @@
11
# Copyright The IETF Trust 2007, All Rights Reserved
22

3-
from django.conf import settings
4-
from django.conf.urls.defaults import patterns
5-
6-
3+
from django.conf.urls import patterns
4+
from django.views.generic import RedirectView
75
from django.http import HttpResponsePermanentRedirect
86
from django.shortcuts import get_object_or_404
97

108
from ietf.group.models import Group
119

1210
urlpatterns = patterns('',
13-
(r'^$', 'django.views.generic.simple.redirect_to', { 'url': '/doc/'}),
14-
(r'^all/$', 'django.views.generic.simple.redirect_to', { 'url': '/doc/all/'}),
15-
(r'^rfc/$', 'django.views.generic.simple.redirect_to', { 'url': '/doc/all/#rfc'}),
16-
(r'^dead/$', 'django.views.generic.simple.redirect_to', { 'url': '/doc/all/#expired'}),
17-
(r'^current/$', 'django.views.generic.simple.redirect_to', { 'url': '/doc/active/'}),
18-
(r'^(?P<object_id>\d+)/(related/)?$', 'django.views.generic.simple.redirect_to', { 'url': '/doc/' }),
19-
(r'^(?P<name>[^/]+)/(related/)?$', 'django.views.generic.simple.redirect_to', { 'url': '/doc/%(name)s/' }),
11+
(r'^$', RedirectView.as_view(url='/doc/')),
12+
(r'^all/$', RedirectView.as_view(url='/doc/all/')),
13+
(r'^rfc/$', RedirectView.as_view(url='/doc/all/#rfc')),
14+
(r'^dead/$', RedirectView.as_view(url='/doc/all/#expired')),
15+
(r'^current/$', RedirectView.as_view(url='/doc/active/')),
16+
(r'^(?P<object_id>\d+)/(related/)?$', RedirectView.as_view(url='/doc/')),
17+
(r'^(?P<name>[^/]+)/(related/)?$', RedirectView.as_view(url='/doc/%(name)s/')),
2018
(r'^wgid/(?P<id>\d+)/$', lambda request, id: HttpResponsePermanentRedirect("/wg/%s/" % get_object_or_404(Group, id=id).acronym)),
21-
(r'^wg/(?P<acronym>[^/]+)/$', 'django.views.generic.simple.redirect_to', { 'url': '/wg/%(acronym)s/' }),
22-
(r'^all_id(?:_txt)?.html$', 'django.views.generic.simple.redirect_to', { 'url': 'http://www.ietf.org/id/all_id.txt' }),
19+
(r'^wg/(?P<acronym>[^/]+)/$', RedirectView.as_view(url='/wg/%(acronym)s/')),
20+
(r'^all_id(?:_txt)?.html$', RedirectView.as_view(url='http://www.ietf.org/id/all_id.txt')),
2321
)
Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
from django.conf.urls.defaults import patterns, url
2-
from django.views.generic.simple import redirect_to
1+
from django.conf.urls import patterns, url
2+
from django.views.generic import RedirectView
33

44
urlpatterns = patterns('',
5-
(r'^help/(?:sub)?state/(?:\d+/)?$', redirect_to, {'url': '/doc/help/state/draft-iesg/' }),
6-
(r'^help/evaluation/$', redirect_to, {'url':'http://www.ietf.org/iesg/voting-procedures.html' }),
7-
(r'^status/$', redirect_to, {'url':'/doc/iesg/' }),
8-
(r'^status/last-call/$', redirect_to, {'url':'/doc/iesg/last-call/' }),
9-
(r'^rfc0*(?P<rfc_number>\d+)/$', redirect_to, {'url':'/doc/rfc%(rfc_number)s/' }),
10-
(r'^(?P<name>[^/]+)/$', redirect_to, {'url':'/doc/%(name)s/' }),
11-
(r'^(?P<name>[^/]+)/comment/\d+/$', redirect_to, {'url':'/doc/%(name)s/history/' }),
12-
(r'^$', redirect_to, { 'url': '/doc/'}),
5+
(r'^help/(?:sub)?state/(?:\d+/)?$', RedirectView.as_view(rl='/doc/help/state/draft-iesg/')),
6+
(r'^help/evaluation/$', RedirectView.as_view(url='http://www.ietf.org/iesg/voting-procedures.html')),
7+
(r'^status/$', RedirectView.as_view(url='/doc/iesg/')),
8+
(r'^status/last-call/$', RedirectView.as_view(url='/doc/iesg/last-call/')),
9+
(r'^rfc0*(?P<rfc_number>\d+)/$', RedirectView.as_view(url='/doc/rfc%(rfc_number)s/')),
10+
(r'^(?P<name>[^/]+)/$', RedirectView.as_view(url='/doc/%(name)s/')),
11+
(r'^(?P<name>[^/]+)/comment/\d+/$', RedirectView.as_view(url='/doc/%(name)s/history/')),
12+
(r'^$', RedirectView.as_view(url='/doc/')),
1313
)

ietf/doc/urls.py

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@
3030
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
3131
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
3232

33-
from django.conf.urls.defaults import patterns, url, include
34-
from django.shortcuts import redirect
33+
from django.conf.urls import patterns, url, include
34+
from django.views.generic import RedirectView
35+
3536
from ietf.doc.models import State
3637
from ietf.doc import views_search, views_draft, views_ballot
3738
from ietf.doc import views_status_change
@@ -42,14 +43,8 @@
4243
url(r'^search/$', views_search.search, name="doc_search"),
4344
url(r'^in-last-call/$', views_search.drafts_in_last_call, name="drafts_in_last_call"),
4445
url(r'^ad/(?P<name>[A-Za-z0-9.-]+)/$', views_search.docs_for_ad, name="docs_for_ad"),
45-
)
46-
47-
urlpatterns += patterns('django.views.generic.simple',
48-
(r'^ad2/(?P<name>[A-Za-z0-9.-]+)/$', 'redirect_to', {'url': '/doc/ad/%(name)s/', 'permanent': True}),
49-
)
50-
51-
urlpatterns += patterns('',
52-
url(r'^rfc-status-changes/$', views_status_change.rfc_status_changes, name='rfc_status_changes'),
46+
(r'^ad2/(?P<name>[A-Za-z0-9.-]+)/$', RedirectView.as_view(url='/doc/ad/%(name)s/', permanent=True)),
47+
url(r'^rfc-status-changes/$', views_status_change.rfc_status_changes, name='rfc_status_changes'),
5348
url(r'^start-rfc-status-change/(?P<name>[A-Za-z0-9._+-]*)$', views_status_change.start_rfc_status_change, name='start_rfc_status_change'),
5449
url(r'^iesg/(?P<last_call_only>[A-Za-z0-9.-]+/)?$', views_search.drafts_in_iesg_process, name="drafts_in_iesg_process"),
5550

ietf/doc/urls_conflict_review.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from django.conf.urls.defaults import patterns, url
1+
from django.conf.urls import patterns, url
22

33
urlpatterns = patterns('ietf.doc.views_conflict_review',
44
url(r'^state/$', "change_state", name='conflict_review_change_state'),

ietf/doc/urls_status_change.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from django.conf.urls.defaults import patterns, url
1+
from django.conf.urls import patterns, url
22

33
urlpatterns = patterns('ietf.doc.views_status_change',
44
url(r'^state/$', "change_state", name='status_change_change_state'),

ietf/group/admin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def role_list(self, obj):
4242

4343
# SDO reminder
4444
def get_urls(self):
45-
from django.conf.urls.defaults import patterns, url
45+
from django.conf.urls import patterns, url
4646

4747
def wrap(view):
4848
def wrapper(*args, **kwargs):

ietf/group/stream_urls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Copyright The IETF Trust 2008, All Rights Reserved
22

3-
from django.conf.urls.defaults import patterns, include
3+
from django.conf.urls import patterns, include
44

55
import views_stream
66

0 commit comments

Comments
 (0)