Skip to content

Commit 8ef9231

Browse files
authored
fix: Don't urlencode all resource URLs (ietf-tools#3988)
While this does suppress errors, it breaks even valid URLs. Instead, just suppress the validation error for those few cases in the database.
1 parent 820b70a commit 8ef9231

4 files changed

Lines changed: 4 additions & 3 deletions

File tree

ietf/templates/doc/document_bofreq.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@
107107
{% if resources %}
108108
{% for resource in resources|dictsort:"display_name" %}
109109
{% if resource.name.type.slug == 'url' or resource.name.type.slug == 'email' %}
110-
<a href="{{ resource.value|urlencode }}" title="{{ resource.name.name }}">
110+
<a href="{{ resource.value }}" title="{{ resource.name.name }}">
111111
{% firstof resource.display_name resource.name.name %}
112112
</a>
113113
<br>

ietf/templates/doc/document_draft.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@
366366
{% if resources or doc.group and doc.group.list_archive %}
367367
{% for resource in resources|dictsort:"display_name" %}
368368
{% if resource.name.type.slug == 'url' or resource.name.type.slug == 'email' %}
369-
<a href="{{ resource.value|urlencode }}" title="{{ resource.name.name }}">
369+
<a href="{{ resource.value }}" title="{{ resource.name.name }}">
370370
{% firstof resource.display_name resource.name.name %}
371371
</a>
372372
<br>

ietf/templates/group/group_about.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@
150150
{% for resource in resources|dictsort:"display_name" %}
151151
{# Maybe make how a resource displays itself a method on the class so templates aren't doing this switching #}
152152
{% if resource.name.type.slug == 'url' or resource.name.type.slug == 'email' %}
153-
<a href="{{ resource.value|urlencode }}" title="{{ resource.name.name }}">
153+
<a href="{{ resource.value }}" title="{{ resource.name.name }}">
154154
{% firstof resource.display_name resource.name.name %}</a>{% else %}
155155
<span title="{{ resource.name.name }}">
156156
{% firstof resource.display_name resource.name.name %}: {{ resource.value|escape }}

ietf/utils/test_runner.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ def vnu_filter_message(msg, filter_db_issues, filter_test_issues):
177177
"True if the vnu message is a known false positive"
178178
if filter_db_issues and re.search(
179179
r"""^Forbidden\ code\ point\ U\+|
180+
Illegal\ character\ in\ query:\ '\['|
180181
'href'\ on\ element\ 'a':\ Percentage\ \("%"\)\ is\ not\ followed|
181182
^Saw\ U\+\d+\ in\ stream|
182183
^Document\ uses\ the\ Unicode\ Private\ Use\ Area""",

0 commit comments

Comments
 (0)