Skip to content

Commit 56acd00

Browse files
committed
Changed format of the reviewer statistics in lists. Fixes ietf-tools#2131. Commit ready for merge.
- Legacy-Id: 15701
1 parent 542a85d commit 56acd00

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

ietf/doc/tests_review.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ def test_assign_reviewer(self):
355355
self.assertIn("unavailable indefinitely", reviewer_label)
356356
self.assertIn("skip next 1", reviewer_label)
357357
self.assertIn("#1", reviewer_label)
358-
self.assertIn("no response 0/1", reviewer_label)
358+
self.assertIn("1 completed", reviewer_label)
359359

360360
# assign
361361
empty_outbox()

ietf/review/utils.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -833,7 +833,10 @@ def format_period(p):
833833
could_have_completed = [d for d in req_data if d.state in ["part-completed", "completed", "no-response"]]
834834
if could_have_completed:
835835
no_response = sum(1 for d in could_have_completed if d.state == "no-response")
836-
stats.append("no response {}/{}".format(no_response, len(could_have_completed)))
836+
if no_response > 0:
837+
stats.append("{} no response, {} completed".format(no_response, len(could_have_completed) - no_response))
838+
else:
839+
stats.append("{} completed".format(len(could_have_completed)))
837840

838841
if stats:
839842
explanations.append(", ".join(stats))

0 commit comments

Comments
 (0)