fix(ui): import moment.js library with moment-timezone support in wrapper (ietf-tools#3977)

* fix: import moment.js library with moment-timezone support in wrapper

Packaging changes broke the mechanism used to make moment.tz available
to javascript code. This eliminates the separate moment.js and
moment-timezone-with-data-10-year-range.js wrappers and instead
imports the timezone-augmented version directly. This provides both
the timezone support and the regular moment features.

* refactor: put moment on window instead of global for consistency

Author: jennifer-richards

ietf/static/js/moment-timezone-with-data-10-year-range.js

@@ -1,3 +1,5 @@
-const moment = require("moment");
-
-global.moment = moment;
+/* Add the moment object to the global scope - needed until inline scripts using
+ * Moment.js are eliminated. When that happens, can import moment in the js files
+ * that need it. */
+import moment from "moment-timezone/builds/moment-timezone-with-data-10-year-range";
+window.moment = moment;

ietf/static/js/moment.js

@@ -10,6 +10,7 @@
  */
 (function () {
     'use strict';
+
     // Callback for timezone change - called after current_timezone is updated
     let timezone_change_callback;
     let current_timezone;

ietf/static/js/timezone.js

@@ -428,8 +428,6 @@ <h2 class="mt-3">
     </script>
     <script src="{% static 'ietf/js/moment.js' %}">
     </script>
-    <script src="{% static 'ietf/js/moment-timezone-with-data-10-year-range.js' %}">
-    </script>
     <script src="{% static 'ietf/js/timezone.js' %}">
     </script>
     <script src="{% static 'ietf/js/agenda_materials.js' %}">

ietf/templates/meeting/agenda.html

@@ -25,7 +25,6 @@
 {% block title %}{{ schedule.name }}: IETF {{ meeting.number }} meeting agenda{% endblock %}
 {% block js %}
         <script src="{% static 'ietf/js/moment.js' %}"></script>
-        <script src="{% static 'ietf/js/moment-timezone-with-data-10-year-range.js' %}"></script>
         <script src="{% static 'ietf/js/edit-meeting-schedule.js' %}"></script>
     {% endblock %}
     {% block content %}

ietf/templates/meeting/edit_meeting_schedule.html

@@ -112,7 +112,6 @@ <h3 class="my-3">No upcoming meetings</h3>
     <script src="{% static 'ietf/js/list.js' %}"></script>
     <script src="{% static 'ietf/js/fullcalendar.js' %}"></script>
     <script src="{% static 'ietf/js/moment.js' %}"></script>
-    <script src="{% static 'ietf/js/moment-timezone-with-data-10-year-range.js' %}"></script>
     <script src="{% static 'ietf/js/agenda_filter.js' %}"></script>
     <script src="{% static 'ietf/js/agenda_materials.js' %}"></script>
     <script src="{% static 'ietf/js/timezone.js' %}"></script>

ietf/templates/meeting/upcoming.html

@@ -12,7 +12,6 @@
         <meta name="viewport" content="width=device-width, initial-scale=1">
         <script src="{% static 'ietf/js/agenda_filter.js' %}"></script>
         <script src="{% static 'ietf/js/moment.js' %}"></script>
-        <script src="{% static 'ietf/js/moment-timezone-with-data-10-year-range.js' %}"></script>
         <script src="{% static 'ietf/js/week-view.js' %}"></script>
         <script>
         var all_items = {{ items | safe }};

ietf/templates/meeting/week-view.html

@@ -87,7 +87,6 @@
         "ietf/static/js/manage-community-list.js",
         "ietf/static/js/manage-review-requests.js",
         "ietf/static/js/meeting-interim-request.js",
-        "ietf/static/js/moment-timezone-with-data-10-year-range.js",
         "ietf/static/js/moment.js",
         "ietf/static/js/password_strength.js",
         "ietf/static/js/review-stats.js",