Skip to content

Commit 3f3ae20

Browse files
committed
Apply fix to missing nomcom chair in [4384] instead of [4385].
- Legacy-Id: 4389 Note: SVN reference [4385] has been migrated to Git commit c3ad0b5
1 parent 2eb0ab5 commit 3f3ae20

1 file changed

Lines changed: 11 additions & 13 deletions

File tree

ietf/announcements/views.py

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
from django.shortcuts import get_object_or_404
55
from django.conf import settings
66
from django.db.models import Q
7-
from django.core.exceptions import ObjectDoesNotExist
87

98
import re
109

@@ -52,18 +51,17 @@ def nomcomREDESIGN(request):
5251
e = GroupEvent.objects.filter(group=n, type="changed_state", changestategroupevent__state="conclude").order_by('time')[:1]
5352
n.end_year = e[0].time.year if e else ""
5453

55-
# A nomcom chair may not exist even if the nomcom NN group has been created:
56-
try:
57-
chair = n.role_set.select_related().get(name="chair")
58-
announcements = Message.objects.filter(related_groups=n).order_by('-time')
59-
for a in announcements:
60-
a.to_name = address_re.sub("", a.to)
61-
62-
regimes.append(dict(chair=chair,
63-
announcements=announcements,
64-
group=n))
65-
except ObjectDoesNotExist:
66-
pass
54+
r = n.role_set.select_related().filter(name="chair")
55+
chair = None
56+
if r:
57+
chair = r[0]
58+
announcements = Message.objects.filter(related_groups=n).order_by('-time')
59+
for a in announcements:
60+
a.to_name = address_re.sub("", a.to)
61+
62+
regimes.append(dict(chair=chair,
63+
announcements=announcements,
64+
group=n))
6765

6866
regimes.sort(key=lambda x: x["group"].start_year, reverse=True)
6967

0 commit comments

Comments
 (0)