Skip to content

Commit 3bf997b

Browse files
jennifer-richardsjennifer-richards
authored
chore: rename management commands to avoid non-inclusive language (ietf-tools#4656)
* chore: rename create_dummy_meeting to create_test_meeting * chore: reword comments to match renamed command * chore: rename make_dummy_nomcom to create_test_nomcom Avoids non-inclusive language and better matches other command naming. * chore: reword comments to match renamed command
1 parent de3dbdc commit 3bf997b

2 files changed

Lines changed: 20 additions & 20 deletions

File tree

ietf/meeting/management/commands/create_dummy_meeting.py renamed to ietf/meeting/management/commands/create_test_meeting.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -58,20 +58,20 @@
5858

5959

6060
class Command(BaseCommand):
61-
help = "Create (or delete) a dummy meeting for test and development purposes."
61+
help = "Create (or delete) a meeting for test and development purposes."
6262

6363
def add_arguments(self, parser):
64-
parser.add_argument('--delete', dest='delete', action='store_true', help='Delete the test and development dummy meeting')
64+
parser.add_argument('--delete', dest='delete', action='store_true', help='Delete the test and development meeting')
6565
parser.add_argument('--old-conflicts', dest='old_conflicts', action='store_true',
6666
help='Use old conflict types ("conflict", "conflic2", "conflic3") instead of new ("chair_conflict", "tech_overlap", "key_participant")')
6767
parser.add_argument(
6868
'--start-date',
69-
help='Start date for the dummy meeting (yyyy-mm-dd, defaults to 2019-11-16)',
69+
help='Start date for the test meeting (yyyy-mm-dd, defaults to 2019-11-16)',
7070
type=lambda s: datetime.datetime.strptime(s, '%Y-%m-%d').date(),
7171
default='2019-11-16',
7272
)
7373
parser.add_argument('--tz', default='UTC',
74-
help='Time zone for created meeting. Defaults to UTC. Use "" to disable.')
74+
help='Time zone for test meeting. Defaults to UTC. Use "" to disable.')
7575

7676
def _meeting_datetime(self, day, *time_args):
7777
"""Generate a datetime on a meeting day"""
@@ -82,7 +82,7 @@ def _meeting_datetime(self, day, *time_args):
8282

8383
def handle(self, *args, **options):
8484
if socket.gethostname().split('.')[0] in ['core3', 'ietfa', 'ietfb', 'ietfc', ]:
85-
raise EnvironmentError("Refusing to create a dummy meetng on a production server")
85+
raise EnvironmentError("Refusing to create a test meetng on a production server")
8686

8787
opt_delete = options.get('delete', False)
8888
opt_use_old_conflicts = options.get('old_conflicts', False)
@@ -94,17 +94,17 @@ def handle(self, *args, **options):
9494
if opt_delete:
9595
if Meeting.objects.filter(number='999').exists():
9696
Meeting.objects.filter(number='999').delete()
97-
self.stdout.write("Deleted dummy meeting IETF 999 and its related objects.")
97+
self.stdout.write("Deleted test meeting IETF 999 and its related objects.")
9898
else:
99-
self.stderr.write("Dummy meeting IETF 999 does not exist; nothing to do.\n")
99+
self.stderr.write("Test meeting IETF 999 does not exist; nothing to do.\n")
100100
else:
101101
if Meeting.objects.filter(number='999').exists():
102-
self.stderr.write("Dummy meeting IETF 999 already exists; nothing to do.\n")
102+
self.stderr.write("Test meeting IETF 999 already exists; nothing to do.\n")
103103
else:
104104
transaction.set_autocommit(False)
105105

106106
if self.start_date.isoweekday() != 6:
107-
self.stderr.write("Warning: dummy meeting does not start on Saturday, watch out for bugs")
107+
self.stderr.write("Warning: test meeting does not start on Saturday, watch out for bugs")
108108

109109
m = Meeting.objects.create(
110110
number='999',

ietf/nomcom/management/commands/make_dummy_nomcom.py renamed to ietf/nomcom/management/commands/create_test_nomcom.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,47 +14,47 @@
1414
from ietf.person.models import User
1515

1616
class Command(BaseCommand):
17-
help = ("Create (or delete) a dummy nomcom for test and development purposes.")
17+
help = ("Create (or delete) a nomcom for test and development purposes.")
1818

1919
def add_arguments(self, parser):
20-
parser.add_argument('--delete', dest='delete', action='store_true', help='Delete the test and development dummy nomcom')
20+
parser.add_argument('--delete', dest='delete', action='store_true', help='Delete the test and development nomcom')
2121

2222
def handle(self, *args, **options):
2323
if socket.gethostname().split('.')[0] in ['core3', 'ietfa', 'ietfb', 'ietfc', ]:
24-
raise EnvironmentError("Refusing to create a dummy nomcom on a production server")
24+
raise EnvironmentError("Refusing to create a test nomcom on a production server")
2525

2626
opt_delete = options.get('delete', False)
2727
if opt_delete:
2828
if Group.objects.filter(acronym='nomcom7437').exists():
2929
Group.objects.filter(acronym='nomcom7437').delete()
30-
User.objects.filter(username__in=['dummychair','dummymember','dummycandidate']).delete()
31-
self.stdout.write("Deleted dummy group 'nomcom7437' and its related objects.")
30+
User.objects.filter(username__in=['testchair','testmember','testcandidate']).delete()
31+
self.stdout.write("Deleted test group 'nomcom7437' and its related objects.")
3232
else:
33-
self.stderr.write("Dummy nomcom 'nomcom7437' does not exist; nothing to do.\n")
33+
self.stderr.write("test nomcom 'nomcom7437' does not exist; nothing to do.\n")
3434
else:
3535
if Group.objects.filter(acronym='nomcom7437').exists():
36-
self.stderr.write("Dummy nomcom 'nomcom7437' already exists; nothing to do.\n")
36+
self.stderr.write("test nomcom 'nomcom7437' already exists; nothing to do.\n")
3737
else:
3838
nc = NomComFactory.create(**nomcom_kwargs_for_year(year=7437,
3939
populate_personnel=False,
4040
populate_positions=False))
4141

42-
e = EmailFactory(person__name='Dummy Chair', address='dummychair@example.com', person__user__username='dummychair', person__default_emails=False, origin='dummychair')
42+
e = EmailFactory(person__name='Test Chair', address='testchair@example.com', person__user__username='testchair', person__default_emails=False, origin='testchair')
4343
e.person.user.set_password('password')
4444
e.person.user.save()
4545
nc.group.role_set.create(name_id='chair',person=e.person,email=e)
4646

47-
e = EmailFactory(person__name='Dummy Member', address='dummymember@example.com', person__user__username='dummymember', person__default_emails=False, origin='dummymember')
47+
e = EmailFactory(person__name='Test Member', address='testmember@example.com', person__user__username='testmember', person__default_emails=False, origin='testmember')
4848
e.person.user.set_password('password')
4949
e.person.user.save()
5050
nc.group.role_set.create(name_id='member',person=e.person,email=e)
5151

5252

53-
e = EmailFactory(person__name='Dummy Candidate', address='dummycandidate@example.com', person__user__username='dummycandidate', person__default_emails=False, origin='dummycandidate')
53+
e = EmailFactory(person__name='Test Candidate', address='testcandidate@example.com', person__user__username='testcandidate', person__default_emails=False, origin='testcandidate')
5454
e.person.user.set_password('password')
5555
e.person.user.save()
5656
NomineePositionFactory(nominee__nomcom=nc, nominee__person=e.person,
57-
position__nomcom=nc, position__name='Dummy Area Director', position__is_iesg_position=True,
57+
position__nomcom=nc, position__name='Test Area Director', position__is_iesg_position=True,
5858
)
5959

6060
self.stdout.write("%s\n" % key)

0 commit comments

Comments
 (0)