Skip to content

Commit 1dab3b1

Browse files
authored
fix: use django 2.2 makemigrations --check (ietf-tools#4351)
1 parent b8aa52f commit 1dab3b1

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

.github/workflows/build.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,8 @@ jobs:
130130
./ietf/manage.py check
131131
./ietf/manage.py migrate
132132
echo "Validating migrations..."
133-
MSG=$(ietf/manage.py makemigrations 2>&1)
134-
if ! ( echo ${MSG} | grep -q "^No changes detected$") ; then
133+
if ! ( ietf/manage.py makemigrations --dry-run --check --verbosity 3 ) ; then
135134
echo "Model changes without migrations found."
136-
echo ${MSG}
137135
exit 1
138136
fi
139137
echo "Running tests..."

.github/workflows/ci-run-tests.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ jobs:
4444
./ietf/manage.py check
4545
./ietf/manage.py migrate
4646
echo "Validating migrations..."
47-
MSG=$(ietf/manage.py makemigrations 2>&1)
48-
if ! ( echo ${MSG} | grep -q "^No changes detected$") ; then
47+
if ! ( ietf/manage.py makemigrations --dry-run --check --verbosity 3 ) ; then
4948
echo "Model changes without migrations found."
5049
echo ${MSG}
5150
exit 1

0 commit comments

Comments
 (0)