Skip to content

Commit 19d5852

Browse files
committed
Django 1.10 does not permit the view argument to url() to be a string any more. Changed all cases view arguments to url() which were strings to instead reference the actual imported function.
- Legacy-Id: 12815
1 parent 2d8963c commit 19d5852

35 files changed

Lines changed: 349 additions & 288 deletions

File tree

ietf/community/urls.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
from django.conf.urls import url
22

33

4+
from ietf.community import views
5+
46
urlpatterns = [
5-
url(r'^personal/(?P<username>[^/]+)/$', 'ietf.community.views.view_list'),
6-
url(r'^personal/(?P<username>[^/]+)/manage/$', 'ietf.community.views.manage_list'),
7-
url(r'^personal/(?P<username>[^/]+)/trackdocument/(?P<name>[^/]+)/$', 'ietf.community.views.track_document'),
8-
url(r'^personal/(?P<username>[^/]+)/untrackdocument/(?P<name>[^/]+)/$', 'ietf.community.views.untrack_document'),
9-
url(r'^personal/(?P<username>[^/]+)/csv/$', 'ietf.community.views.export_to_csv'),
10-
url(r'^personal/(?P<username>[^/]+)/feed/$', 'ietf.community.views.feed'),
11-
url(r'^personal/(?P<username>[^/]+)/subscription/$', 'ietf.community.views.subscription'),
7+
url(r'^personal/(?P<username>[^/]+)/$', views.view_list),
8+
url(r'^personal/(?P<username>[^/]+)/manage/$', views.manage_list),
9+
url(r'^personal/(?P<username>[^/]+)/trackdocument/(?P<name>[^/]+)/$', views.track_document),
10+
url(r'^personal/(?P<username>[^/]+)/untrackdocument/(?P<name>[^/]+)/$', views.untrack_document),
11+
url(r'^personal/(?P<username>[^/]+)/csv/$', views.export_to_csv),
12+
url(r'^personal/(?P<username>[^/]+)/feed/$', views.feed),
13+
url(r'^personal/(?P<username>[^/]+)/subscription/$', views.subscription),
1214
]

ietf/dbtemplate/urls.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
from django.conf.urls import url
22

33

4+
from ietf.dbtemplate import views
5+
46
urlpatterns = [
5-
url(r'^(?P<acronym>[-a-z0-9]+)/$', 'ietf.dbtemplate.views.template_list', name='template_list'),
6-
url(r'^(?P<acronym>[-a-z0-9]+)/(?P<template_id>[\d]+)/$', 'ietf.dbtemplate.views.template_edit', name='template_edit'),
7+
url(r'^(?P<acronym>[-a-z0-9]+)/$', views.template_list, name='template_list'),
8+
url(r'^(?P<acronym>[-a-z0-9]+)/(?P<template_id>[\d]+)/$', views.template_edit, name='template_edit'),
79
]

ietf/doc/urls.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
from django.views.generic import RedirectView
3535
from django.conf import settings
3636

37-
from ietf.doc import views_search, views_draft, views_ballot, views_status_change, views_doc, views_stats
37+
from ietf.doc import views_search, views_draft, views_ballot, views_status_change, views_doc, views_stats, views_help
3838

3939
session_patterns = [
4040
url(r'^add$', views_doc.add_sessionpresentation),
@@ -116,9 +116,9 @@
116116
url(r'^%(name)s/edit/approveballot/$' % settings.URL_REGEXPS, views_ballot.approve_ballot, name='doc_approve_ballot'),
117117
url(r'^%(name)s/edit/makelastcall/$' % settings.URL_REGEXPS, views_ballot.make_last_call, name='doc_make_last_call'),
118118

119-
url(r'^help/state/(?P<type>[\w-]+)/$', 'ietf.doc.views_help.state_help', name="state_help"),
120-
url(r'^help/relationships/$', 'ietf.doc.views_help.relationship_help', name="relationship_help"),
121-
url(r'^help/relationships/(?P<subset>\w+)/$', 'ietf.doc.views_help.relationship_help', name="relationship_subset_help"),
119+
url(r'^help/state/(?P<type>[\w-]+)/$', views_help.state_help, name="state_help"),
120+
url(r'^help/relationships/$', views_help.relationship_help, name="relationship_help"),
121+
url(r'^help/relationships/(?P<subset>\w+)/$', views_help.relationship_help, name="relationship_subset_help"),
122122

123123
url(r'^%(name)s/meetings/?$' % settings.URL_REGEXPS, views_doc.all_presentations),
124124

ietf/doc/urls_charter.py

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,19 @@
33
from django.conf.urls import url
44
from django.conf import settings
55

6+
from ietf.doc import views_charter, views_doc
7+
68
urlpatterns = [
7-
url(r'^state/$', "ietf.doc.views_charter.change_state", name='charter_change_state'),
8-
url(r'^title/$', "ietf.doc.views_charter.change_title", name='charter_change_title'),
9-
url(r'^(?P<option>initcharter|recharter|abandon)/$', "ietf.doc.views_charter.change_state", name='charter_startstop_process'),
10-
url(r'^telechat/$', "ietf.doc.views_doc.telechat_date", name='charter_telechat_date'),
11-
url(r'^notify/$', "ietf.doc.views_doc.edit_notify", name='charter_edit_notify'),
12-
url(r'^ad/$', "ietf.doc.views_charter.edit_ad", name='charter_edit_ad'),
13-
url(r'^action/$', "ietf.doc.views_charter.action_announcement_text"),
14-
url(r'^review/$', "ietf.doc.views_charter.review_announcement_text"),
15-
url(r'^ballotwriteupnotes/$', "ietf.doc.views_charter.ballot_writeupnotes"),
16-
url(r'^approve/$', "ietf.doc.views_charter.approve", name='charter_approve'),
17-
url(r'^submit/(?:(?P<option>initcharter|recharter)/)?$', "ietf.doc.views_charter.submit", name='charter_submit'),
18-
url(r'^withmilestones-%(rev)s.txt$' % settings.URL_REGEXPS, "ietf.doc.views_charter.charter_with_milestones_txt", name='charter_with_milestones_txt'),
9+
url(r'^state/$', views_charter.change_state, name='charter_change_state'),
10+
url(r'^title/$', views_charter.change_title, name='charter_change_title'),
11+
url(r'^(?P<option>initcharter|recharter|abandon)/$', views_charter.change_state, name='charter_startstop_process'),
12+
url(r'^telechat/$', views_doc.telechat_date, name='charter_telechat_date'),
13+
url(r'^notify/$', views_doc.edit_notify, name='charter_edit_notify'),
14+
url(r'^ad/$', views_charter.edit_ad, name='charter_edit_ad'),
15+
url(r'^action/$', views_charter.action_announcement_text),
16+
url(r'^review/$', views_charter.review_announcement_text),
17+
url(r'^ballotwriteupnotes/$', views_charter.ballot_writeupnotes),
18+
url(r'^approve/$', views_charter.approve, name='charter_approve'),
19+
url(r'^submit/(?:(?P<option>initcharter|recharter)/)?$', views_charter.submit, name='charter_submit'),
20+
url(r'^withmilestones-%(rev)s.txt$' % settings.URL_REGEXPS, views_charter.charter_with_milestones_txt, name='charter_with_milestones_txt'),
1921
]

ietf/doc/urls_conflict_review.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
from django.conf.urls import url
22

3+
from ietf.doc import views_conflict_review, views_doc
4+
35
urlpatterns = [
4-
url(r'^state/$', "ietf.doc.views_conflict_review.change_state", name='conflict_review_change_state'),
5-
url(r'^submit/$', "ietf.doc.views_conflict_review.submit", name='conflict_review_submit'),
6-
url(r'^ad/$', "ietf.doc.views_conflict_review.edit_ad", name='conflict_review_ad'),
7-
url(r'^approve/$', "ietf.doc.views_conflict_review.approve", name='conflict_review_approve'),
8-
url(r'^start_conflict_review/$', "ietf.doc.views_conflict_review.start_review", name='conflict_review_start'),
9-
url(r'^telechat/$', "ietf.doc.views_doc.telechat_date", name='conflict_review_telechat_date'),
10-
url(r'^notices/$', "ietf.doc.views_doc.edit_notify", name='conflict_review_notices'),
6+
url(r'^state/$', views_conflict_review.change_state, name='conflict_review_change_state'),
7+
url(r'^submit/$', views_conflict_review.submit, name='conflict_review_submit'),
8+
url(r'^ad/$', views_conflict_review.edit_ad, name='conflict_review_ad'),
9+
url(r'^approve/$', views_conflict_review.approve, name='conflict_review_approve'),
10+
url(r'^start_conflict_review/$', views_conflict_review.start_review, name='conflict_review_start'),
11+
url(r'^telechat/$', views_doc.telechat_date, name='conflict_review_telechat_date'),
12+
url(r'^notices/$', views_doc.edit_notify, name='conflict_review_notices'),
1113
]
1214

1315

ietf/doc/urls_material.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
from django.conf.urls import url
22

3+
from ietf.doc import views_material
4+
35
urlpatterns = [
4-
url(r'^(?P<action>state|title|abstract|revise)/$', "ietf.doc.views_material.edit_material", name="material_edit"),
6+
url(r'^(?P<action>state|title|abstract|revise)/$', views_material.edit_material, name="material_edit"),
57
]
68

ietf/doc/urls_status_change.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,17 @@
11
from django.conf.urls import url
22

3+
from ietf.doc import views_status_change, views_doc
4+
35
urlpatterns = [
4-
url(r'^state/$', "ietf.doc.views_status_change.change_state", name='status_change_change_state'),
5-
url(r'^submit/$', "ietf.doc.views_status_change.submit", name='status_change_submit'),
6-
url(r'^ad/$', "ietf.doc.views_status_change.edit_ad", name='status_change_ad'),
7-
url(r'^title/$', "ietf.doc.views_status_change.edit_title", name='status_change_title'),
8-
url(r'^approve/$', "ietf.doc.views_status_change.approve", name='status_change_approve'),
9-
url(r'^relations/$', "ietf.doc.views_status_change.edit_relations", name='status_change_relations'),
10-
url(r'^last-call/$', "ietf.doc.views_status_change.last_call", name='status_change_last_call'),
11-
url(r'^telechat/$', "ietf.doc.views_doc.telechat_date", name='status_change_telechat_date'),
12-
url(r'^notices/$', "ietf.doc.views_doc.edit_notify", name='status_change_notices'),
6+
url(r'^state/$', views_status_change.change_state, name='status_change_change_state'),
7+
url(r'^submit/$', views_status_change.submit, name='status_change_submit'),
8+
url(r'^ad/$', views_status_change.edit_ad, name='status_change_ad'),
9+
url(r'^title/$', views_status_change.edit_title, name='status_change_title'),
10+
url(r'^approve/$', views_status_change.approve, name='status_change_approve'),
11+
url(r'^relations/$', views_status_change.edit_relations, name='status_change_relations'),
12+
url(r'^last-call/$', views_status_change.last_call, name='status_change_last_call'),
13+
url(r'^telechat/$', views_doc.telechat_date, name='status_change_telechat_date'),
14+
url(r'^notices/$', views_doc.edit_notify, name='status_change_notices'),
1315
]
1416

1517

ietf/group/urls.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,18 @@
33
from django.conf.urls import url, include
44
from django.conf import settings
55

6+
from ietf.group import views, views_ajax, views_edit
7+
68
urlpatterns = [
7-
url(r'^$', 'ietf.group.views.active_groups'),
8-
url(r'^groupmenu.json', 'ietf.group.views_ajax.group_menu_data', None, "group_menu_data"),
9-
url(r'^%(acronym)s.json$' % settings.URL_REGEXPS, 'ietf.group.views_ajax.group_json'),
10-
url(r'^chartering/$', 'ietf.group.views.chartering_groups'),
11-
url(r'^chartering/create/(?P<group_type>(wg|rg))/$', 'ietf.group.views_edit.edit', {'action': "charter"}, "group_create"),
12-
url(r'^concluded/$', 'ietf.group.views.concluded_groups'),
13-
url(r'^email-aliases/$', 'ietf.group.views.email_aliases'),
14-
url(r'^all-status/$', 'ietf.group.views.all_status'),
9+
url(r'^$', views.active_groups),
10+
url(r'^groupmenu.json', views_ajax.group_menu_data, None, "group_menu_data"),
11+
url(r'^%(acronym)s.json$' % settings.URL_REGEXPS, views_ajax.group_json),
12+
url(r'^chartering/$', views.chartering_groups),
13+
url(r'^chartering/create/(?P<group_type>(wg|rg))/$', views_edit.edit, {'action': "charter"}, "group_create"),
14+
url(r'^concluded/$', views.concluded_groups),
15+
url(r'^email-aliases/$', views.email_aliases),
16+
url(r'^all-status/$', views.all_status),
1517

16-
url(r'^%(acronym)s/$' % settings.URL_REGEXPS, 'ietf.group.views.group_home', None, "group_home"),
18+
url(r'^%(acronym)s/$' % settings.URL_REGEXPS, views.group_home, None, "group_home"),
1719
url(r'^%(acronym)s/' % settings.URL_REGEXPS, include('ietf.group.urls_info_details')),
1820
]

ietf/group/urls_info.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
url(r'^chartering/$', RedirectView.as_view(url='/group/chartering/', permanent=True)),
1919
url(r'^chartering/create/$', RedirectView.as_view(url='/group/chartering/create/%(group_type)s/', permanent=True)),
2020
url(r'^bofs/$', views.bofs),
21-
url(r'^email-aliases/$', 'ietf.group.views.email_aliases'),
21+
url(r'^email-aliases/$', views.email_aliases),
2222
url(r'^bofs/create/$', views_edit.edit, {'action': "create", }, "bof_create"),
2323
url(r'^photos/$', views.chair_photos),
2424
url(r'^%(acronym)s/' % settings.URL_REGEXPS, include('ietf.group.urls_info_details')),

ietf/group/urls_info_details.py

Lines changed: 31 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,43 @@
11
from django.conf.urls import url
22
from django.views.generic import RedirectView
3-
from ietf.group import views, views_review
3+
4+
from ietf.community import views as community_views
5+
from ietf.doc import views_material as material_views
6+
from ietf.group import views, views_edit, views_review, milestones as milestone_views
47

58
urlpatterns = [
6-
url(r'^$', 'ietf.group.views.group_home', None, "group_home"),
7-
url(r'^documents/txt/$', 'ietf.group.views.group_documents_txt'),
8-
url(r'^documents/$', 'ietf.group.views.group_documents', None, "group_docs"),
9-
url(r'^documents/manage/$', 'ietf.community.views.manage_list'),
10-
url(r'^documents/csv/$', 'ietf.community.views.export_to_csv'),
11-
url(r'^documents/feed/$', 'ietf.community.views.feed'),
12-
url(r'^documents/subscription/$', 'ietf.community.views.subscription'),
13-
url(r'^charter/$', 'ietf.group.views.group_about', None, 'group_charter'),
14-
url(r'^about/$', 'ietf.group.views.group_about', None, 'group_about'),
15-
url(r'^about/status/$', 'ietf.group.views.group_about_status'),
16-
url(r'^about/status/edit/$', 'ietf.group.views.group_about_status_edit'),
17-
url(r'^about/status/meeting/(?P<num>\d+)/$', 'ietf.group.views.group_about_status_meeting'),
18-
url(r'^history/$','ietf.group.views.history'),
19-
url(r'^email/$', 'ietf.group.views.email'),
20-
url(r'^deps/(?P<output_type>[\w-]+)/$', 'ietf.group.views.dependencies'),
21-
url(r'^meetings/$', 'ietf.group.views.meetings'),
22-
url(r'^edit/$', 'ietf.group.views_edit.edit', {'action': "edit"}, "group_edit"),
23-
url(r'^conclude/$', 'ietf.group.views_edit.conclude'),
24-
url(r'^milestones/$', 'ietf.group.milestones.edit_milestones', {'milestone_set': "current"}, "group_edit_milestones"),
25-
url(r'^milestones/charter/$', 'ietf.group.milestones.edit_milestones', {'milestone_set': "charter"}, "group_edit_charter_milestones"),
26-
url(r'^milestones/charter/reset/$', 'ietf.group.milestones.reset_charter_milestones', None, "group_reset_charter_milestones"),
27-
url(r'^workflow/$', 'ietf.group.views_edit.customize_workflow'),
28-
url(r'^materials/$', 'ietf.group.views.materials', None, "group_materials"),
29-
url(r'^materials/new/$', 'ietf.doc.views_material.choose_material_type'),
30-
url(r'^materials/new/(?P<doc_type>[\w-]+)/$', 'ietf.doc.views_material.edit_material', { 'action': "new" }, "group_new_material"),
31-
url(r'^archives/$', 'ietf.group.views.derived_archives'),
9+
url(r'^$', views.group_home, None, "group_home"),
10+
url(r'^documents/txt/$', views.group_documents_txt),
11+
url(r'^documents/$', views.group_documents, None, "group_docs"),
12+
url(r'^documents/manage/$', community_views.manage_list),
13+
url(r'^documents/csv/$', community_views.export_to_csv),
14+
url(r'^documents/feed/$', community_views.feed),
15+
url(r'^documents/subscription/$', community_views.subscription),
16+
url(r'^charter/$', views.group_about, None, 'group_charter'),
17+
url(r'^about/$', views.group_about, None, 'group_about'),
18+
url(r'^about/status/$', views.group_about_status),
19+
url(r'^about/status/edit/$', views.group_about_status_edit),
20+
url(r'^about/status/meeting/(?P<num>\d+)/$', views.group_about_status_meeting),
21+
url(r'^history/$',views.history),
22+
url(r'^email/$', views.email),
23+
url(r'^deps/(?P<output_type>[\w-]+)/$', views.dependencies),
24+
url(r'^meetings/$', views.meetings),
25+
url(r'^edit/$', views_edit.edit, {'action': "edit"}, "group_edit"),
26+
url(r'^conclude/$', views_edit.conclude),
27+
url(r'^milestones/$', milestone_views.edit_milestones, {'milestone_set': "current"}, "group_edit_milestones"),
28+
url(r'^milestones/charter/$', milestone_views.edit_milestones, {'milestone_set': "charter"}, "group_edit_charter_milestones"),
29+
url(r'^milestones/charter/reset/$', milestone_views.reset_charter_milestones, None, "group_reset_charter_milestones"),
30+
url(r'^workflow/$', views_edit.customize_workflow),
31+
url(r'^materials/$', views.materials, None, "group_materials"),
32+
url(r'^materials/new/$', material_views.choose_material_type),
33+
url(r'^materials/new/(?P<doc_type>[\w-]+)/$', material_views.edit_material, { 'action': "new" }, "group_new_material"),
34+
url(r'^archives/$', views.derived_archives),
3235
url(r'^photos/$', views.group_photos),
3336
url(r'^reviews/$', views_review.review_requests),
3437
url(r'^reviews/manage/(?P<assignment_status>assigned|unassigned)/$', views_review.manage_review_requests),
3538
url(r'^reviews/email-assignments/$', views_review.email_open_review_assignments),
3639
url(r'^reviewers/$', views_review.reviewer_overview),
3740
url(r'^reviewers/(?P<reviewer_email>[\w%+-.@]+)/settings/$', views_review.change_reviewer_settings),
3841
url(r'^secretarysettings/$', views_review.change_review_secretary_settings),
39-
url(r'^email-aliases/$', RedirectView.as_view(pattern_name='ietf.group.views.email',permanent=False),name='old_group_email_aliases'),
42+
url(r'^email-aliases/$', RedirectView.as_view(pattern_name=views.email,permanent=False),name='old_group_email_aliases'),
4043
]

0 commit comments

Comments
 (0)