Skip to content

Commit 1841d15

Browse files
feat: allow secretariat to edit/cancel sreqs when the tool is locked (ietf-tools#4676)
* feat: allow secretariat to edit/cancel sreqs when the tool is locked * chore: remove unused template var
1 parent 9752fab commit 1841d15

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

ietf/secr/sreq/views.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -849,7 +849,8 @@ def view(request, acronym, num = None):
849849
session = get_initial_session(sessions)
850850

851851
return render(request, 'sreq/view.html', {
852-
'is_locked': is_locked,
852+
'can_edit': (not is_locked) or has_role(request.user, 'Secretariat'),
853+
'can_cancel': (not is_locked) or has_role(request.user, 'Secretariat'),
853854
'session': session, # legacy processed data
854855
'sessions': sessions, # actual session instances
855856
'activities': activities,

ietf/secr/templates/sreq/view.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ <h2>Sessions - View (meeting: {{ meeting.number }})</h2>
2929

3030
<div class="button-group">
3131
<ul>
32-
<li><button type="button" name="edit" onclick="window.location='{% url "ietf.secr.sreq.views.edit" acronym=group.acronym num=meeting.number %}'"{% if is_locked %} disabled{% endif %}>Edit</button></li>
32+
<li><button type="button" name="edit" onclick="window.location='{% url "ietf.secr.sreq.views.edit" acronym=group.acronym num=meeting.number %}'"{% if not can_edit %} disabled{% endif %}>Edit</button></li>
3333
{% if show_approve_button %}
3434
<li><button type="button" onclick="window.location='approve/'">Approve Third Session</button></li>
3535
{% endif %}
36-
<li><button type="button" onclick="if (window.confirm('Do you really want to cancel this session?')) { window.location='cancel/' };" {% if is_locked %} disabled{% endif %}>Cancel this Request</button></li>
36+
<li><button type="button" onclick="if (window.confirm('Do you really want to cancel this session?')) { window.location='cancel/' };" {% if not can_cancel %} disabled{% endif %}>Cancel this Request</button></li>
3737
<li><button type="button" onclick="window.location='{% url "ietf.secr.sreq.views.main" %}'">Back</button></li>
3838
</ul>
3939
</div> <!-- button-group -->

0 commit comments

Comments
 (0)