Skip to content

Commit 11e56aa

Browse files
committed
Modified the code which accumulates ipr disclosures associated with a document, shown as an IPR count in search results. The previous code had two deficiencies: it could count some IPR disclosures twice, and it also included withdrawn and pending disclosures. The current count matches the IPR search results better.
- Legacy-Id: 6158
1 parent dbda8e8 commit 11e56aa

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

ietf/doc/views_search.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@
4646
from ietf.ipr.models import IprDocAlias
4747
from ietf.idindex.index import active_drafts_index_by_group
4848

49+
import debug
50+
4951
class SearchForm(forms.Form):
5052
name = forms.CharField(required=False)
5153
rfcs = forms.BooleanField(required=False, initial=True)
@@ -149,18 +151,19 @@ def fill_in_search_attributes(docs):
149151
rel_docs += [x.document for x in rel_this_doc]
150152

151153
ipr_docaliases = IprDocAlias.objects.filter(doc_alias__document__in=doc_ids).select_related('doc_alias')
154+
152155
for a in ipr_docaliases:
153-
docs_dict[a.doc_alias.document_id].iprs.append(a)
154-
156+
if a.ipr.status==1 and a.ipr not in docs_dict[a.doc_alias.document_id].iprs:
157+
docs_dict[a.doc_alias.document_id].iprs.append(a.ipr)
155158
rel_docs_dict = dict((d.pk, d) for d in rel_docs)
156159
rel_doc_ids = rel_docs_dict.keys()
157160

158161
rel_ipr_docaliases = IprDocAlias.objects.filter(doc_alias__document__in=rel_doc_ids).select_related('doc_alias')
159162
for a in rel_ipr_docaliases:
160163
if a.doc_alias.document_id in rel_id_camefrom:
161164
for k in rel_id_camefrom[a.doc_alias.document_id]:
162-
if a not in docs_dict[k].iprs:
163-
docs_dict[k].iprs.append(a)
165+
if a.ipr.status==1 and a.ipr not in docs_dict[k].iprs:
166+
docs_dict[k].iprs.append(a.ipr)
164167

165168
# telechat date, can't do this with above query as we need to get TelechatDocEvents out
166169
seen = set()

0 commit comments

Comments
 (0)