Skip to content

Commit 4eb9266

Browse files
committed
Show promo
1 parent 6cd1d47 commit 4eb9266

File tree

5 files changed

+18
-22
lines changed

5 files changed

+18
-22
lines changed

src/components/Notifications.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
{{ t('notificationTime.description') }}
3333
</p>
3434
<ListWithTimeComponent :type="ListWithTime.Notifications" />
35-
<PromoClearYouTube />
3635
</div>
3736
<div class="settings-item">
3837
<label class="setting-header">{{ t('notificationMessage.message') }}</label>

src/components/PromoClearYouTube.vue

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export default {
1515
</script>
1616

1717
<script lang="ts" setup>
18-
import { computed, ref } from 'vue';
18+
import { ref } from 'vue';
1919
import { useI18n } from 'vue-i18n';
2020
import { injecStorage } from '../storage/inject-storage';
2121
import { StorageParams } from '../storage/storage-params';
@@ -32,27 +32,23 @@ const extensionPage = useExtensionPage();
3232
const showReview = ref<boolean>(true);
3333
3434
const canShowPromo = computedAsync(async () => await usePromoExtension());
35-
const isBlockPage = computed(() => extensionPage.isBlockPage);
3635
3736
async function closeBlock() {
3837
showReview.value = false;
39-
await settingsStorage.saveValue(
40-
isBlockPage.value
41-
? StorageParams.PROMO_CLEAR_YOUTUBE_ON_BLOCK
42-
: StorageParams.PROMO_CLEAR_YOUTUBE_ON_LIMITS,
43-
true,
44-
);
38+
await saveValue();
4539
}
4640
4741
async function openStore() {
4842
showReview.value = false;
4943
window.open(CHROME_STORE_CLEAR_YOUTUBE_URL, '_blank');
50-
await settingsStorage.saveValue(
51-
isBlockPage.value
52-
? StorageParams.PROMO_CLEAR_YOUTUBE_ON_BLOCK
53-
: StorageParams.PROMO_CLEAR_YOUTUBE_ON_LIMITS,
54-
true,
55-
);
44+
await saveValue();
45+
}
46+
47+
async function saveValue() {
48+
let param: StorageParams | undefined = undefined;
49+
if (extensionPage.isBlockPage.value) param = StorageParams.PROMO_CLEAR_YOUTUBE_ON_BLOCK;
50+
if (extensionPage.isLimitPage.value) param = StorageParams.PROMO_CLEAR_YOUTUBE_ON_LIMITS;
51+
if (param) await settingsStorage.saveValue(param, true);
5652
}
5753
</script>
5854

src/compositions/useExtensionPage.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import { SettingsTab } from '../utils/enums';
33
import { getStringTab } from '../utils/extension-tabs';
44

55
export const QUERY_PARAMS_DASHBOARD = 'dashboard.html';
6-
export const QUERY_PARAMS_DASHBOARD_TAB = 'tab';
7-
export const QUERY_PARAMS_DASHBOARD_TAB_LIMITS = 'limits';
6+
export const QUERY_PARAMS_TAB = 'tab';
7+
export const QUERY_PARAMS_TAB_LIMITS = 'limits';
88
export const QUERY_PARAMS_BLOCK = 'block.html';
99
export const QUERY_PARAMS_BLOCK_DOMAIN = 'domain';
1010

@@ -15,20 +15,19 @@ export function useExtensionPage() {
1515
() =>
1616
urlObj.value.hostname == __APP_ID__ &&
1717
urlObj.value.pathname.includes(QUERY_PARAMS_DASHBOARD) &&
18-
urlObj.value.searchParams.get(QUERY_PARAMS_DASHBOARD_TAB) ==
19-
QUERY_PARAMS_DASHBOARD_TAB_LIMITS,
18+
urlObj.value.searchParams.get(QUERY_PARAMS_TAB) == QUERY_PARAMS_TAB_LIMITS,
2019
);
2120

2221
const isBlockPage = computed(
2322
() =>
2423
urlObj.value.hostname == __APP_ID__ &&
2524
urlObj.value.pathname.includes(QUERY_PARAMS_BLOCK) &&
26-
urlObj.value.searchParams.get(QUERY_PARAMS_BLOCK_DOMAIN) == 'youtube.com',
25+
urlObj.value.searchParams.get(QUERY_PARAMS_BLOCK_DOMAIN)?.includes('youtube.com'),
2726
);
2827

2928
function updateTab(tab: SettingsTab) {
3029
let targetTab = getStringTab(tab);
31-
const currentTab = urlObj.value.searchParams.get(QUERY_PARAMS_DASHBOARD_TAB);
30+
const currentTab = urlObj.value.searchParams.get(QUERY_PARAMS_TAB);
3231
if (window.history.replaceState && currentTab) {
3332
const sourceUrl = `tab=${currentTab}`;
3433
const targetUrl = `tab=${targetTab}`;

src/compositions/usePromoExtension.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,5 +41,5 @@ export async function usePromoExtension() {
4141
extensionPage.isBlockPage.value,
4242
);
4343

44-
return showOnLimitPage || showOnBlockPage;
44+
return showOnLimitPage.value || showOnBlockPage.value;
4545
}

src/pages/Block.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
@click="deferring()"
3131
/>
3232
<p class="desctiption">{{ t('deferringDescription.message') }}</p>
33+
<PromoClearYouTube />
3334
</div>
3435
</template>
3536

@@ -41,6 +42,7 @@ import { injecStorage } from '../storage/inject-storage';
4142
import { BLOCK_DEFERRAL_DEFAULT, StorageParams } from '../storage/storage-params';
4243
import { convertLimitTimeToString } from '../utils/converter';
4344
import { defering, canDefering } from '../compositions/deferList';
45+
import PromoClearYouTube from '../components/PromoClearYouTube.vue';
4446
4547
const { t } = useI18n();
4648

0 commit comments

Comments
 (0)