Update favicon after loading page

Author: Stigmatoz

src/background.ts

@@ -1,11 +1,16 @@
 import Browser from "webextension-polyfill";
 import { initTracker } from "./tracker";
 import { logger } from "./compositions/logger";
+import { useFavicon } from "./compositions/update-favicon";
 
 logger.log("Start background script");
 
 Browser.runtime.onInstalled.addListener((details) => {
   logger.log("Extension installed:", details);
 });
 
+Browser.webNavigation.onCompleted.addListener(async function(details) {
+  await useFavicon(details.tabId);
+});
+
 initTracker();

src/compositions/update-favicon.ts

@@ -0,0 +1,16 @@
+import Browser from 'webextension-polyfill';
+import { isValidPage } from './valid-page';
+import { extractHostname } from './extract-hostname';
+import { injectTabsRepository } from '../repository/inject-tabs-repository';
+
+export async function useFavicon(tabId: number): Promise<void>{
+    const repo = await injectTabsRepository();
+    const tab = await Browser.tabs.get(tabId);
+    if (isValidPage(tab)) {
+        const activeDomain = extractHostname(tab?.url);
+        let tabFromStoage = repo.getTab(activeDomain);
+        if (tabFromStoage != undefined && tabFromStoage.favicon != null){
+            tabFromStoage.setFavicon(tab?.favIconUrl);
+        }
+    }
+}

src/entity/tab.ts

@@ -8,9 +8,8 @@ export class Tab implements ISerializable<Tab> {
     counter: number = 0
     days: TabDay[] = [];
 
-    init(url: string, favicon: string){
+    init(url: string){
         this.url = url;
-        this.favicon = favicon;
     }
 
     incSummaryTime() :void {
@@ -48,6 +47,13 @@ export class Tab implements ISerializable<Tab> {
 
         return this;
     }
+
+    setFavicon(favicon: string | undefined){
+        if (favicon != undefined)
+            this.favicon = favicon;
+        else
+            this.favicon = "chrome://favicon/" + this.url;
+    }
 }
 
 export class TabDay implements ISerializable<TabDay> {

src/repository/tabs-repository.ts

@@ -29,16 +29,11 @@ export class TabsRepository implements ITabsRepository {
     const tabFromStorage = this.getTab(domain);
     const isInBlackListFlag = await isInBlackList(domain);
 
-    if (!isInBlackListFlag) {
-      if (!tabFromStorage) {
-        if (!favicon) {
-          favicon = "chrome://favicon/" + domain;
-        }
+    if (!isInBlackListFlag && !tabFromStorage) {
         const newTab = new Tab();
-        newTab.init(domain, favicon);
+        newTab.init(domain);
         this.tabs.push(newTab);
         return newTab;
-      }
     }
 
     return undefined;