No longer require '._domainkey' for domains.selectors (canada-ca#817)

Ethanljf · web-flow · commit f4eed5fb8864 · 2020-09-11T09:44:50.000-03:00
* Append '._domainkey' to all dkim selector strings within scanning process

* Reflect changes within test
diff --git a/services/scanners/dns/dns_scanner.py b/services/scanners/dns/dns_scanner.py
@@ -108,7 +108,7 @@ async def scan_dkim(domain, selectors):
         record[selector] = {}
         try:
             # Retrieve public key from DNS
-            pk_txt = dnsplug.get_txt_dnspython(f"{selector}.{domain}")
+            pk_txt = dnsplug.get_txt_dnspython(f"{selector}._domainkey.{domain}")
             logging.info("Public key (TXT) retrieved from DNS")
 
             pk, keysize, ktag = load_pk(f"{selector}.{domain}", pk_txt)
diff --git a/services/scanners/dns/tests/test_dns_scanner.py b/services/scanners/dns/tests/test_dns_scanner.py
@@ -14,7 +14,7 @@ def test_scan():
     test_payload = {
         "scan_id": 1,
         "domain": "cyber.gc.ca",
-        "selectors": ["selector1._domainkey", "selector2._domainkey"],
+        "selectors": ["selector1", "selector2"],
     }
 
     res = test_client.post("/", json=test_payload)

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ def test_scan():`
`14`	`14`	`test_payload = {`
`15`	`15`	`"scan_id": 1,`
`16`	`16`	`"domain": "cyber.gc.ca",`
`17`		`- "selectors": ["selector1._domainkey", "selector2._domainkey"],`
	`17`	`+ "selectors": ["selector1", "selector2"],`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`res = test_client.post("/", json=test_payload)`