Skip to content

Commit 85ca252

Browse files
authored
Don't send results on timeout. On exception, send domain_key (canada-ca#1299)
* Don't send results on timeout. On exception, send domain_key * Don't send results on timeout. On exception, send domain_key
1 parent ccc23c6 commit 85ca252

3 files changed

Lines changed: 3 additions & 12 deletions

File tree

services/scanners/dns/dns_scanner.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -255,9 +255,6 @@ async def scan(scan_request):
255255
def timeout_handler(signum, frame):
256256
msg = "Timeout while performing scan"
257257
logging.error(msg)
258-
dispatch_results(
259-
{"scan_type": "dns", "uuid": uuid, "results": {}}, server_client
260-
)
261258
return PlainTextResponse(msg)
262259

263260
try:
@@ -310,7 +307,7 @@ def timeout_handler(signum, frame):
310307
logging.error(msg)
311308
logging.error(f"Full traceback: {traceback.format_exc()}")
312309
dispatch_results(
313-
{"scan_type": "dns", "uuid": uuid, "results": {}}, server_client
310+
{"scan_type": "dns", "uuid": uuid, "domain_key": domain_key, "results": {}}, server_client
314311
)
315312
return PlainTextResponse(msg)
316313

services/scanners/https/https_scanner.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,6 @@ async def scan(scan_request):
155155
def timeout_handler(signum, frame):
156156
msg = "Timeout while performing scan"
157157
logging.error(msg)
158-
dispatch_results(
159-
{"scan_type": "https", "uuid": uuid, "results": {}}, server_client
160-
)
161158
return PlainTextResponse(msg)
162159

163160
try:
@@ -198,7 +195,7 @@ def timeout_handler(signum, frame):
198195
logging.error(msg)
199196
logging.error(f"Full traceback: {traceback.format_exc()}")
200197
dispatch_results(
201-
{"scan_type": "https", "uuid": uuid, "results": {}}, server_client
198+
{"scan_type": "https", "uuid": uuid, "domain_key": domain_key, "results": {}}, server_client
202199
)
203200
return PlainTextResponse(msg)
204201

services/scanners/ssl/ssl_scanner.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -305,9 +305,6 @@ async def scan(scan_request):
305305
def timeout_handler(signum, frame):
306306
msg = "Timeout while performing scan"
307307
logging.error(msg)
308-
dispatch_results(
309-
{"scan_type": "ssl", "uuid": uuid, "results": {}}, server_client
310-
)
311308
return PlainTextResponse(msg)
312309

313310
try:
@@ -357,7 +354,7 @@ def timeout_handler(signum, frame):
357354
logging.error(msg)
358355
logging.error(f"Full traceback: {traceback.format_exc()}")
359356
dispatch_results(
360-
{"scan_type": "ssl", "uuid": uuid, "results": {}}, server_client
357+
{"scan_type": "ssl", "uuid": uuid, "domain_key": domain_key, "results": {}}, server_client
361358
)
362359
return PlainTextResponse(msg)
363360

0 commit comments

Comments
 (0)