Skip to content

Commit 1febaed

Browse files
authored
Guidance table update (canada-ca#854)
* Update guidance table * Revised version file
1 parent 1414996 commit 1febaed

5 files changed

Lines changed: 69 additions & 15 deletions

File tree

scripts/insert_csv.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -210,19 +210,22 @@
210210
"guidance",
211211
metadata,
212212
sqlalchemy.Column("id", sqlalchemy.Integer, primary_key=True),
213+
sqlalchemy.Column("tag_id", sqlalchemy.String),
213214
sqlalchemy.Column("tag_name", sqlalchemy.String),
214215
sqlalchemy.Column("guidance", sqlalchemy.String),
215-
sqlalchemy.Column("ref_links", sqlalchemy.String),
216+
sqlalchemy.Column("ref_links", ARRAY(sqlalchemy.String)),
216217
)
217218

218-
Classification = sqlalchemy.Table(
219-
"classification",
219+
Summaries = sqlalchemy.Table(
220+
"summaries",
220221
metadata,
221222
sqlalchemy.Column("id", sqlalchemy.Integer, primary_key=True),
222-
sqlalchemy.Column("UNCLASSIFIED", sqlalchemy.String),
223+
sqlalchemy.Column("name", sqlalchemy.String),
224+
sqlalchemy.Column("count", sqlalchemy.Integer),
225+
sqlalchemy.Column("percentage", sqlalchemy.Float),
226+
sqlalchemy.Column("type", sqlalchemy.String),
223227
)
224228

225-
226229
async def insert():
227230

228231
# Establish DB connection

services/auto-scan/autoscan.py

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,9 +214,20 @@
214214
"guidance",
215215
metadata,
216216
sqlalchemy.Column("id", sqlalchemy.Integer, primary_key=True),
217+
sqlalchemy.Column("tag_id", sqlalchemy.String),
217218
sqlalchemy.Column("tag_name", sqlalchemy.String),
218219
sqlalchemy.Column("guidance", sqlalchemy.String),
219-
sqlalchemy.Column("ref_links", sqlalchemy.String),
220+
sqlalchemy.Column("ref_links", ARRAY(sqlalchemy.String)),
221+
)
222+
223+
Summaries = sqlalchemy.Table(
224+
"summaries",
225+
metadata,
226+
sqlalchemy.Column("id", sqlalchemy.Integer, primary_key=True),
227+
sqlalchemy.Column("name", sqlalchemy.String),
228+
sqlalchemy.Column("count", sqlalchemy.Integer),
229+
sqlalchemy.Column("percentage", sqlalchemy.Float),
230+
sqlalchemy.Column("type", sqlalchemy.String),
220231
)
221232

222233

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
"""Update guidance table
2+
3+
Revision ID: dc6adc4d8944
4+
Revises: 5f8c3a21331b
5+
Create Date: 2020-09-24 12:04:03.960057
6+
7+
"""
8+
from alembic import op
9+
import sqlalchemy as sa
10+
from sqlalchemy.dialects.postgresql import ARRAY
11+
12+
13+
# revision identifiers, used by Alembic.
14+
revision = 'dc6adc4d8944'
15+
down_revision = '5f8c3a21331b'
16+
branch_labels = None
17+
depends_on = None
18+
19+
20+
def upgrade():
21+
op.drop_table("classification")
22+
op.add_column(
23+
"guidance", sa.Column("tag_id", sa.String()),
24+
)
25+
op.alter_column("guidance", "ref_links", type_=ARRAY(sa.String()), postgresql_using='ref_links::character varying[]')
26+
27+
28+
def downgrade():
29+
op.create_table(
30+
"classification",
31+
sa.Column("id", sa.Integer(), primary_key=True),
32+
sa.Column("UNCLASSIFIED", sa.String()),
33+
)
34+
op.drop_column("guidance", "tag_id")
35+
op.alter_column("guidance", "ref_links", type_=sa.String())

services/db-migration/models/__init__.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -181,16 +181,10 @@
181181
"guidance",
182182
metadata,
183183
sqlalchemy.Column("id", sqlalchemy.Integer, primary_key=True),
184+
sqlalchemy.Column("tag_id", sqlalchemy.String),
184185
sqlalchemy.Column("tag_name", sqlalchemy.String),
185186
sqlalchemy.Column("guidance", sqlalchemy.String),
186-
sqlalchemy.Column("ref_links", sqlalchemy.String),
187-
)
188-
189-
Classification = sqlalchemy.Table(
190-
"classification",
191-
metadata,
192-
sqlalchemy.Column("id", sqlalchemy.Integer, primary_key=True),
193-
sqlalchemy.Column("UNCLASSIFIED", sqlalchemy.String),
187+
sqlalchemy.Column("ref_links", ARRAY(sqlalchemy.String)),
194188
)
195189

196190
Summaries = sqlalchemy.Table(

services/scanners/results/result_processor.py

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,9 +226,20 @@
226226
"guidance",
227227
metadata,
228228
sqlalchemy.Column("id", sqlalchemy.Integer, primary_key=True),
229+
sqlalchemy.Column("tag_id", sqlalchemy.String),
229230
sqlalchemy.Column("tag_name", sqlalchemy.String),
230231
sqlalchemy.Column("guidance", sqlalchemy.String),
231-
sqlalchemy.Column("ref_links", sqlalchemy.String),
232+
sqlalchemy.Column("ref_links", ARRAY(sqlalchemy.String)),
233+
)
234+
235+
Summaries = sqlalchemy.Table(
236+
"summaries",
237+
metadata,
238+
sqlalchemy.Column("id", sqlalchemy.Integer, primary_key=True),
239+
sqlalchemy.Column("name", sqlalchemy.String),
240+
sqlalchemy.Column("count", sqlalchemy.Integer),
241+
sqlalchemy.Column("percentage", sqlalchemy.Float),
242+
sqlalchemy.Column("type", sqlalchemy.String),
232243
)
233244

234245
logging.basicConfig(stream=sys.stdout, level=logging.INFO)

0 commit comments

Comments
 (0)