small correction suggested by lgtm

Author: AntSimi

examples/10_tracking_diagnostics/pet_center_count.py

@@ -40,9 +40,9 @@
 
 # Count pixel used for each center
 g_a = a.grid_count(bins, intern=True, center=True)
-m = g_a.display(ax_a, **kwargs_pcolormesh)
+g_a.display(ax_a, **kwargs_pcolormesh)
 g_c = c.grid_count(bins, intern=True, center=True)
-m = g_c.display(ax_c, **kwargs_pcolormesh)
+g_c.display(ax_c, **kwargs_pcolormesh)
 # Compute a ratio Cyclonic / Anticyclonic
 ratio = g_c.vars["count"] / g_a.vars["count"]
 

examples/10_tracking_diagnostics/pet_pixel_used.py

@@ -37,9 +37,9 @@
 
 # Count pixel used for each contour
 g_a = a.grid_count(bins, intern=True)
-m = g_a.display(ax_a, **kwargs_pcolormesh)
+g_a.display(ax_a, **kwargs_pcolormesh)
 g_c = c.grid_count(bins, intern=True)
-m = g_c.display(ax_c, **kwargs_pcolormesh)
+g_c.display(ax_c, **kwargs_pcolormesh)
 # Compute a ratio Cyclonic / Anticyclonic
 ratio = g_c.vars["count"] / g_a.vars["count"]
 

share/fig.py

@@ -48,8 +48,6 @@
         # 0.02, # step between two isolines of detection (m)
         pixel_limit=(5, 2000),  # Min and max of pixel can be include in contour
         shape_error=55,  # Error maximal of circle fitting over contour to be accepted
-        bbox_surface_min_degree=0.125
-        ** 2,  # degrees surface minimal to take in account contour
     )
     fig = plt.figure(figsize=(15, 7))
     ax = fig.add_axes([0.03, 0.03, 0.94, 0.94])

src/py_eddy_tracker/eddy_feature.py

@@ -91,7 +91,6 @@ def within_amplitude_limits(self):
         """Need update
         """
         return self.interval_min <= self.amplitude
-        return self.eddy.ampmin <= self.amplitude <= self.eddy.ampmax
 
     def all_pixels_below_h0(self, level):
         """

src/py_eddy_tracker/network.py

@@ -57,7 +57,6 @@ def get_wrap_vertice(x0, y0, x1, y1, i):
     x0_, x1_ = x0[i], x1[i]
     if abs(x0_[0] - x1_[0]) > 180:
         ref = x0_[0] - x0.dtype.type(180)
-        x1_ = x1[i]
         x1_ = (x1[i] - ref) % 360 + ref
     return create_vertice(x0_, y0[i]), create_vertice(x1_, y1[i])
 

src/py_eddy_tracker/observations/tracking.py

@@ -327,7 +327,7 @@ def __extract_with_mask(
             logger.warning(
                 "Incompatible option, remove_incomplete option will be remove"
             )
-            remove_incomplete = False
+            # remove_incomplete = False
 
         if full_path:
             if reject_virtual:

src/scripts/EddyTracking

@@ -15,7 +15,7 @@ from netCDF4 import Dataset
 from datetime import datetime
 from glob import glob
 import logging
-import datetime as dt
+
 
 logger = logging.getLogger("pet")
 
@@ -189,7 +189,7 @@ if __name__ == "__main__":
         DATASET_LIST = DATASET_LIST[:-BLANK_PERIOD]
         logger.info("Last %d files will be pop", BLANK_PERIOD)
 
-    START_TIME = dt.datetime.now()
+    START_TIME = datetime.now()
     logger.info("Start tracking on %d files", len(DATASET_LIST))
 
     NB_OBS_MIN = int(CONFIG.get("TRACK_DURATION_MIN", 14))
@@ -254,7 +254,7 @@ if __name__ == "__main__":
         SHORT_TRACK.filled_by_interpolation(SHORT_TRACK["virtual"] == 1)
 
     # Total running time
-    FULL_TIME = dt.datetime.now() - START_TIME
+    FULL_TIME = datetime.now() - START_TIME
     logger.info("Mean duration by loop : %s", FULL_TIME / (len(DATASET_LIST) - 1))
     logger.info("Duration : %s", FULL_TIME)