Skip to content

Commit 9b06a23

Browse files
committed
FIX: Make server request and websocket connection methods accessible/overrideable in parent.
1 parent 874001a commit 9b06a23

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

server/services/attachHttp/index.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ function attachHttpServer (server, onListening) {
1515
httpServer.on('listening', onListening)
1616

1717
const onHttpRequest = (req, res, opts = {}) => {
18+
if (res.headersSent) return
1819
opts.trustProxy = opts.trustProxy || server._trustProxy
1920

2021
let params
@@ -53,12 +54,8 @@ function attachHttpServer (server, onListening) {
5354
})
5455
}
5556

56-
const onRequest = (req, res) => {
57-
if (res.headersSent) return
58-
if (onHttpRequest) onHttpRequest(req, res)
59-
}
60-
61-
const setRequest = () => httpServer.on('request', onRequest)
57+
server.onHttpRequest = onHttpRequest
58+
const setRequest = () => httpServer.on('request', (...args) => server.onHttpRequest(...args))
6259

6360
// Add default http request handler on next tick to give user the chance to add
6461
// their own handler first. Handle requests untouched by user's handler.

server/services/attachWS/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ function setupWebSocketServer (server) {
5151
socket.onCloseBound = () => onWebSocketClose(socket)
5252
socket.on('close', socket.onCloseBound)
5353
}
54-
54+
server.onWebSocketConnection = onWebSocketConnection
5555
const onWebSocketRequest = (socket, opts, params) => {
5656
try {
5757
params = parseWebSocketRequest(socket, opts, params)
@@ -266,7 +266,7 @@ function setupWebSocketServer (server) {
266266
// Note: socket.upgradeReq was removed in [email protected], so re-add it.
267267
// https://github.com/websockets/ws/pull/1099
268268
socket.upgradeReq = req
269-
onWebSocketConnection(socket)
269+
server.onWebSocketConnection(socket)
270270
}
271271

272272
ws.address = () => server.http.address()

0 commit comments

Comments
 (0)