refactor code

Author: Ihor Khomiak

app/common/protocol.ts

@@ -8,5 +8,5 @@ export class Cost {
     quantity: number;
     type: string;
     changesDate: string;
-    isFavorite:boolean;
+    isFavorite: boolean;
 }

app/components/calendar/calendar.component.ts

@@ -15,10 +15,10 @@ export class CalendarComponent {
     public filteredCosts: Cost[] = new Array<Cost>();
     public allCosts: Cost[] = new Array<Cost>();
 
-    constructor(private costService:CostService){}
+    constructor(private costService: CostService){}
 
     ngOnInit() {
-        this.costService.costsListObservable.subscribe((costs) => {
+        this.costService.costs.subscribe((costs) => {
             this.allCosts = costs;
         });
     }

app/components/calendar/date-range-cost-list/calendar-date-range-cost-list.component.ts

@@ -11,7 +11,7 @@ import { Cost } from '../../../common/protocol';
 export class CalendarDateRangeCostListComponent {
 
     @Output() stateChanged = new EventEmitter();
-    @Input() filteredCosts:Array<Cost>;
+    @Input() filteredCosts: Array<Cost>;
 
     onTap(){
         this.stateChanged.next("");

app/components/calendar/date-range/calendar-date-range.component.ts

@@ -9,8 +9,8 @@ import { DatePicker } from 'ui/date-picker';
     styleUrls: ["./calendar-date-range.component.css"]
 })
 export class CalendarDateRangeComponent {
-    private _startDate:string;
-    private _endDate:string;
+    private _startDate: string;
+    private _endDate: string;
 
     @Output() stateChanged = new EventEmitter();
     @Output() sendDateChange = new EventEmitter();

app/components/cost/cost.service.ts

@@ -5,15 +5,15 @@ import { Cost } from '../../common/protocol';
 
 @Injectable()
 export class CostService {
-    private costsListSource: Rx.BehaviorSubject<Cost[]>;
-    private backing_costsListObservable: Rx.Observable<Cost[]>;
+    private _costsSource: Rx.BehaviorSubject<Cost[]>;
+    private _costs: Rx.Observable<Cost[]>;
 
     constructor() {
-        this.costsListSource = new Rx.BehaviorSubject<Cost[]>(this.costs);
-        this.backing_costsListObservable = this.costsListSource.asObservable();
+        this._costsSource = new Rx.BehaviorSubject<Cost[]>(this.costsCollection);
+        this._costs = this._costsSource.asObservable();
     }
 
-    private costs = new Array<Cost>(
+    private costsCollection = new Array<Cost>(
         { id: 0, quantity: 310, type: "Products", changesDate: "Jul 01 2017", isFavorite: false },
         { id: 1, quantity: 25, type: "Products", changesDate: "Aug 25 2017", isFavorite: false },
         { id: 2, quantity: 127, type: "ForHome", changesDate: "Aug 30 2017", isFavorite: false },
@@ -29,25 +29,25 @@ export class CostService {
         { id: 12, quantity: 78, type: "Products", changesDate: "April 04 2017", isFavorite: false }
     );
 
-    public get costsListObservable(): Rx.Observable<Cost[]> {
-        return this.backing_costsListObservable;
+    public get costs(): Rx.Observable<Cost[]> {
+        return this._costs;
     }
 
     getCost(id: number): Cost {
-        return this.costsListSource.getValue().filter(cost => cost.id === id)[0];
+        return this._costsSource.getValue().filter(cost => cost.id === id)[0];
     }
 
     addCost(newCost: Cost) {
-        let activeCosts = this.costsListSource.getValue();
+        let activeCosts = this._costsSource.getValue();
         activeCosts.unshift(newCost);
-        this.costsListSource.next(activeCosts);
+        this._costsSource.next(activeCosts);
     }
 
     deleteCost(costForDelete: Cost) {
-        let activeCosts = this.costsListSource.getValue();
+        let activeCosts = this._costsSource.getValue();
         var index = activeCosts.indexOf(costForDelete);
         activeCosts.splice(index, 1);
-        this.costsListSource.next(activeCosts);
+        this._costsSource.next(activeCosts);
 
         alert(costForDelete.quantity + " removed!");
     }

app/components/cost/costs.component.html

@@ -24,5 +24,5 @@
                (tap)="add()"
                class="list-header-button"></Label>
     </GridLayout>
-    <list [items]="costService.costsListObservable | async"></list>
+    <list [items]="costService.costs | async"></list>
 </StackLayout>

app/components/cost/costs.component.ts

@@ -19,7 +19,7 @@ export class CostsComponent implements OnInit {
     constructor(private router: RouterExtensions, private costService: CostService) { }
 
     ngOnInit(): void {
-        // this.costService.costsListObservable.subscribe((costs) => {
+        // this.costService.costs.subscribe((costs) => {
         //     if(costs) {
         //         this.costs = costs;
         //     }
@@ -35,7 +35,7 @@ export class CostsComponent implements OnInit {
             return;
         }
 
-        let cost:Cost = new Cost();
+        let cost: Cost = new Cost();
         cost.id = Math.random();
         cost.quantity = Number(textField.text);
         cost.type = "TestType";

app/components/cost/edit/cost-edit.component.ts

@@ -47,7 +47,7 @@ export class CostEditComponent implements OnInit {
         this.routerExtensions.back();
     }
 
-    private formatDateString(dateString:string):string {
+    private formatDateString(dateString: string): string {
         return (new Date(dateString)).toDateString().slice(4);
     }
 }

app/components/tabs/tabs.component.ts

@@ -8,12 +8,9 @@ import { SelectedIndexChangedEventData, TabView } from 'tns-core-modules/ui/tab-
     templateUrl: "./tabs.component.html",
     styleUrls: ["./tabs.component.css"]
 })
-export class TabsComponent implements OnInit {
+export class TabsComponent {
     private _title: string;
 
-    constructor() {}
-    ngOnInit(): void {}
-
     get title(): string {
         return this._title;
     }