From 4db0ae5cdf186eac41fd63949e08b8c8250f446c Mon Sep 17 00:00:00 2001
From: Gabriel <gabriel59kg@gmail.com>
Date: Wed, 25 Mar 2020 20:16:25 -0400
Subject: [PATCH 1/2] 404 test

---
 tests/test_routes.py | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/tests/test_routes.py b/tests/test_routes.py
index 7c4b1f03..b711fd99 100644
--- a/tests/test_routes.py
+++ b/tests/test_routes.py
@@ -120,21 +120,23 @@ def tearDown(self):
 
 
 @pytest.mark.parametrize(
-    "query_params",
+    "query_params,expected_status",
     [
-        {"source": "csbs"},
-        {"source": "jhu"},
-        {"timelines": True},
-        {"timelines": "true"},
-        {"timelines": 1},
-        {"source": "jhu", "timelines": True},
+        ({"source": "csbs"}, 200),
+        ({"source": "jhu"}, 200),
+        ({"timelines": True}, 200),
+        ({"timelines": "true"}, 200),
+        ({"timelines": 1}, 200),
+        ({"source": "jhu", "timelines": True}, 200),
+        ({"source": "csbs", "country_code": "US"}, 200),
+        ({"source": "jhu", "country_code": "US"}, 404)
     ],
 )
-def test_locations_status_code(api_client, query_params):
+def test_locations_status_code(api_client, query_params, expected_status):
     response = api_client.get("/v2/locations", params=query_params)
     print(f"GET {response.url}\n{response}")
-    assert response.status_code == 200
-
+    print(f"\tjson:\n{pf(response.json())[:1000]}\n\t...")
+    assert response.status_code == expected_status
 
 @pytest.mark.parametrize(
     "query_params",

From d46435150818ff0bca3007c1db9242488195ad19 Mon Sep 17 00:00:00 2001
From: Gabriel <gabriel59kg@gmail.com>
Date: Wed, 25 Mar 2020 22:25:15 -0400
Subject: [PATCH 2/2] 404 for missing location data

---
 app/router/locations.py | 4 +++-
 tests/test_routes.py    | 3 ++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/app/router/locations.py b/app/router/locations.py
index d0e03c46..af4b1cfd 100644
--- a/app/router/locations.py
+++ b/app/router/locations.py
@@ -1,4 +1,4 @@
-from fastapi import Request
+from fastapi import HTTPException, Request
 
 from ..enums.sources import Sources
 from ..models.location import LocationResponse as Location
@@ -39,6 +39,8 @@ def get_locations(
             locations = [location for location in locations if str(getattr(location, key)).lower() == str(value)]
         except AttributeError:
             pass
+        if not locations:
+            raise HTTPException(404, detail=f"Source `{source}` does not have the desired location data.")
 
     # Return final serialized data.
     return {
diff --git a/tests/test_routes.py b/tests/test_routes.py
index b711fd99..9e1c03ef 100644
--- a/tests/test_routes.py
+++ b/tests/test_routes.py
@@ -129,7 +129,7 @@ def tearDown(self):
         ({"timelines": 1}, 200),
         ({"source": "jhu", "timelines": True}, 200),
         ({"source": "csbs", "country_code": "US"}, 200),
-        ({"source": "jhu", "country_code": "US"}, 404)
+        ({"source": "jhu", "country_code": "US"}, 404),
     ],
 )
 def test_locations_status_code(api_client, query_params, expected_status):
@@ -138,6 +138,7 @@ def test_locations_status_code(api_client, query_params, expected_status):
     print(f"\tjson:\n{pf(response.json())[:1000]}\n\t...")
     assert response.status_code == expected_status
 
+
 @pytest.mark.parametrize(
     "query_params",
     [