Skip to content

Commit 8751f7e

Browse files
authored
Merge pull request #1 from ExpDev07/master
updating forked version
2 parents b12ba72 + 2b2fc19 commit 8751f7e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+901
-445
lines changed

.all-contributorsrc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,15 @@
153153
"contributions": [
154154
"code"
155155
]
156+
},
157+
{
158+
"login": "ibhuiyan17",
159+
"name": "Ibtida Bhuiyan",
160+
"avatar_url": "https://avatars1.githubusercontent.com/u/33792969?v=4",
161+
"profile": "http://ibtida.me",
162+
"contributions": [
163+
"code"
164+
]
156165
}
157166
],
158167
"contributorsPerLine": 7,

.gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,4 +66,7 @@ docs/_build/
6666
target/
6767

6868
# OSX Stuff
69-
.DS_Store
69+
.DS_Store
70+
71+
# IntelliJ/Pycharm
72+
.idea/

.travis.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,8 @@ install:
77
- "pip install pipenv"
88
- "pipenv install --dev --skip-lock"
99
script:
10-
- "make test lint check-fmt"
10+
- "make test"
11+
- "make lint"
12+
- "make check-fmt"
13+
after_success:
14+
- coveralls

CONTRIBUTING.md

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
# Contribution to Coronavirus Tracker API
2+
3+
First off, thanks for taking the time to contribute!
4+
Every commit supports the open source ecosystem in case of [COVID-19](https://en.wikipedia.org/wiki/2019%E2%80%9320_coronavirus_pandemic).
5+
6+
## Testing
7+
8+
We have a handful of unit tests to cover most of functions.
9+
Please write new test cases for new code you create.
10+
11+
## Submitting changes
12+
13+
* If you're unable to find an open issue, [open a new one](https://github.com/ExpDev07/coronavirus-tracker-api/issues/new). Be sure to include a **title and clear description**, as much relevant information as possible
14+
* Open a new [GitHub Pull Request to coronavirus-tracker-api](https://github.com/ExpDev07/coronavirus-tracker-api/pulls) with a clear list of what you've done (read more about [pull requests](http://help.github.com/pull-requests/)). Include the relevant issue number if applicable.
15+
* We will love you forever if you include unit tests. We can always use more test coverage
16+
17+
## Your First Code Contribution
18+
19+
Unsure where to begin contributing to coronavirus-tracker-api ? You can start by looking through these issues labels:
20+
21+
* [Enhancement issues](https://github.com/ExpDev07/coronavirus-tracker-api/labels/enhancement) - issues for new feature or request
22+
* [Help wanted issues](https://github.com/ExpDev07/coronavirus-tracker-api/labels/help%20wanted) - extra attention is needed
23+
* [Documentation issues](https://github.com/ExpDev07/coronavirus-tracker-api/labels/documentation) - improvements or additions to documentation
24+
25+
## Styleguide
26+
27+
Please follow [PEP8](https://www.python.org/dev/peps/pep-0008/) guide.
28+
See [Running Test](./README.md#running-tests), [Linting](./README.md#linting) and [Formatting](./README.md#formatting) sections for further instructions to validate your change.
29+
30+
31+
We encourage you to pitch in and join the [Coronavirus Tracker API Team](https://github.com/ExpDev07/coronavirus-tracker-api#contributors-)!
32+
33+
Thanks! :heart: :heart: :heart:
34+
35+
[Coronavirus Tracker API Team](https://github.com/ExpDev07/coronavirus-tracker-api#contributors-)

Makefile

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,12 @@ APP = app
1515
TEST = tests
1616

1717
test:
18-
$(PYTHON) `which py.test` -s -v $(TEST)
19-
18+
pytest -v $(TEST) --cov-report term --cov-report xml --cov=$(APP)
2019
lint:
21-
pylint $(APP) || true
20+
pylint $(APP)
2221

2322
fmt:
24-
isort --apply --atomic
25-
black . -l 120
23+
invoke fmt
2624

2725
check-fmt:
28-
isort -rc --check
29-
black . --check --diff
26+
invoke check --fmt --sort

Pipfile

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,31 @@ url = "https://pypi.org/simple"
44
verify_ssl = true
55

66
[dev-packages]
7+
async-asgi-testclient = "*"
8+
async_generator = "*"
9+
asyncmock = "*"
710
bandit = "*"
811
black = "==19.10b0"
12+
coveralls = "*"
13+
importlib-metadata = {version="*", markers="python_version<'3.8'"}
14+
invoke = "*"
915
isort = "*"
10-
pytest = "*"
1116
pylint = "*"
17+
pytest = "*"
18+
pytest-asyncio = "*"
19+
pytest-cov = "*"
1220

1321
[packages]
22+
aiohttp = "*"
23+
asyncache = "*"
24+
cachetools = "*"
25+
dataclasses = {version="*", markers="python_version<'3.7'"}
1426
fastapi = "*"
15-
flask = "*"
16-
python-dotenv = "*"
17-
requests = "*"
1827
gunicorn = "*"
19-
flask-cors = "*"
20-
cachetools = "*"
28+
idna_ssl = {version="*", markers="python_version<'3.7'"}
2129
python-dateutil = "*"
30+
python-dotenv = "*"
31+
requests = "*"
2232
uvicorn = "*"
2333

2434
[requires]
@@ -27,5 +37,7 @@ python_version = "3.8"
2737
[scripts]
2838
dev = "uvicorn app.main:APP --reload"
2939
start = "uvicorn app.main:APP"
30-
fmt = "black . -l 120"
31-
sort = "isort --apply --atomic"
40+
fmt = "invoke fmt"
41+
sort = "invoke sort"
42+
lint = "invoke lint"
43+
test = "invoke test"

0 commit comments

Comments
 (0)