Skip to content

Commit fd9a0a4

Browse files
authored
fix: Do not include concluded WGs in /list/nonwg. Fixes ietf-tools#3726. (ietf-tools#3727)
1 parent 3d529ba commit fd9a0a4

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

ietf/mailinglists/tests.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,13 @@ def test_groups(self):
3232

3333

3434
def test_nonwg(self):
35+
groups = list()
36+
groups.append(GroupFactory(type_id='wg', acronym='mars', list_archive='https://ietf.org/mars'))
37+
groups.append(GroupFactory(type_id='wg', acronym='ames', state_id='conclude', list_archive='https://ietf.org/ames'))
38+
groups.append(GroupFactory(type_id='wg', acronym='newstuff', state_id='bof', list_archive='https://ietf.org/newstuff'))
39+
groups.append(GroupFactory(type_id='rg', acronym='research', list_archive='https://irtf.org/research'))
3540
lists = ListFactory.create_batch(7)
41+
3642
url = urlreverse("ietf.mailinglists.views.nonwg")
3743

3844
r = self.client.get(url)
@@ -43,3 +49,6 @@ def test_nonwg(self):
4349
else:
4450
self.assertNotContains(r, l.name, html=True)
4551
self.assertNotContains(r, l.description, html=True)
52+
53+
for g in groups:
54+
self.assertNotContains(r, g.acronym, html=True)

ietf/mailinglists/views.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright The IETF Trust 2007, All Rights Reserved
1+
# Copyright The IETF Trust 2007-2022, All Rights Reserved
22

33
import re
44

@@ -15,7 +15,7 @@ def groups(request):
1515
return render(request, "mailinglists/group_archives.html", { "groups": groups } )
1616

1717
def nonwg(request):
18-
groups = Group.objects.filter(type__features__acts_like_wg=True).exclude(state__in=['bof', 'conclude']).order_by("acronym")
18+
groups = Group.objects.filter(type__features__acts_like_wg=True).exclude(state__in=['bof']).order_by("acronym")
1919

2020
#urls = [ g.list_archive for g in groups if '.ietf.org' in g.list_archive ]
2121

0 commit comments

Comments
 (0)