Skip to content

Commit fce28e7

Browse files
authored
fix: case sensitivity for Subscribed.email (ietf-tools#5270)
1 parent 963b1bd commit fce28e7

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

ietf/ietfauth/views.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,8 @@ def create_account(request):
125125
send_account_creation_email(request, to_email)
126126

127127
# The following is what to revert to should that lowered barrier prove problematic
128-
# existing = Subscribed.objects.filter(email=to_email).first()
129-
# ok_to_create = ( Allowlisted.objects.filter(email=to_email).exists()
128+
# existing = Subscribed.objects.filter(email__iexact=to_email).first()
129+
# ok_to_create = ( Allowlisted.objects.filter(email__iexact=to_email).exists()
130130
# or existing and (existing.time + TimeDelta(seconds=settings.LIST_ACCOUNT_DELAY)) < DateTime.now() )
131131
# if ok_to_create:
132132
# send_account_creation_email(request, to_email)

ietf/mailinglists/management/commands/import_mailman_listinfo.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def log_time(msg):
7777
to_add = members - known
7878
for addr in to_remove:
7979
note(" Removing subscription: %s" % (addr))
80-
old = Subscribed.objects.get(email=addr)
80+
old = Subscribed.objects.get(email=addr) # Intentionally leaving this as case-sensitive in postgres
8181
old.lists.remove(mmlist)
8282
if old.lists.count() == 0:
8383
note(" Removing address with no subscriptions: %s" % (addr))
@@ -90,7 +90,7 @@ def log_time(msg):
9090
continue
9191
note(" Adding subscription: %s" % (addr))
9292
try:
93-
new, created = Subscribed.objects.get_or_create(email=addr)
93+
new, created = Subscribed.objects.get_or_create(email=addr) # Intentionally leaving this as case-sensitive in postgres
9494
except MultipleObjectsReturned as e:
9595
sys.stderr.write(" ** Error handling %s in %s: %s\n" % (addr, name, e))
9696
continue

0 commit comments

Comments
 (0)