Skip to content

Commit c56cbf6

Browse files
committed
Improved test coverage over meeting.views. Commit ready for merge.
- Legacy-Id: 14854
1 parent 02d975a commit c56cbf6

2 files changed

Lines changed: 35 additions & 2 deletions

File tree

ietf/meeting/tests_views.py

Lines changed: 33 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
from ietf.meeting.helpers import send_interim_approval_request
2626
from ietf.meeting.helpers import send_interim_cancellation_notice
2727
from ietf.meeting.helpers import send_interim_minutes_reminder, populate_important_dates
28-
from ietf.meeting.models import Session, TimeSlot, Meeting, SchedTimeSessAssignment
28+
from ietf.meeting.models import Session, TimeSlot, Meeting, SchedTimeSessAssignment, Schedule
2929
from ietf.meeting.test_data import make_meeting_test_data, make_interim_meeting
3030
from ietf.meeting.utils import finalize
31-
from ietf.name.models import SessionStatusName
31+
from ietf.name.models import SessionStatusName
3232
from ietf.utils.test_utils import TestCase, login_testing_unauthorized, unicontent
3333
from ietf.utils.mail import outbox
3434
from ietf.utils.text import xslugify
@@ -489,6 +489,37 @@ def test_session_draft_pdf(self):
489489
self.assertEqual(response.get('Content-Type'), 'application/pdf')
490490
os.unlink(filename)
491491

492+
def test_current_materials(self):
493+
url = urlreverse('ietf.meeting.views.current_materials')
494+
response = self.client.get(url)
495+
self.assertEqual(response.status_code, 404)
496+
MeetingFactory(type_id='ietf')
497+
response = self.client.get(url)
498+
self.assertEqual(response.status_code, 302)
499+
500+
def test_edit_agenda_properties(self):
501+
self.client.login(username='secretary',password='secretary+password')
502+
url = urlreverse('ietf.meeting.views.edit_agenda_properties',kwargs={'owner':'does@notexist.example','name':'doesnotexist','num':00})
503+
response = self.client.get(url)
504+
self.assertEqual(response.status_code,404)
505+
self.client.logout()
506+
schedule = ScheduleFactory(meeting__type_id='ietf',visible=False,public=False)
507+
url = urlreverse('ietf.meeting.views.edit_agenda_properties',kwargs={'owner':schedule.owner.email(),'name':schedule.name,'num':schedule.meeting.number})
508+
response = self.client.get(url)
509+
self.assertEqual(response.status_code,302)
510+
self.client.login(username='secretary',password='secretary+password')
511+
response = self.client.get(url)
512+
self.assertEqual(response.status_code,200)
513+
response = self.client.post(url, {
514+
'name':schedule.name,
515+
'visible':True,
516+
'public':True,
517+
}
518+
)
519+
self.assertEqual(response.status_code,302)
520+
schedule = Schedule.objects.get(pk=schedule.pk)
521+
self.assertTrue(schedule.visible)
522+
self.assertTrue(schedule.public)
492523

493524
class EditTests(TestCase):
494525
def setUp(self):

ietf/meeting/views.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -365,6 +365,8 @@ def edit_agenda(request, num=None, owner=None, name=None):
365365
#
366366
AgendaPropertiesForm = modelform_factory(Schedule, fields=('name','visible', 'public'))
367367

368+
# The meeing urls.py won't allow empy num, owmer, or name values
369+
368370
@role_required('Area Director','Secretariat')
369371
def edit_agenda_properties(request, num=None, owner=None, name=None):
370372
meeting = get_meeting(num)

0 commit comments

Comments
 (0)