Skip to content

Commit bb8cf21

Browse files
richsalzNGPixelrjsparks
authored
fix: show nomcoms by convening year only (ietf-tools#6585)
* ci: Update build-base-app.yml workflow * fix: Relabel NomCom to show start year, not range Show just the year that a NomCom started, because showing the start/end years is confusing. Fixes: ietf-tools#3419 * fix: Shwo Nomcoms year convened only Fix the main nomcom index page and the announcement archive page --------- Co-authored-by: Nicolas Giard <github@ngpixel.com> Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
1 parent 35bec48 commit bb8cf21

5 files changed

Lines changed: 26 additions & 25 deletions

File tree

.github/workflows/build-base-app.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ on:
66
- 'main'
77
paths:
88
- 'docker/base.Dockerfile'
9+
- 'requirements.txt'
910

1011
workflow_dispatch:
1112

ietf/nomcom/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def index(request):
5757
for nomcom in nomcom_list:
5858
year = int(nomcom.acronym[6:])
5959
nomcom.year = year
60-
nomcom.label = "%s/%s" % (year, year+1)
60+
nomcom.label = str(year)
6161
if year > 2012:
6262
nomcom.url = "/nomcom/%04d" % year
6363
else:

ietf/templates/nomcom/announcements.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ <h1>NomCom</h1>
1515
</p>
1616
{% for regime in regimes %}
1717
<h2 class="mt-5" id="nomcom-{{ regime.group.start_year }}">
18-
Messages from {{ regime.group.start_year }}/{{ regime.group.end_year }}
18+
Messages from {{ regime.group.start_year }} NomCom
1919
</h2>
2020
{# use person email address here rather than the generic nomcom-chair@ietf.org #}
2121
<p>

ietf/templates/nomcom/history.html

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ <h1>NomCom Membership History</h1>
1111
<b>Note:</b> The data for concluded NomComs is occasionally incorrect.
1212
</p>
1313
{% for regime in regimes %}
14-
<h2 class="mt-5" id="y{{ regime.year }}">{{ regime.label }}</h2>
14+
<h2 class="mt-5" id="y{{ regime.year }}">{{ regime.year }} NomCom</h2>
1515
<dl class="row">
1616
{% for slug, label, roles in regime.nomcom.personnel %}
1717
<dt class="col-sm-2">
@@ -25,7 +25,7 @@ <h2 class="mt-5" id="y{{ regime.year }}">{{ regime.label }}</h2>
2525
{% endfor %}
2626
</dl>
2727
{% endfor %}
28-
<h2 class="mt-5" id="y2012">2012/2013</h2>
28+
<h2 class="mt-5" id="y2012">2012 NomCom</h2>
2929
<dl class="row">
3030
<dt class="col-sm-2">
3131
Chair
@@ -64,7 +64,7 @@ <h2 class="mt-5" id="y2012">2012/2013</h2>
6464
Rudi Vansnick <span class="text-body-secondary">(ISOC Liaison)</span>
6565
</dd>
6666
</dl>
67-
<h2 class="mt-5" id="y2011">2011/2012</h2>
67+
<h2 class="mt-5" id="y2011">2011 NomCom</h2>
6868
<dl class="row">
6969
<dt class="col-sm-2">
7070
Chair
@@ -104,7 +104,7 @@ <h2 class="mt-5" id="y2011">2011/2012</h2>
104104
Jason Livingood <span class="text-body-secondary">(ISOC Liaison)</span>
105105
</dd>
106106
</dl>
107-
<h2 class="mt-5" id="y2010">2010/2011</h2>
107+
<h2 class="mt-5" id="y2010">2010 NomCom</h2>
108108
<dl class="row">
109109
<dt class="col-sm-2">
110110
Chair
@@ -143,7 +143,7 @@ <h2 class="mt-5" id="y2010">2010/2011</h2>
143143
Eric Burger <span class="text-body-secondary">(ISOC Liaison)</span>
144144
</dd>
145145
</dl>
146-
<h2 class="mt-5" id="y2009">2009/2010</h2>
146+
<h2 class="mt-5" id="y2009">2009 NomCom</h2>
147147
<dl class="row">
148148
<dt class="col-sm-2">
149149
Chair
@@ -184,7 +184,7 @@ <h2 class="mt-5" id="y2009">2009/2010</h2>
184184
</dd>
185185
</dl>
186186
<h2 class="mt-5" id="y2008">
187-
2008/2009
187+
2008 NomCom
188188
</h2>
189189
<dl class="row">
190190
<dt class="col-sm-2">
@@ -224,7 +224,7 @@ <h2 class="mt-5" id="y2008">
224224
</dd>
225225
</dl>
226226
<h2 class="mt-5" id="y2007">
227-
2007/2008
227+
2007 NomCom
228228
</h2>
229229
<dl class="row">
230230
<dt class="col-sm-2">
@@ -264,7 +264,7 @@ <h2 class="mt-5" id="y2007">
264264
</dd>
265265
</dl>
266266
<h2 class="mt-5" id="y2006">
267-
2006/2007
267+
2006 NomCom
268268
</h2>
269269
<dl class="row">
270270
<dt class="col-sm-2">
@@ -304,7 +304,7 @@ <h2 class="mt-5" id="y2006">
304304
</dd>
305305
</dl>
306306
<h2 class="mt-5" id="y2005">
307-
2005/2006
307+
2005 NomCom
308308
</h2>
309309
<dl class="row">
310310
<dt class="col-sm-2">
@@ -344,7 +344,7 @@ <h2 class="mt-5" id="y2005">
344344
</dd>
345345
</dl>
346346
<h2 class="mt-5" id="y2004">
347-
2004/2005
347+
2004 NomCom
348348
</h2>
349349
<dl class="row">
350350
<dt class="col-sm-2">
@@ -385,7 +385,7 @@ <h2 class="mt-5" id="y2004">
385385
</dd>
386386
</dl>
387387
<h2 class="mt-5" id="y2003">
388-
2003/2004
388+
2003 NomCom
389389
</h2>
390390
<dl class="row">
391391
<dt class="col-sm-2">
@@ -424,7 +424,7 @@ <h2 class="mt-5" id="y2003">
424424
</dd>
425425
</dl>
426426
<h2 class="mt-5" id="y2002">
427-
2002/2003
427+
2002 NomCom
428428
</h2>
429429
<dl class="row">
430430
<dt class="col-sm-2">
@@ -463,7 +463,7 @@ <h2 class="mt-5" id="y2002">
463463
</dd>
464464
</dl>
465465
<h2 class="mt-5" id="y2001">
466-
2001/2002
466+
2001 NomCom
467467
</h2>
468468
<dl class="row">
469469
<dt class="col-sm-2">
@@ -502,7 +502,7 @@ <h2 class="mt-5" id="y2001">
502502
</dd>
503503
</dl>
504504
<h2 class="mt-5" id="y2000">
505-
2000/2001
505+
2000 NomCom
506506
</h2>
507507
<dl class="row">
508508
<dt class="col-sm-2">
@@ -541,7 +541,7 @@ <h2 class="mt-5" id="y2000">
541541
</dd>
542542
</dl>
543543
<h2 class="mt-5" id="y1999">
544-
1999/2000
544+
1999 NomCom
545545
</h2>
546546
<dl class="row">
547547
<dt class="col-sm-2">
@@ -580,7 +580,7 @@ <h2 class="mt-5" id="y1999">
580580
</dd>
581581
</dl>
582582
<h2 class="mt-5" id="y1998">
583-
1998/1999
583+
1998 NomCom
584584
</h2>
585585
<dl class="row">
586586
<dt class="col-sm-2">
@@ -620,7 +620,7 @@ <h2 class="mt-5" id="y1998">
620620
</dd>
621621
</dl>
622622
<h2 class="mt-5" id="y1997">
623-
1997/1998
623+
1997 NomCom
624624
</h2>
625625
<dl class="row">
626626
<dt class="col-sm-2">
@@ -659,7 +659,7 @@ <h2 class="mt-5" id="y1997">
659659
</dd>
660660
</dl>
661661
<h2 class="mt-5" id="y1996">
662-
1996/1997
662+
1996 NomCom
663663
</h2>
664664
<dl class="row">
665665
<dt class="col-sm-2">
@@ -700,7 +700,7 @@ <h2 class="mt-5" id="y1996">
700700
</dd>
701701
</dl>
702702
<h2 class="mt-5" id="y1995">
703-
1995/1996
703+
1995 NomCom
704704
</h2>
705705
<dl class="row">
706706
<dt class="col-sm-2">
@@ -739,7 +739,7 @@ <h2 class="mt-5" id="y1995">
739739
</dd>
740740
</dl>
741741
<h2 class="mt-5" id="y1994">
742-
1994/1995
742+
1994 NomCom
743743
</h2>
744744
<dl class="row">
745745
<dt class="col-sm-2">
@@ -771,7 +771,7 @@ <h2 class="mt-5" id="y1994">
771771
</dd>
772772
</dl>
773773
<h2 class="mt-5" id="y1993">
774-
1993/1994
774+
1993 NomCom
775775
</h2>
776776
<dl class="row">
777777
<dt class="col-sm-2">
@@ -802,7 +802,7 @@ <h2 class="mt-5" id="y1993">
802802
</dd>
803803
</dl>
804804
<h2 class="mt-5" id="y1992">
805-
1992/1993
805+
1992 NomCom
806806
</h2>
807807
<dl class="row">
808808
<dt class="col-sm-2">

ietf/templates/nomcom/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ <h1>NomComs</h1>
1212
<table class="table table-sm table-striped tablesorter">
1313
<thead>
1414
<tr>
15-
<th scope="col" data-sort="year">Year</th>
15+
<th scope="col" data-sort="year">Year Convened</th>
1616
<th scope="col" data-sort="chair">Chair</th>
1717
<th scope="col"></th>
1818
</tr>

0 commit comments

Comments
 (0)