Skip to content

Commit a867de2

Browse files
test: Remove setup that does not apply to rfc docs (ietf-tools#6082)
* test: Remove setup that does not apply to rfc docs * style: Run black on test_document_bibtex()
1 parent a0f6201 commit a867de2

1 file changed

Lines changed: 54 additions & 45 deletions

File tree

ietf/doc/tests.py

Lines changed: 54 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1921,75 +1921,84 @@ def _parse_bibtex_response(self, response) -> dict:
19211921
@override_settings(RFC_EDITOR_INFO_BASE_URL='https://www.rfc-editor.ietf.org/info/')
19221922
def test_document_bibtex(self):
19231923
rfc = WgRfcFactory.create(
1924-
#other_aliases = ['rfc6020',],
1925-
states = [('draft','rfc'),('draft-iesg','pub')],
1926-
std_level_id = 'ps',
1927-
time = datetime.datetime(2010, 10, 10, tzinfo=ZoneInfo(settings.TIME_ZONE)),
1928-
)
1924+
time=datetime.datetime(2010, 10, 10, tzinfo=ZoneInfo(settings.TIME_ZONE))
1925+
)
19291926
num = rfc.rfc_number
19301927
DocEventFactory.create(
19311928
doc=rfc,
1932-
type='published_rfc',
1929+
type="published_rfc",
19331930
time=datetime.datetime(2010, 10, 10, tzinfo=RPC_TZINFO),
19341931
)
19351932
#
1936-
url = urlreverse('ietf.doc.views_doc.document_bibtex', kwargs=dict(name=rfc.name))
1933+
url = urlreverse("ietf.doc.views_doc.document_bibtex", kwargs=dict(name=rfc.name))
19371934
r = self.client.get(url)
1938-
entry = self._parse_bibtex_response(r)["rfc%s"%num]
1939-
self.assertEqual(entry['series'], 'Request for Comments')
1940-
self.assertEqual(int(entry['number']), num)
1941-
self.assertEqual(entry['doi'], '10.17487/RFC%s'%num)
1942-
self.assertEqual(entry['year'], '2010')
1943-
self.assertEqual(entry['month'].lower()[0:3], 'oct')
1944-
self.assertEqual(entry['url'], f'https://www.rfc-editor.ietf.org/info/rfc{num}')
1935+
entry = self._parse_bibtex_response(r)["rfc%s" % num]
1936+
self.assertEqual(entry["series"], "Request for Comments")
1937+
self.assertEqual(int(entry["number"]), num)
1938+
self.assertEqual(entry["doi"], "10.17487/RFC%s" % num)
1939+
self.assertEqual(entry["year"], "2010")
1940+
self.assertEqual(entry["month"].lower()[0:3], "oct")
1941+
self.assertEqual(entry["url"], f"https://www.rfc-editor.ietf.org/info/rfc{num}")
19451942
#
1946-
self.assertNotIn('day', entry)
1947-
1943+
self.assertNotIn("day", entry)
1944+
19481945
# test for incorrect case - revision for RFC
19491946
rfc = WgRfcFactory(name="rfc0000")
1950-
url = urlreverse('ietf.doc.views_doc.document_bibtex', kwargs=dict(name=rfc.name, rev='00'))
1947+
url = urlreverse(
1948+
"ietf.doc.views_doc.document_bibtex", kwargs=dict(name=rfc.name, rev="00")
1949+
)
19511950
r = self.client.get(url)
19521951
self.assertEqual(r.status_code, 404)
1953-
1952+
19541953
april1 = IndividualRfcFactory.create(
1955-
stream_id = 'ise',
1956-
states = [('draft','rfc'),('draft-iesg','pub')],
1957-
std_level_id = 'inf',
1958-
time = datetime.datetime(1990, 4, 1, tzinfo=ZoneInfo(settings.TIME_ZONE)),
1959-
)
1954+
stream_id="ise",
1955+
std_level_id="inf",
1956+
time=datetime.datetime(1990, 4, 1, tzinfo=ZoneInfo(settings.TIME_ZONE)),
1957+
)
19601958
num = april1.rfc_number
19611959
DocEventFactory.create(
19621960
doc=april1,
1963-
type='published_rfc',
1961+
type="published_rfc",
19641962
time=datetime.datetime(1990, 4, 1, tzinfo=RPC_TZINFO),
19651963
)
19661964
#
1967-
url = urlreverse('ietf.doc.views_doc.document_bibtex', kwargs=dict(name=april1.name))
1965+
url = urlreverse(
1966+
"ietf.doc.views_doc.document_bibtex", kwargs=dict(name=april1.name)
1967+
)
19681968
r = self.client.get(url)
1969-
self.assertEqual(r.get('Content-Type'), 'text/plain; charset=utf-8')
1970-
entry = self._parse_bibtex_response(r)["rfc%s"%num]
1971-
self.assertEqual(entry['series'], 'Request for Comments')
1972-
self.assertEqual(int(entry['number']), num)
1973-
self.assertEqual(entry['doi'], '10.17487/RFC%s'%num)
1974-
self.assertEqual(entry['year'], '1990')
1975-
self.assertEqual(entry['month'].lower()[0:3], 'apr')
1976-
self.assertEqual(entry['day'], '1')
1977-
self.assertEqual(entry['url'], f'https://www.rfc-editor.ietf.org/info/rfc{num}')
1978-
1969+
self.assertEqual(r.get("Content-Type"), "text/plain; charset=utf-8")
1970+
entry = self._parse_bibtex_response(r)["rfc%s" % num]
1971+
self.assertEqual(entry["series"], "Request for Comments")
1972+
self.assertEqual(int(entry["number"]), num)
1973+
self.assertEqual(entry["doi"], "10.17487/RFC%s" % num)
1974+
self.assertEqual(entry["year"], "1990")
1975+
self.assertEqual(entry["month"].lower()[0:3], "apr")
1976+
self.assertEqual(entry["day"], "1")
1977+
self.assertEqual(entry["url"], f"https://www.rfc-editor.ietf.org/info/rfc{num}")
1978+
19791979
draft = IndividualDraftFactory.create()
1980-
docname = '%s-%s' % (draft.name, draft.rev)
1981-
bibname = docname[6:] # drop the 'draft-' prefix
1982-
url = urlreverse('ietf.doc.views_doc.document_bibtex', kwargs=dict(name=draft.name))
1980+
docname = "%s-%s" % (draft.name, draft.rev)
1981+
bibname = docname[6:] # drop the 'draft-' prefix
1982+
url = urlreverse("ietf.doc.views_doc.document_bibtex", kwargs=dict(name=draft.name))
19831983
r = self.client.get(url)
19841984
entry = self._parse_bibtex_response(r)[bibname]
1985-
self.assertEqual(entry['note'], 'Work in Progress')
1986-
self.assertEqual(entry['number'], docname)
1987-
self.assertEqual(entry['year'], str(draft.pub_date().year))
1988-
self.assertEqual(entry['month'].lower()[0:3], draft.pub_date().strftime('%b').lower())
1989-
self.assertEqual(entry['day'], str(draft.pub_date().day))
1990-
self.assertEqual(entry['url'], settings.IDTRACKER_BASE_URL + urlreverse("ietf.doc.views_doc.document_main", kwargs=dict(name=draft.name, rev=draft.rev)))
1985+
self.assertEqual(entry["note"], "Work in Progress")
1986+
self.assertEqual(entry["number"], docname)
1987+
self.assertEqual(entry["year"], str(draft.pub_date().year))
1988+
self.assertEqual(
1989+
entry["month"].lower()[0:3], draft.pub_date().strftime("%b").lower()
1990+
)
1991+
self.assertEqual(entry["day"], str(draft.pub_date().day))
1992+
self.assertEqual(
1993+
entry["url"],
1994+
settings.IDTRACKER_BASE_URL
1995+
+ urlreverse(
1996+
"ietf.doc.views_doc.document_main",
1997+
kwargs=dict(name=draft.name, rev=draft.rev),
1998+
),
1999+
)
19912000
#
1992-
self.assertNotIn('doi', entry)
2001+
self.assertNotIn("doi", entry)
19932002

19942003
def test_document_bibxml(self):
19952004
draft = IndividualDraftFactory.create()

0 commit comments

Comments
 (0)