Skip to content

Commit 8e439df

Browse files
authored
fix: HTML-escape person name in tests (ietf-tools#5986)
* fix: Add `mark_safe` to `person_link` to prevent HTML escaping Fixes part of ietf-tools#5834, namely ietf-tools#5834 (comment) * fix: Fix tests instead of marking name safe
1 parent a1a88c5 commit 8e439df

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

ietf/group/tests_review.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def test_review_requests(self):
4141
r = self.client.get(url)
4242
self.assertEqual(r.status_code, 200)
4343
self.assertContains(r, review_req.doc.name)
44-
self.assertContains(r, assignment.reviewer.person.name)
44+
self.assertContains(r, escape(assignment.reviewer.person.name))
4545

4646
url = urlreverse(ietf.group.views.review_requests, kwargs={ 'acronym': group.acronym })
4747

@@ -183,7 +183,7 @@ def test_reviewer_overview(self):
183183
urlreverse(ietf.group.views.reviewer_overview, kwargs={ 'acronym': group.acronym, 'group_type': group.type_id })]:
184184
r = self.client.get(url)
185185
self.assertEqual(r.status_code, 200)
186-
self.assertContains(r, reviewer.name)
186+
self.assertContains(r, escape(reviewer.name))
187187
self.assertContains(r, review_req1.doc.name)
188188
# without a login, reason for being unavailable should not be seen
189189
self.assertNotContains(r, "Availability")

0 commit comments

Comments
 (0)