Skip to content

Commit 5ac3874

Browse files
authored
fix: Format NomCom feedback table per suggestion of @richsalz (ietf-tools#4625)
Also makes table header alignment the same as for columns, site-wide. Fixes ietf-tools#4529
1 parent 26e2e23 commit 5ac3874

2 files changed

Lines changed: 6 additions & 9 deletions

File tree

ietf/static/js/list.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,9 @@ $(document)
8686
$(header_row)
8787
.children("[data-sort]")
8888
.addClass("sort");
89-
// $(header_row)
90-
// .children("th, td")
91-
// .wrapInner('<span class="tablesorter-th"></span>');
92-
// // .each((i, e) => field_magic(i, e, fields));
89+
$(header_row)
90+
.children("th, td")
91+
.each((i, e) => field_magic(i, e, fields));
9392

9493
if ($(header_row)
9594
.text()

ietf/templates/nomcom/private_index.html

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
{% block nomcom_content %}
99
{% origin %}
1010
<h2 class="mt-3">Nomination status</h2>
11-
<table class="table table-sm table-striped table-hover tablesorter">
11+
<table class="table table-sm table-striped-columns table-hover tablesorter">
1212
<thead class="wrap-anywhere">
1313
<tr>
1414
<th scope="col" data-sort="position">Position</th>
@@ -156,7 +156,7 @@ <h2 class="mt-3">
156156
<i class="bi bi-check"></i>
157157
</th>
158158
{% endif %}
159-
<th scope="col" data-sort="nominee" colspan="2">
159+
<th scope="col" data-sort="nominee">
160160
Nominee
161161
</th>
162162
<th scope="col" data-sort="position">
@@ -194,9 +194,7 @@ <h2 class="mt-3">
194194
<a href="{% url 'ietf.person.views.profile' email_or_name=np.nominee.name %}">
195195
{{ np.nominee.email.name_and_email }}
196196
</a>
197-
</td>
198-
<td>
199-
<a class="btn btn-primary btn-sm"
197+
<a class="btn btn-primary btn-sm float-end"
200198
href="{% url 'ietf.nomcom.views.view_feedback_nominee' year=year nominee_id=np.nominee.id %}#comment">
201199
View feedback
202200
</a>

0 commit comments

Comments
 (0)