Skip to content

Commit 3be50d6

Browse files
Update session purposes and group type -> purpose map to match notes page, change 'session' purpose to 'regular'
- Legacy-Id: 19433
1 parent 7a2530a commit 3be50d6

6 files changed

Lines changed: 22 additions & 17 deletions

File tree

ietf/group/migrations/0052_populate_groupfeatures_session_purposes.py

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,21 @@
66

77

88
default_purposes = dict(
9-
dir=['presentation', 'social', 'tutorial'],
10-
ietf=['admin', 'presentation', 'social'],
11-
nomcom=['closed', 'officehours'],
12-
rg=['session'],
9+
adhoc=['presentation'],
10+
adm=['closed_meeting', 'officehours'],
11+
ag=['regular'],
12+
area=['regular'],
13+
dir=['presentation', 'social', 'tutorial', 'regular'],
14+
iab=['closed_meeting', 'regular'],
15+
iabasg=['open_meeting', 'closed_meeting'],
16+
ietf=['admin', 'plenary', 'presentation', 'social'],
17+
nomcom=['closed_meeting', 'officehours'],
18+
program=['regular', 'tutorial'],
19+
rag=['regular'],
20+
review=['open_meeting', 'social'],
21+
rg=['regular'],
1322
team=['coding', 'presentation', 'social', 'tutorial'],
14-
wg=['session'],
23+
wg=['regular'],
1524
)
1625

1726

ietf/meeting/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,7 @@ def prepare_sessions_for_display(sessions):
597597

598598
s.scheduling_label = "???"
599599
s.purpose_label = None
600-
if (s.purpose is None or s.purpose.slug == 'session') and s.group:
600+
if (s.purpose is None or s.purpose.slug == 'regular') and s.group:
601601
s.scheduling_label = s.group.acronym
602602
s.purpose_label = 'BoF' if s.group.is_bof() else s.group.type.name
603603
else:

ietf/name/migrations/0036_populate_sessionpurposename.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,16 @@ def forward(apps, schema_editor):
1010
TimeSlotTypeName = apps.get_model('name', 'TimeSlotTypeName')
1111

1212
for order, (slug, name, desc, tstypes) in enumerate((
13-
('session', 'Session', 'Group session', ['regular']),
13+
('regular', 'Regular', 'Regular group session', ['regular']),
1414
('tutorial', 'Tutorial', 'Tutorial or training session', ['other']),
1515
('officehours', 'Office hours', 'Office hours session', ['other']),
1616
('coding', 'Coding', 'Coding session', ['other']),
1717
('admin', 'Administrative', 'Meeting administration', ['other', 'reg']),
18-
('social', 'Social', 'Social event or activity', ['other']),
18+
('social', 'Social', 'Social event or activity', ['break', 'other']),
19+
('plenary', 'Plenary', 'Plenary session', ['plenary']),
1920
('presentation', 'Presentation', 'Presentation session', ['other', 'regular']),
20-
('closed', 'Closed meeting', 'Closed meeting', ['other',]),
21+
('open_meeting', 'Open meeting', 'Open meeting', ['other']),
22+
('closed_meeting', 'Closed meeting', 'Closed meeting', ['other', 'regular']),
2123
)):
2224
# verify that we're not about to use an invalid purpose
2325
for ts_type in tstypes:

ietf/secr/templates/includes/sessions_request_view.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<dl>
1010
<dt>Length</dt><dd>{{ sess_form.cleaned_data.requested_duration.total_seconds|display_duration }}</dd>
1111
{% if sess_form.cleaned_data.name %}<dt>Name</dt><dd>{{ sess_form.cleaned_data.name }}</dd>{% endif %}
12-
{% if sess_form.cleaned_data.purpose.slug != 'session' %}
12+
{% if sess_form.cleaned_data.purpose.slug != 'regular' %}
1313
<dt>Purpose</dt>
1414
<dd>
1515
{{ sess_form.cleaned_data.purpose }}

ietf/templates/meeting/edit_meeting_schedule.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -195,12 +195,6 @@
195195
{% endfor %}
196196
</span>
197197

198-
<span class="timeslot-type-toggles">
199-
{% for purpose in session_purposes %}
200-
<label class="purpose-{{ purpose.slug }}"><input type="checkbox" checked value="{{ purpose.slug }}"> {{ purpose }}</label>
201-
{% endfor %}
202-
</span>
203-
204198
<span class="timeslot-group-toggles">
205199
<button class="btn btn-default" data-toggle="modal" data-target="#timeslot-group-toggles-modal"><input type="checkbox" checked="checked" disabled> Timeslots</button>
206200
</span>

ietf/templates/meeting/edit_meeting_schedule_session.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div id="session{{ session.pk }}"
2-
class="session {% if not session.group.parent.scheduling_color %}untoggleable-by-parent{% endif %} {% if session.parent_acronym %}parent-{{ session.parent_acronym }} {% endif %}{% if session.purpose %}purpose-{{ session.purpose.slug }} {% else %} purpose-session {% endif %}{% if session.readonly %}readonly {% endif %}"
2+
class="session {% if not session.group.parent.scheduling_color %}untoggleable-by-parent{% endif %} {% if session.parent_acronym %}parent-{{ session.parent_acronym }}{% endif %} purpose-{% firstof session.purpose.slug 'regular' %} {% if session.readonly %}readonly{% endif %}"
33
style="width:{{ session.layout_width }}em;"
44
data-duration="{{ session.requested_duration.total_seconds }}" {% if session.attendees != None %}
55
data-attendees="{{ session.attendees }}"{% endif %}

0 commit comments

Comments
 (0)