Skip to content

Commit 2b1864f

Browse files
Fix merge errors in preceding commits
- Legacy-Id: 19556
1 parent d7f2034 commit 2b1864f

3 files changed

Lines changed: 28 additions & 5 deletions

File tree

ietf/meeting/forms.py

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,7 @@ def save(self, *args, **kwargs):
257257
session = super(InterimSessionModelForm, self).save(commit=False)
258258
session.group = self.group
259259
session.type_id = 'regular'
260+
session.purpose_id = 'regular'
260261
if kwargs.get('commit', True) is True:
261262
super(InterimSessionModelForm, self).save(commit=True)
262263
return session
@@ -600,13 +601,34 @@ def __init__(self, group, *args, **kwargs):
600601

601602
class Meta:
602603
model = Session
603-
fields = ('name', 'short', 'purpose', 'type', 'requested_duration', 'remote_instructions')
604+
fields = (
605+
'name', 'short', 'purpose', 'type', 'requested_duration',
606+
'on_agenda', 'remote_instructions', 'attendees', 'comments',
607+
)
604608
labels = {'requested_duration': 'Length'}
605609

610+
def clean(self):
611+
super().clean()
612+
if 'purpose' in self.cleaned_data and (
613+
'purpose' in self.changed_data or self.instance.pk is None
614+
):
615+
self.cleaned_data['on_agenda'] = self.cleaned_data['purpose'].on_agenda
616+
617+
return self.cleaned_data
618+
606619
class Media:
607620
js = ('ietf/js/meeting/session_details_form.js',)
608621

609622

623+
class SessionEditForm(SessionDetailsForm):
624+
"""Form to edit an existing session"""
625+
def __init__(self, instance, *args, **kwargs):
626+
kw_group = kwargs.pop('group', None)
627+
if kw_group is not None and kw_group != instance.group:
628+
raise ValueError('Session group does not match group keyword')
629+
super().__init__(instance=instance, group=instance.group, *args, **kwargs)
630+
631+
610632
class SessionDetailsInlineFormset(forms.BaseInlineFormSet):
611633
def __init__(self, group, meeting, queryset=None, *args, **kwargs):
612634
self._meeting = meeting
@@ -654,4 +676,4 @@ def sessiondetailsformset_factory(min_num=1, max_num=3):
654676
min_num=min_num,
655677
max_num=max_num,
656678
extra=max_num, # only creates up to max_num total
657-
)
679+
)

ietf/meeting/migrations/0049_session_on_agenda.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
class Migration(migrations.Migration):
77

88
dependencies = [
9-
('meeting', '0048_session_purpose'),
9+
('meeting', '0049_session_purpose'),
1010
]
1111

1212
operations = [

ietf/meeting/migrations/0049_session_purpose.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,15 @@
88
class Migration(migrations.Migration):
99

1010
dependencies = [
11-
('name', '0036_populate_sessionpurposename'),
11+
('name', '0035_populate_sessionpurposename'),
1212
('meeting', '0048_auto_20211008_0907'),
1313
]
1414

1515
operations = [
1616
migrations.AddField(
1717
model_name='session',
1818
name='purpose',
19-
field=ietf.utils.models.ForeignKey(help_text='Purpose of the session', null=True, on_delete=django.db.models.deletion.CASCADE, to='name.SessionPurposeName'),
19+
field=ietf.utils.models.ForeignKey(default='none', help_text='Purpose of the session', on_delete=django.db.models.deletion.CASCADE, to='name.SessionPurposeName'),
20+
preserve_default=False,
2021
),
2122
]

0 commit comments

Comments
 (0)