[Chore] Refactored getting Ookla speedtest servers (alexjustesen#1109)

Author: alexjustesen

app/Actions/GetOoklaSpeedtestServers.php

@@ -0,0 +1,41 @@
+<?php
+
+namespace App\Actions;
+
+use Illuminate\Http\Client\RequestException;
+use Illuminate\Http\Client\Response;
+use Illuminate\Support\Facades\Http;
+use Illuminate\Support\Facades\Log;
+use Lorisleiva\Actions\Concerns\AsAction;
+
+class GetOoklaSpeedtestServers
+{
+    use AsAction;
+
+    public function handle(): array
+    {
+        $query = [
+            'engine' => 'js',
+            'https_functional' => true,
+            'limit' => 20,
+        ];
+
+        $response = Http::retry(3, 250)
+            ->timeout(5)
+            ->get(url: 'https://www.speedtest.net/api/js/servers', query: $query)
+            ->throw(function (Response $response, RequestException $e) {
+                Log::error($e);
+
+                return [
+                    '0' => 'There was an issue retrieving Ookla speedtest servers, check the logs for more info.',
+                ];
+            })
+            ->collect();
+
+        return $response->mapWithKeys(function (array $item, int $key) {
+            return [
+                $item['id'] => $item['id'].': '.$item['name'].' ('.$item['sponsor'].')',
+            ];
+        })->toArray();
+    }
+}

app/Filament/Pages/Settings/GeneralPage.php

@@ -2,6 +2,7 @@
 
 namespace App\Filament\Pages\Settings;
 
+use App\Actions\GetOoklaSpeedtestServers;
 use App\Helpers\TimeZoneHelper;
 use App\Rules\Cron;
 use App\Settings\GeneralSettings;
@@ -97,28 +98,8 @@ public function form(Form $form): Form
                                     ->maxItems(10)
                                     ->multiple()
                                     ->nullable()
-                                    ->preload(false)
                                     ->searchable()
-                                    ->options(function (): array {
-                                        $response = Http::get(
-                                            url: 'https://www.speedtest.net/api/js/servers',
-                                            query: [
-                                                'engine' => 'js',
-                                                'https_functional' => true,
-                                                'limit' => 20,
-                                            ]
-                                        );
-
-                                        if ($response->failed()) {
-                                            return [
-                                                '' => 'There was an error retrieving Speedtest servers',
-                                            ];
-                                        }
-
-                                        return $response->collect()->mapWithKeys(function (array $item, int $key) {
-                                            return [$item['id'] => $item['id'].': '.$item['name'].' ('.$item['sponsor'].')'];
-                                        })->toArray();
-                                    })
+                                    ->options(GetOoklaSpeedtestServers::run())
                                     ->getSearchResultsUsing(fn (string $search): array => $this->getServerSearchOptions($search))
                                     ->getOptionLabelsUsing(fn (array $values): array => $this->getServerLabels($values))
                                     ->columnSpan('full'),